(defun get-method-function (method &optional method-alist wrappers)
(let ((fn (cadr (assoc method method-alist))))
(if fn
- (values fn nil nil nil)
- (multiple-value-bind (mf fmf)
- (if (listp method)
- (early-method-function method)
- (values nil (method-fast-function method)))
- (let* ((pv-table (and fmf (method-function-pv-table fmf))))
- (if (and fmf (or (null pv-table) wrappers))
- (let* ((pv-wrappers (when pv-table
- (pv-wrappers-from-all-wrappers
- pv-table wrappers)))
- (pv-cell (when (and pv-table pv-wrappers)
- (pv-table-lookup pv-table pv-wrappers))))
- (values mf t fmf pv-cell))
- (values
- (or mf (if (listp method)
- (setf (cadr method)
- (method-function-from-fast-function fmf))
- (method-function method)))
- t nil nil)))))))
+ (values fn nil nil nil)
+ (multiple-value-bind (mf fmf)
+ (if (listp method)
+ (early-method-function method)
+ (values nil (safe-method-fast-function method)))
+ (let* ((pv-table (and fmf (method-function-pv-table fmf))))
+ (if (and fmf (or (null pv-table) wrappers))
+ (let* ((pv-wrappers (when pv-table
+ (pv-wrappers-from-all-wrappers
+ pv-table wrappers)))
+ (pv-cell (when (and pv-table pv-wrappers)
+ (pv-table-lookup pv-table pv-wrappers))))
+ (values mf t fmf pv-cell))
+ (values
+ (or mf (if (listp method)
+ (setf (cadr method)
+ (method-function-from-fast-function fmf))
+ (method-function method)))
+ t nil nil)))))))
(defun make-effective-method-function (generic-function form &optional
- method-alist wrappers)
+ method-alist wrappers)
(funcall (make-effective-method-function1 generic-function form
- (not (null method-alist))
- (not (null wrappers)))
- method-alist wrappers))
+ (not (null method-alist))
+ (not (null wrappers)))
+ method-alist wrappers))
(defun make-effective-method-function1 (generic-function form
- method-alist-p wrappers-p)
+ method-alist-p wrappers-p)
(if (and (listp form)
- (eq (car form) 'call-method))
+ (eq (car form) 'call-method))
(make-effective-method-function-simple generic-function form)
;; We have some sort of `real' effective method. Go off and get a
;; compiled function for it. Most of the real hair here is done by
;; the GET-FUN mechanism.
(make-effective-method-function-internal generic-function form
- method-alist-p wrappers-p)))
+ method-alist-p wrappers-p)))
(defun make-effective-method-fun-type (generic-function
- form
- method-alist-p
- wrappers-p)
+ form
+ method-alist-p
+ wrappers-p)
(if (and (listp form)
- (eq (car form) 'call-method))
+ (eq (car form) 'call-method))
(let* ((cm-args (cdr form))
- (method (car cm-args)))
- (when method
- (if (if (listp method)
- (eq (car method) :early-method)
- (method-p method))
- (if method-alist-p
- t
- (multiple-value-bind (mf fmf)
- (if (listp method)
- (early-method-function method)
- (values nil (method-fast-function method)))
- (declare (ignore mf))
- (let* ((pv-table (and fmf (method-function-pv-table fmf))))
- (if (and fmf (or (null pv-table) wrappers-p))
- 'fast-method-call
- 'method-call))))
- (if (and (consp method) (eq (car method) 'make-method))
- (make-effective-method-fun-type
- generic-function (cadr method) method-alist-p wrappers-p)
- (type-of method)))))
+ (method (car cm-args)))
+ (when method
+ (if (if (listp method)
+ (eq (car method) :early-method)
+ (method-p method))
+ (if method-alist-p
+ t
+ (multiple-value-bind (mf fmf)
+ (if (listp method)
+ (early-method-function method)
+ (values nil (safe-method-fast-function method)))
+ (declare (ignore mf))
+ (let* ((pv-table (and fmf (method-function-pv-table fmf))))
+ (if (and fmf (or (null pv-table) wrappers-p))
+ 'fast-method-call
+ 'method-call))))
+ (if (and (consp method) (eq (car method) 'make-method))
+ (make-effective-method-fun-type
+ generic-function (cadr method) method-alist-p wrappers-p)
+ (type-of method)))))
'fast-method-call))
(defun make-effective-method-function-simple
;; asks about them. If it does, we must tell it whether there are
;; or aren't to prevent the leaky next methods bug.
(let* ((cm-args (cdr form))
- (fmf-p (and (null no-fmf-p)
- (or (not (eq *boot-state* 'complete))
- (gf-fast-method-function-p generic-function))
- (null (cddr cm-args))))
- (method (car cm-args))
- (cm-args1 (cdr cm-args)))
+ (fmf-p (and (null no-fmf-p)
+ (or (not (eq *boot-state* 'complete))
+ (gf-fast-method-function-p generic-function))
+ (null (cddr cm-args))))
+ (method (car cm-args))
+ (cm-args1 (cdr cm-args)))
(lambda (method-alist wrappers)
(make-effective-method-function-simple1 generic-function
- method
- cm-args1
- fmf-p
- method-alist
- wrappers))))
+ method
+ cm-args1
+ fmf-p
+ method-alist
+ wrappers))))
(defun make-emf-from-method
(method cm-args &optional gf fmf-p method-alist wrappers)
(multiple-value-bind (mf real-mf-p fmf pv-cell)
(get-method-function method method-alist wrappers)
(if fmf
- (let* ((next-methods (car cm-args))
- (next (make-effective-method-function-simple1
- gf (car next-methods)
- (list* (cdr next-methods) (cdr cm-args))
- fmf-p method-alist wrappers))
- (arg-info (method-function-get fmf :arg-info)))
- (make-fast-method-call :function fmf
- :pv-cell pv-cell
- :next-method-call next
- :arg-info arg-info))
- (if real-mf-p
- (make-method-call :function mf
- :call-method-args cm-args)
- mf))))
+ (let* ((next-methods (car cm-args))
+ (next (make-effective-method-function-simple1
+ gf (car next-methods)
+ (list* (cdr next-methods) (cdr cm-args))
+ fmf-p method-alist wrappers))
+ (arg-info (method-function-get fmf :arg-info)))
+ (make-fast-method-call :function fmf
+ :pv-cell pv-cell
+ :next-method-call next
+ :arg-info arg-info))
+ (if real-mf-p
+ (make-method-call :function mf
+ :call-method-args cm-args)
+ mf))))
(defun make-effective-method-function-simple1
(gf method cm-args fmf-p &optional method-alist wrappers)
(when method
(if (if (listp method)
- (eq (car method) :early-method)
- (method-p method))
- (make-emf-from-method method cm-args gf fmf-p method-alist wrappers)
- (if (and (consp method) (eq (car method) 'make-method))
- (make-effective-method-function gf
- (cadr method)
- method-alist wrappers)
- method))))
+ (eq (car method) :early-method)
+ (method-p method))
+ (make-emf-from-method method cm-args gf fmf-p method-alist wrappers)
+ (if (and (consp method) (eq (car method) 'make-method))
+ (make-effective-method-function gf
+ (cadr method)
+ method-alist wrappers)
+ method))))
(defvar *global-effective-method-gensyms* ())
(defvar *rebound-effective-method-gensyms*)
(defun get-effective-method-gensym ()
(or (pop *rebound-effective-method-gensyms*)
- (let ((new (intern (format nil
- "EFFECTIVE-METHOD-GENSYM-~D"
- (length *global-effective-method-gensyms*))
- *pcl-package*)))
- (setq *global-effective-method-gensyms*
- (append *global-effective-method-gensyms* (list new)))
- new)))
+ (let ((new (format-symbol *pcl-package*
+ "EFFECTIVE-METHOD-GENSYM-~D"
+ (length *global-effective-method-gensyms*))))
+ (setq *global-effective-method-gensyms*
+ (append *global-effective-method-gensyms* (list new)))
+ new)))
(let ((*rebound-effective-method-gensyms* ()))
(dotimes-fixnum (i 10) (get-effective-method-gensym)))
(get-generic-fun-info gf)
(declare (ignore nreq nkeys arg-info))
(let ((ll (make-fast-method-call-lambda-list metatypes applyp))
- (check-applicable-keywords
- (when (and applyp (gf-requires-emf-keyword-checks gf))
- '((check-applicable-keywords))))
- (error-p (or (eq (first effective-method) '%no-primary-method)
- (eq (first effective-method) '%invalid-qualifiers)))
- (mc-args-p
- (when (eq *boot-state* 'complete)
- ;; Otherwise the METHOD-COMBINATION slot is not bound.
- (let ((combin (generic-function-method-combination gf)))
- (and (long-method-combination-p combin)
- (long-method-combination-args-lambda-list combin))))))
+ (check-applicable-keywords
+ (when (and applyp (gf-requires-emf-keyword-checks gf))
+ '((check-applicable-keywords))))
+ (error-p (or (eq (first effective-method) '%no-primary-method)
+ (eq (first effective-method) '%invalid-qualifiers)))
+ (mc-args-p
+ (when (eq *boot-state* 'complete)
+ ;; Otherwise the METHOD-COMBINATION slot is not bound.
+ (let ((combin (generic-function-method-combination gf)))
+ (and (long-method-combination-p combin)
+ (long-method-combination-args-lambda-list combin))))))
(cond
- (error-p
- `(lambda (.pv-cell. .next-method-call. &rest .args.)
- (declare (ignore .pv-cell. .next-method-call.))
- (declare (ignorable .args.))
- (flet ((%no-primary-method (gf args)
- (apply #'no-primary-method gf args))
- (%invalid-qualifiers (gf combin method)
- (invalid-qualifiers gf combin method)))
- (declare (ignorable #'%no-primary-method #'%invalid-qualifiers))
- ,effective-method)))
- (mc-args-p
- (let* ((required
- ;; FIXME: Ick. Shared idiom, too, with stuff in cache.lisp
- (let (req)
- (dotimes (i (length metatypes) (nreverse req))
- (push (dfun-arg-symbol i) req))))
- (gf-args (if applyp
- `(list* ,@required .dfun-rest-arg.)
- `(list ,@required))))
- `(lambda ,ll
- (declare (ignore .pv-cell. .next-method-call.))
- (let ((.gf-args. ,gf-args))
- (declare (ignorable .gf-args.))
- ,@check-applicable-keywords
- ,effective-method))))
- (t
- `(lambda ,ll
- (declare (ignore ,@(if error-p ll '(.pv-cell. .next-method-call.))))
- ,@check-applicable-keywords
- ,effective-method))))))
+ (error-p
+ `(lambda (.pv-cell. .next-method-call. &rest .args.)
+ (declare (ignore .pv-cell. .next-method-call.))
+ (declare (ignorable .args.))
+ (flet ((%no-primary-method (gf args)
+ (apply #'no-primary-method gf args))
+ (%invalid-qualifiers (gf combin method)
+ (invalid-qualifiers gf combin method)))
+ (declare (ignorable #'%no-primary-method #'%invalid-qualifiers))
+ ,effective-method)))
+ (mc-args-p
+ (let* ((required
+ ;; FIXME: Ick. Shared idiom, too, with stuff in cache.lisp
+ (let (req)
+ (dotimes (i (length metatypes) (nreverse req))
+ (push (dfun-arg-symbol i) req))))
+ (gf-args (if applyp
+ `(list* ,@required .dfun-rest-arg.)
+ `(list ,@required))))
+ `(lambda ,ll
+ (declare (ignore .pv-cell. .next-method-call.))
+ (let ((.gf-args. ,gf-args))
+ (declare (ignorable .gf-args.))
+ ,@check-applicable-keywords
+ ,effective-method))))
+ (t
+ `(lambda ,ll
+ (declare (ignore ,@(if error-p ll '(.pv-cell. .next-method-call.))))
+ ,@check-applicable-keywords
+ ,effective-method))))))
(defun expand-emf-call-method (gf form metatypes applyp env)
(declare (ignore gf metatypes applyp env))
(defmacro call-method (&rest args)
(declare (ignore args))
- `(error "~S outside of a effective method form" 'call-method))
+ ;; the PROGN is here to defend against premature macroexpansion by
+ ;; RESTART-CASE.
+ `(progn (error "~S outside of a effective method form" 'call-method)))
(defun make-effective-method-list-fun-type
(generic-function form method-alist-p wrappers-p)
(if (every (lambda (form)
- (eq 'fast-method-call
- (make-effective-method-fun-type
- generic-function form method-alist-p wrappers-p)))
- (cdr form))
+ (eq 'fast-method-call
+ (make-effective-method-fun-type
+ generic-function form method-alist-p wrappers-p)))
+ (cdr form))
'fast-method-call
t))
(case (and (consp form) (car form))
(call-method
(case (make-effective-method-fun-type
- generic-function form method-alist-p wrappers-p)
+ generic-function form method-alist-p wrappers-p)
(fast-method-call '.fast-call-method.)
(t '.call-method.)))
(call-method-list
(case (make-effective-method-list-fun-type
- generic-function form method-alist-p wrappers-p)
+ generic-function form method-alist-p wrappers-p)
(fast-method-call '.fast-call-method-list.)
(t '.call-method-list.)))
(check-applicable-keywords 'check-applicable-keywords)
(call-method
(let ((gensym (get-effective-method-gensym)))
(values (make-emf-call
- metatypes applyp gensym
- (make-effective-method-fun-type
- generic-function form method-alist-p wrappers-p))
- (list gensym))))
+ metatypes applyp gensym
+ (make-effective-method-fun-type
+ generic-function form method-alist-p wrappers-p))
+ (list gensym))))
(call-method-list
(let ((gensym (get-effective-method-gensym))
- (type (make-effective-method-list-fun-type
- generic-function form method-alist-p wrappers-p)))
+ (type (make-effective-method-list-fun-type
+ generic-function form method-alist-p wrappers-p)))
(values `(dolist (emf ,gensym nil)
- ,(make-emf-call metatypes applyp 'emf type))
- (list gensym))))
+ ,(make-emf-call metatypes applyp 'emf type))
+ (list gensym))))
(check-applicable-keywords
(values `(check-applicable-keywords
- .dfun-rest-arg. .keyargs-start. .valid-keys.)
- '(.keyargs-start. .valid-keys.)))
-
+ .dfun-rest-arg. .keyargs-start. .valid-keys.)
+ '(.keyargs-start. .valid-keys.)))
+
(t
(default-code-converter form))))
(case (and (consp form) (car form))
(call-method
(list (cons '.meth.
- (make-effective-method-function-simple
- generic-function form))))
+ (make-effective-method-function-simple
+ generic-function form))))
(call-method-list
(list (cons '.meth-list.
- (mapcar (lambda (form)
- (make-effective-method-function-simple
- generic-function form))
- (cdr form)))))
+ (mapcar (lambda (form)
+ (make-effective-method-function-simple
+ generic-function form))
+ (cdr form)))))
(check-applicable-keywords
'(.keyargs-start. .valid-keys.))
(t
(get-generic-fun-info generic-function)
(declare (ignore nkeys arg-info))
(let* ((*rebound-effective-method-gensyms*
- *global-effective-method-gensyms*)
- (name (if (early-gf-p generic-function)
- (!early-gf-name generic-function)
- (generic-function-name generic-function)))
- (arg-info (cons nreq applyp))
- (effective-method-lambda (expand-effective-method-function
- generic-function effective-method)))
+ *global-effective-method-gensyms*)
+ (name (if (early-gf-p generic-function)
+ (!early-gf-name generic-function)
+ (generic-function-name generic-function)))
+ (arg-info (cons nreq applyp))
+ (effective-method-lambda (expand-effective-method-function
+ generic-function effective-method)))
(multiple-value-bind (cfunction constants)
- (get-fun1 effective-method-lambda
- (lambda (form)
- (memf-test-converter form generic-function
- method-alist-p wrappers-p))
- (lambda (form)
- (memf-code-converter form generic-function
- metatypes applyp
- method-alist-p wrappers-p))
- (lambda (form)
- (memf-constant-converter form generic-function)))
- (lambda (method-alist wrappers)
- (multiple-value-bind (valid-keys keyargs-start)
- (when (memq '.valid-keys. constants)
- (compute-applicable-keywords
- generic-function *applicable-methods*))
- (flet ((compute-constant (constant)
- (if (consp constant)
- (case (car constant)
- (.meth.
- (funcall (cdr constant) method-alist wrappers))
- (.meth-list.
- (mapcar (lambda (fn)
- (funcall fn method-alist wrappers))
- (cdr constant)))
- (t constant))
- (case constant
- (.keyargs-start. keyargs-start)
- (.valid-keys. valid-keys)
- (t constant)))))
- (let ((fun (apply cfunction
- (mapcar #'compute-constant constants))))
- (set-fun-name fun `(combined-method ,name))
- (make-fast-method-call :function fun
- :arg-info arg-info)))))))))
+ (get-fun1 effective-method-lambda
+ (lambda (form)
+ (memf-test-converter form generic-function
+ method-alist-p wrappers-p))
+ (lambda (form)
+ (memf-code-converter form generic-function
+ metatypes applyp
+ method-alist-p wrappers-p))
+ (lambda (form)
+ (memf-constant-converter form generic-function)))
+ (lambda (method-alist wrappers)
+ (multiple-value-bind (valid-keys keyargs-start)
+ (when (memq '.valid-keys. constants)
+ (compute-applicable-keywords
+ generic-function *applicable-methods*))
+ (flet ((compute-constant (constant)
+ (if (consp constant)
+ (case (car constant)
+ (.meth.
+ (funcall (cdr constant) method-alist wrappers))
+ (.meth-list.
+ (mapcar (lambda (fn)
+ (funcall fn method-alist wrappers))
+ (cdr constant)))
+ (t constant))
+ (case constant
+ (.keyargs-start. keyargs-start)
+ (.valid-keys. valid-keys)
+ (t constant)))))
+ (let ((fun (apply cfunction
+ (mapcar #'compute-constant constants))))
+ (set-fun-name fun `(combined-method ,name))
+ (make-fast-method-call :function fun
+ :arg-info arg-info)))))))))
(defmacro call-method-list (&rest calls)
`(progn ,@calls))
(defun gf-requires-emf-keyword-checks (generic-function)
(member '&key (gf-lambda-list generic-function)))
+(defvar *in-precompute-effective-methods-p* nil)
+
(defun standard-compute-effective-method
(generic-function combin applicable-methods)
(collect ((before) (primary) (after) (around))
(flet ((invalid (gf combin m)
- (if *in-precompute-effective-methods-p*
- (return-from standard-compute-effective-method
- `(%invalid-qualifiers ',gf ',combin ',m))
- (invalid-qualifiers gf combin m))))
+ (if *in-precompute-effective-methods-p*
+ (return-from standard-compute-effective-method
+ `(%invalid-qualifiers ',gf ',combin ',m))
+ (invalid-qualifiers gf combin m))))
(dolist (m applicable-methods)
- (let ((qualifiers (if (listp m)
- (early-method-qualifiers m)
- (method-qualifiers m))))
- (cond
- ((null qualifiers) (primary m))
- ((cdr qualifiers) (invalid generic-function combin m))
- ((eq (car qualifiers) :around) (around m))
- ((eq (car qualifiers) :before) (before m))
- ((eq (car qualifiers) :after) (after m))
- (t (invalid generic-function combin m))))))
+ (let ((qualifiers (if (listp m)
+ (early-method-qualifiers m)
+ (method-qualifiers m))))
+ (cond
+ ((null qualifiers) (primary m))
+ ((cdr qualifiers) (invalid generic-function combin m))
+ ((eq (car qualifiers) :around) (around m))
+ ((eq (car qualifiers) :before) (before m))
+ ((eq (car qualifiers) :after) (after m))
+ (t (invalid generic-function combin m))))))
(cond ((null (primary))
- `(%no-primary-method ',generic-function .args.))
- ((and (null (before)) (null (after)) (null (around)))
- ;; By returning a single call-method `form' here we enable
- ;; an important implementation-specific optimization; that
- ;; is, we can use the fast method function directly as the
- ;; effective method function.
- ;;
- ;; However, the requirement by ANSI (CLHS 7.6.5) on generic
- ;; function argument checking inhibits this, as we don't
- ;; perform this checking in fast-method-functions given
- ;; that they are not solely used for effective method
- ;; functions, but also in combination, when they should not
- ;; perform argument checks.
- (let ((call-method
- `(call-method ,(first (primary)) ,(rest (primary)))))
- (if (gf-requires-emf-keyword-checks generic-function)
- ;; the PROGN inhibits the above optimization
- `(progn ,call-method)
- call-method)))
- (t
- (let ((main-effective-method
- (if (or (before) (after))
- `(multiple-value-prog1
- (progn
- ,(make-call-methods (before))
- (call-method ,(first (primary))
- ,(rest (primary))))
- ,(make-call-methods (reverse (after))))
- `(call-method ,(first (primary)) ,(rest (primary))))))
- (if (around)
- `(call-method ,(first (around))
- (,@(rest (around))
- (make-method ,main-effective-method)))
- main-effective-method))))))
+ `(%no-primary-method ',generic-function .args.))
+ ((and (null (before)) (null (after)) (null (around)))
+ ;; By returning a single call-method `form' here we enable
+ ;; an important implementation-specific optimization; that
+ ;; is, we can use the fast method function directly as the
+ ;; effective method function.
+ ;;
+ ;; However, the requirement by ANSI (CLHS 7.6.5) on generic
+ ;; function argument checking inhibits this, as we don't
+ ;; perform this checking in fast-method-functions given
+ ;; that they are not solely used for effective method
+ ;; functions, but also in combination, when they should not
+ ;; perform argument checks.
+ (let ((call-method
+ `(call-method ,(first (primary)) ,(rest (primary)))))
+ (if (gf-requires-emf-keyword-checks generic-function)
+ ;; the PROGN inhibits the above optimization
+ `(progn ,call-method)
+ call-method)))
+ (t
+ (let ((main-effective-method
+ (if (or (before) (after))
+ `(multiple-value-prog1
+ (progn
+ ,(make-call-methods (before))
+ (call-method ,(first (primary))
+ ,(rest (primary))))
+ ,(make-call-methods (reverse (after))))
+ `(call-method ,(first (primary)) ,(rest (primary))))))
+ (if (around)
+ `(call-method ,(first (around))
+ (,@(rest (around))
+ (make-method ,main-effective-method)))
+ main-effective-method))))))
\f
;;; helper code for checking keywords in generic function calls.
(defun compute-applicable-keywords (gf methods)
(let ((any-keyp nil))
(flet ((analyze (lambda-list)
- (multiple-value-bind (nreq nopt keyp restp allowp keys)
- (analyze-lambda-list lambda-list)
- (declare (ignore nreq restp))
- (when keyp
- (setq any-keyp t))
- (values nopt allowp keys))))
+ (multiple-value-bind (nreq nopt keyp restp allowp keys)
+ (analyze-lambda-list lambda-list)
+ (declare (ignore nreq restp))
+ (when keyp
+ (setq any-keyp t))
+ (values nopt allowp keys))))
(multiple-value-bind (nopt allowp keys)
- (analyze (generic-function-lambda-list gf))
- (dolist (method methods)
- (let ((ll (if (consp method)
- (early-method-lambda-list method)
- (method-lambda-list method))))
- (multiple-value-bind (n allowp method-keys)
- (analyze ll)
- (declare (ignore n))
- (when allowp
- (return-from compute-applicable-keywords (values t nopt)))
- (setq keys (union method-keys keys)))))
- (aver any-keyp)
- (values (if allowp t keys) nopt)))))
+ (analyze (generic-function-lambda-list gf))
+ (dolist (method methods)
+ (let ((ll (if (consp method)
+ (early-method-lambda-list method)
+ (method-lambda-list method))))
+ (multiple-value-bind (n allowp method-keys)
+ (analyze ll)
+ (declare (ignore n))
+ (when allowp
+ (return-from compute-applicable-keywords (values t nopt)))
+ (setq keys (union method-keys keys)))))
+ (aver any-keyp)
+ (values (if allowp t keys) nopt)))))
(defun check-applicable-keywords (args start valid-keys)
(let ((allow-other-keys-seen nil)
- (allow-other-keys nil)
- (args (nthcdr start args)))
+ (allow-other-keys nil)
+ (args (nthcdr start args)))
(collect ((invalid))
(loop
(when (null args)
- (when (and (invalid) (not allow-other-keys))
- (error 'simple-program-error
- :format-control "~@<invalid keyword argument~P: ~
+ (when (and (invalid) (not allow-other-keys))
+ (error 'simple-program-error
+ :format-control "~@<invalid keyword argument~P: ~
~{~S~^, ~} (valid keys are ~{~S~^, ~}).~@:>"
- :format-arguments (list (length (invalid)) (invalid) valid-keys)))
- (return))
+ :format-arguments (list (length (invalid)) (invalid) valid-keys)))
+ (return))
(let ((key (pop args)))
- (cond
- ((not (symbolp key))
- (error 'simple-program-error
- :format-control "~@<keyword argument not a symbol: ~S.~@:>"
- :format-arguments (list key)))
- ((null args) (sb-c::%odd-key-args-error))
- ((eq key :allow-other-keys)
- ;; only the leftmost :ALLOW-OTHER-KEYS has any effect
- (unless allow-other-keys-seen
- (setq allow-other-keys-seen t
- allow-other-keys (car args))))
- ((eq t valid-keys))
- ((not (memq key valid-keys)) (invalid key))))
+ (cond
+ ((not (symbolp key))
+ (error 'simple-program-error
+ :format-control "~@<keyword argument not a symbol: ~S.~@:>"
+ :format-arguments (list key)))
+ ((null args) (sb-c::%odd-key-args-error))
+ ((eq key :allow-other-keys)
+ ;; only the leftmost :ALLOW-OTHER-KEYS has any effect
+ (unless allow-other-keys-seen
+ (setq allow-other-keys-seen t
+ allow-other-keys (car args))))
+ ((eq t valid-keys))
+ ((not (memq key valid-keys)) (invalid key))))
(pop args)))))
\f
;;;; the STANDARD method combination type. This is coded by hand
(defun compute-effective-method (generic-function combin applicable-methods)
(standard-compute-effective-method generic-function
- combin
- applicable-methods))
+ combin
+ applicable-methods))
(defun invalid-method-error (method format-control &rest format-arguments)
(let ((sb-debug:*stack-top-hint* (nth-value 1 (find-caller-name-and-frame))))
(error "~@<invalid method error for ~2I~_~S ~I~_method: ~2I~_~?~:>"
- method
- format-control
- format-arguments)))
+ method
+ format-control
+ format-arguments)))
(defun method-combination-error (format-control &rest format-arguments)
(let ((sb-debug:*stack-top-hint* (nth-value 1 (find-caller-name-and-frame))))
(error "~@<method combination error in CLOS dispatch: ~2I~_~?~:>"
- format-control
- format-arguments)))
+ format-control
+ format-arguments)))