;;;; absolutely no warranty. See the COPYING and CREDITS files for
;;;; more information.
+(load "test-util.lisp")
(load "assertoid.lisp")
(defpackage :seq-test
- (:use :cl :assertoid))
+ (:use :cl :assertoid :test-util))
(in-package :seq-test)
+;;; user-defined mock sequence class for testing generic versions of
+;;; sequence functions.
+(defclass list-backed-sequence (standard-object
+ sequence)
+ ((elements :initarg :elements :type list :accessor %elements)))
+
+(defmethod sequence:make-sequence-like ((sequence list-backed-sequence) length
+ &rest args &key
+ initial-element initial-contents)
+ (declare (ignore initial-element initial-contents))
+ (make-instance 'list-backed-sequence
+ :elements (apply #'sequence:make-sequence-like
+ '() length args)))
+
+(defmethod sequence:length ((sequence list-backed-sequence))
+ (length (%elements sequence)))
+
+(defmethod sequence:elt
+ ((sequence list-backed-sequence) index)
+ (nth index (%elements sequence)))
+
+(defmethod (setf sequence:elt)
+ (new-value (sequence list-backed-sequence) index)
+ (setf (nth index (%elements sequence)) new-value))
+
;;; helper functions for exercising SEQUENCE code on data of many
;;; specialized types, and in many different optimization scenarios
(defun for-every-seq-1 (base-seq snippet)
- (dolist (seq-type '(list
- (simple-array t 1)
- (vector t)
- (simple-array character 1)
- (vector character)
- (simple-array (signed-byte 4) 1)
- (vector (signed-byte 4))))
- (flet ((entirely (eltype)
- (every (lambda (el) (typep el eltype)) base-seq)))
+ (labels
+ ((entirely (eltype)
+ (every (lambda (el) (typep el eltype)) base-seq))
+ (make-sequence-for-type (type)
+ (etypecase type
+ ((member list list-backed-sequence)
+ (coerce base-seq type))
+ ((cons (eql simple-array) (cons * (cons (eql 1) null)))
+ (destructuring-bind (eltype one) (rest type)
+ (when (entirely eltype)
+ (coerce base-seq type))))
+ ((cons (eql vector))
+ (destructuring-bind (eltype) (rest type)
+ (when (entirely eltype)
+ (let ((initial-element
+ (cond ((subtypep eltype 'character)
+ #\!)
+ ((subtypep eltype 'number)
+ 0)
+ (t #'error))))
+ (replace (make-array
+ (+ (length base-seq)
+ (random 3))
+ :element-type eltype
+ :fill-pointer
+ (length base-seq)
+ :initial-element
+ initial-element)
+ base-seq))))))))
+ (dolist (seq-type '(list
+ (simple-array t 1)
+ (vector t)
+ (simple-array character 1)
+ (vector character)
+ (simple-array (signed-byte 4) 1)
+ (vector (signed-byte 4))
+ list-backed-sequence))
(dolist (declaredness '(nil t))
(dolist (optimization '(((speed 3) (space 0))
((speed 2) (space 2))
((speed 1) (space 2))
((speed 0) (space 1))))
- (let* ((seq (if (eq seq-type 'list)
- (coerce base-seq 'list)
- (destructuring-bind (type-first &rest type-rest)
- seq-type
- (ecase type-first
- (simple-array
- (destructuring-bind (eltype one) type-rest
- (assert (= one 1))
- (if (entirely eltype)
- (coerce base-seq seq-type)
- (return))))
- (vector
- (destructuring-bind (eltype) type-rest
- (if (entirely eltype)
- (let ((initial-element
- (cond ((subtypep eltype 'character)
- #\!)
- ((subtypep eltype 'number)
- 0)
- (t #'error))))
- (replace (make-array
- (+ (length base-seq)
- (random 3))
- :element-type eltype
- :fill-pointer
- (length base-seq)
- :initial-element
- initial-element)
- base-seq))
- (return))))))))
- (lambda-expr `(lambda (seq)
- ,@(when declaredness
- `((declare (type ,seq-type seq))))
- (declare (optimize ,@optimization))
- ,snippet)))
+ (let ((seq (make-sequence-for-type seq-type))
+ (lambda-expr `(lambda (seq)
+ ,@(when declaredness
+ `((declare (type ,seq-type seq))))
+ (declare (optimize ,@optimization))
+ ,snippet)))
+ (when (not seq)
+ (return))
(format t "~&~S~%" lambda-expr)
(multiple-value-bind (fun warnings-p failure-p)
(compile nil lambda-expr)
(assert (eql 4 ; modified more, avoids charset technicalities completely
(find 5 '(6 4) :test '>)))
+(with-test (:name sequence:emptyp)
+ (for-every-seq #()
+ '((eq t (sequence:emptyp seq))))
+ (for-every-seq #(1)
+ '((eq nil (sequence:emptyp seq)))))
+
;;; tests of FIND, POSITION, FIND-IF, and POSITION-IF (and a few for
;;; deprecated FIND-IF-NOT and POSITION-IF-NOT too)
(for-every-seq #()
(eql 3 (position-if #'plusp seq :from-end t :key '1- :start 2))
(null (position-if #'plusp seq :from-end t :key '1- :start 2 :end 2))
(null (find-if-not #'plusp seq))
- (eql 0 (position-if-not #'evenp seq))))
+ (eql 0 (position-if-not #'evenp seq))
+ (eql 0 (search #(1) seq))
+ (eql 1 (search #(4 5) seq :key 'oddp))
+ (eql 1 (search #(-2) seq :test (lambda (a b) (= (- a) b))))
+ (eql 4 (search #(1) seq :start2 1))
+ (null (search #(3) seq :start2 3))
+ (eql 2 (search #(3) seq :start2 2))
+ (eql 0 (search #(1 2) seq))
+ (null (search #(2 1 3) seq))
+ (eql 0 (search #(0 1 2 4) seq :start1 1 :end1 3))
+ (eql 3 (search #(0 2 1 4) seq :start1 1 :end1 3))
+ (eql 4 (search #(1) seq :from-end t))
+ (eql 0 (search #(1 2) seq :from-end t))
+ (null (search #(1 2) seq :from-end t :start2 1))
+ (eql 0 (search #(0 1 2 4) seq :from-end t :start1 1 :end1 3))
+ (eql 3 (search #(0 2 1 4) seq :from-end t :start1 1 :end1 3))
+ (null (search #(2 1 3) seq :from-end t))))
(for-every-seq "string test"
'((null (find 0 seq))
(null (find #\D seq :key #'char-upcase))
(coerce #(0 0 0 1 1 1) `(,@type-stub 6))))
(assert-type-error (concatenate `(,@type-stub 5) #(0 0 0) #*111))
;; MERGE
- (assert (= (length (merge `(,@type-stub) #(0 1 0) #*111 #'>)) 6))
- (assert (equalp (merge `(,@type-stub) #(0 1 0) #*111 #'>)
- (coerce #(1 1 1 0 1 0) `(,@type-stub))))
- (assert (= (length (merge `(,@type-stub 6) #(0 1 0) #*111 #'>)) 6))
- (assert (equalp (merge `(,@type-stub 6) #(0 1 0) #*111 #'>)
- (coerce #(1 1 1 0 1 0) `(,@type-stub 6))))
- (assert-type-error (merge `(,@type-stub 4) #(0 1 0) #*111 #'>))
+ (macrolet ((test (type)
+ `(merge ,type (copy-seq #(0 1 0)) (copy-seq #*111) #'>)))
+ (assert (= (length (test `(,@type-stub))) 6))
+ (assert (equalp (test `(,@type-stub))
+ (coerce #(1 1 1 0 1 0) `(,@type-stub))))
+ (assert (= (length (test `(,@type-stub 6))) 6))
+ (assert (equalp (test `(,@type-stub 6))
+ (coerce #(1 1 1 0 1 0) `(,@type-stub 6))))
+ (assert-type-error (test `(,@type-stub 4))))
;; MAP
(assert (= (length (map `(,@type-stub) #'logxor #(0 0 1 1) '(0 1 0 1))) 4))
(assert (equalp (map `(,@type-stub) #'logxor #(0 0 1 1) '(0 1 0 1))
(assert (equalp #(11 13)
(map '(simple-array fixnum (*)) #'+ '(1 2 3) '(10 11))))
(assert-type-error (coerce '(1 2 3) 'simple-array))
- (assert-type-error (merge 'simple-array '(1 3) '(2 4) '<))
+ (assert-type-error (merge 'simple-array (list 1 3) (list 2 4) '<))
(assert (equalp #(3 2 1) (coerce '(3 2 1) '(vector fixnum))))
(assert-type-error (map 'array #'identity '(1 2 3)))
(assert-type-error (map '(array fixnum) #'identity '(1 2 3)))
;; ... though not in all cases.
(assert-type-error (coerce '(#\f #\o #\o) 'simple-array))))
+;; CONCATENATE used to fail for generic sequences for result-type NULL.
+(with-test (:name (concatenate :result-type-null :bug-1162301))
+ (assert (sequence:emptyp (concatenate 'null)))
+
+ (for-every-seq #()
+ '((sequence:emptyp (concatenate 'null seq))
+ (sequence:emptyp (concatenate 'null seq seq))
+ (sequence:emptyp (concatenate 'null seq #()))
+ (sequence:emptyp (concatenate 'null seq ""))))
+
+ (for-every-seq #(1)
+ (mapcar (lambda (form)
+ `(typep (nth-value 1 (ignore-errors ,form)) 'type-error))
+ '((concatenate 'null seq)
+ (concatenate 'null seq seq)
+ (concatenate 'null seq #())
+ (concatenate 'null seq "2")))))
+
;;; As pointed out by Raymond Toy on #lisp IRC, MERGE had some issues
;;; with user-defined types until sbcl-0.7.8.11
(deftype list-typeoid () 'list)
-(assert (equal '(1 2 3 4) (merge 'list-typeoid '(1 3) '(2 4) '<)))
+(assert (equal '(1 2 3 4) (merge 'list-typeoid (list 1 3) (list 2 4) '<)))
;;; and also with types that weren't precicely LIST
-(assert (equal '(1 2 3 4) (merge 'cons '(1 3) '(2 4) '<)))
+(assert (equal '(1 2 3 4) (merge 'cons (list 1 3) (list 2 4) '<)))
;;; but wait, there's more! The NULL and CONS types also have implicit
;;; length requirements:
(assert (= (length (coerce #(1) '(cons t null))) 1))
(assert-type-error (coerce #() 'nil))
;; MERGE
- (assert-type-error (merge 'null '(1 3) '(2 4) '<))
+ (assert-type-error (merge 'null (list 1 3) (list 2 4) '<))
(assert-type-error (merge 'cons () () '<))
(assert (null (merge 'null () () '<)))
- (assert (= (length (merge 'cons '(1 3) '(2 4) '<)) 4))
+ (assert (= (length (merge 'cons (list 1 3) (list 2 4) '<)) 4))
(assert (= (length (merge '(cons t (cons t (cons t (cons t null))))
- '(1 3) '(2 4) '<)) 4))
+ (list 1 3) (list 2 4)
+ '<))
+ 4))
(assert-type-error (merge 'nil () () '<))
;; CONCATENATE
- (assert-type-error (concatenate 'null '(1) "2"))
(assert-type-error (concatenate 'cons #() ()))
(assert-type-error (concatenate '(cons t null) #(1 2 3) #(4 5 6)))
- (assert (null (concatenate 'null () #())))
(assert (= (length (concatenate 'cons #() '(1) "2 3")) 4))
(assert (= (length (concatenate '(cons t cons) '(1) "34")) 3))
(assert-type-error (concatenate 'nil '(3)))
(svref x 0))
(assert (raises-error? (svrefalike #*0) type-error))
\f
-;;; checks for uniform bounding index handling under SAFETY 3 code.
+;;; checks for uniform bounding index handling.
+;;;
+;;; This used to be SAFETY 3 only, but bypassing these checks with
+;;; above-zero speed when SPEED > SAFETY is not The SBCL Way.
;;;
;;; KLUDGE: not all in one big form because that causes SBCL to spend
;;; an absolute age trying to compile it.
(defmacro sequence-bounding-indices-test (&body body)
`(progn
- (locally
+ (locally
;; See Issues 332 [and 333(!)] in the CLHS
- (declare (optimize (safety 3)))
+ (declare (optimize (speed 3) (safety 1)))
(let ((string (make-array 10
:fill-pointer 5
:initial-element #\a
,@(cdr body))))
(locally
;; See Issues 332 [and 333(!)] in the CLHS
- (declare (optimize (safety 3)))
+ (declare (optimize (speed 3) (safety 1)))
(let ((string (make-array 10
:fill-pointer 5
:initial-element #\a
(sequence-bounding-indices-test
(format t "~&/Function PARSE-NAMESTRING")
(setf (fill-pointer string) 10)
- (setf (subseq string 0 10) "/dev/ /tmp")
+ (setf (subseq string 0 10)
+ #-win32 "/dev/ /tmp"
+ #+win32 "C:/ NUL")
(setf (fill-pointer string) 5)
(assert (truename (parse-namestring string nil *default-pathname-defaults*
:start 0 :end 5)))
standard bashed)
;; fill vectors
;; a) the standard slow way
- (fill standard c :start offset :end (+ offset n))
+ (locally (declare (notinline fill))
+ (fill standard c :start offset :end (+ offset n)))
;; b) the blazingly fast way
(let ((value (loop for i from 0 by bitsize
until (= i sb-vm:n-word-bits)
bashed-dst)
(return-from test-copy-bashing nil))))))))
+;; Too slow for the interpreter
+#+#.(cl:if (cl:eq sb-ext:*evaluator-mode* :compile) '(and) '(or))
(loop for i = 1 then (* i 2) do
- ;; the bare '32' here is fairly arbitrary; '8' provides a good
- ;; range of lengths over which to fill and copy, which should tease
- ;; out most errors in the code (if any exist). (It also makes this
- ;; part of the test suite finish reasonably quickly.)
- (assert (test-fill-bashing i 32 8))
- (assert (test-copy-bashing i 32 8))
+ ;; the bare '13' here is fairly arbitrary, except that it's been
+ ;; reduced from '32', which made the tests take aeons; '8' provides
+ ;; a good range of lengths over which to fill and copy, which
+ ;; should tease out most errors in the code (if any exist). (It
+ ;; also makes this part of the test suite finish reasonably
+ ;; quickly.)
+ (assert (time (test-fill-bashing i 13 8)))
+ (assert (time (test-copy-bashing i 13 8)))
until (= i sb-vm:n-word-bits))
+
+(defun test-inlined-bashing (bitsize)
+ ;; We have to compile things separately for each bitsize so the
+ ;; compiler will work out the array type and trigger the REPLACE
+ ;; transform.
+ (let ((lambda-form
+ `(lambda ()
+ (let* ((n-elements-per-word ,(truncate sb-vm:n-word-bits bitsize))
+ (size (* 3 n-elements-per-word))
+ (standard-dst (make-array size :element-type '(unsigned-byte ,bitsize)))
+ (bashed-dst (make-array size :element-type '(unsigned-byte ,bitsize)))
+ (source (make-array size :element-type '(unsigned-byte ,bitsize))))
+ (declare (type (simple-array (unsigned-byte ,bitsize) (*))
+ source standard-dst bashed-dst))
+ (do ((i 0 (1+ i))
+ (offset n-elements-per-word (1+ offset)))
+ ((>= offset (* 2 n-elements-per-word)) t)
+ (dolist (c (fill-bytes-for-testing ,bitsize))
+ (fill-with-known-value (mod (lognot c) (ash 1 ,bitsize)) size
+ source standard-dst bashed-dst)
+ ;; fill with test-data
+ (fill source c :start offset :end (+ offset n-elements-per-word))
+ ;; copy filled data to test vectors
+ ;;
+ ;; a) the slow way (which is actually fast, since this
+ ;; should be transformed into UB*-BASH-COPY)
+ (replace standard-dst source
+ :start1 (- offset n-elements-per-word i)
+ :start2 (- offset n-elements-per-word i)
+ :end1 offset :end2 offset)
+ ;; b) the fast way--we fold the
+ ;; :START{1,2} arguments above ourselves
+ ;; to trigger the REPLACE transform
+ (replace bashed-dst source
+ :start1 0 :start2 0 :end1 offset :end2 offset)
+ ;; check for errors
+ (when (or (mismatch standard-dst bashed-dst)
+ ;; trigger COPY-SEQ transform
+ (mismatch (copy-seq standard-dst) bashed-dst)
+ ;; trigger SUBSEQ transform
+ (mismatch (subseq standard-dst (- offset n-elements-per-word i))
+ bashed-dst))
+ (format t "Test with target-offset ~A, source-offset ~A, fill ~A, and length ~A failed.~%"
+ 0 0 c offset)
+ (format t "Mismatch:~% correct ~A~% actual ~A~%"
+ standard-dst
+ bashed-dst)
+ (return-from nil nil))))))))
+ (funcall (compile nil lambda-form))))
+
+#+#.(cl:if (cl:eq sb-ext:*evaluator-mode* :compile) '(and) '(or))
+(loop for i = 1 then (* i 2) do
+ (assert (test-inlined-bashing i))
+ until (= i sb-vm:n-word-bits))
+\f
+;;; tests from the Sacla test suite via Eric Marsden, 2007-05-07
+(remove-duplicates (vector 1 2 2 1) :test-not (lambda (a b) (not (= a b))))
+
+(delete-duplicates (vector #\a #\b #\c #\a)
+ :test-not (lambda (a b) (not (char-equal a b))))
+
+;;; FILL on lists
+(let ((l (list 1 2 3)))
+ (assert (eq l (fill l 0 :start 1 :end 2)))
+ (assert (equal l '(1 0 3)))
+ (assert (eq l (fill l 'x :start 2 :end 3)))
+ (assert (equal l '(1 0 x)))
+ (assert (eq l (fill l 'y :start 1)))
+ (assert (equal l '(1 y y)))
+ (assert (eq l (fill l 'z :end 2)))
+ (assert (equal l '(z z y)))
+ (assert (eq l (fill l 1)))
+ (assert (equal l '(1 1 1)))
+ (assert (raises-error? (fill l 0 :start 4)))
+ (assert (raises-error? (fill l 0 :end 4)))
+ (assert (raises-error? (fill l 0 :start 2 :end 1))))
+
+;;; Both :TEST and :TEST-NOT provided
+(with-test (:name :test-and-test-not-to-adjoin)
+ (let* ((wc 0)
+ (fun
+ (handler-bind (((and warning (not style-warning))
+ (lambda (w) (incf wc))))
+ (compile nil `(lambda (item test test-not) (adjoin item '(1 2 3 :foo)
+ :test test
+ :test-not test-not))))))
+ (assert (= 1 wc))
+ (assert (eq :error
+ (handler-case
+ (funcall fun 1 #'eql (complement #'eql))
+ (error ()
+ :error))))))
\f
+;;; tests of deftype types equivalent to STRING or SIMPLE-STRING
+(deftype %string () 'string)
+(deftype %simple-string () 'simple-string)
+(deftype string-3 () '(string 3))
+(deftype simple-string-3 () '(simple-string 3))
+
+(with-test (:name :user-defined-string-types-map-etc)
+ (dolist (type '(%string %simple-string string-3 simple-string-3))
+ (assert (string= "foo" (coerce '(#\f #\o #\o) type)))
+ (assert (string= "foo" (map type 'identity #(#\f #\o #\o))))
+ (assert (string= "foo" (merge type '(#\o) '(#\f #\o) 'char<)))
+ (assert (string= "foo" (concatenate type '(#\f) "oo")))
+ (assert (string= "ooo" (make-sequence type 3 :initial-element #\o)))))
+(with-test (:name :user-defined-string-types-map-etc-error)
+ (dolist (type '(string-3 simple-string-3))
+ (assert (raises-error? (coerce '(#\q #\u #\u #\x) type)))
+ (assert (raises-error? (map type 'identity #(#\q #\u #\u #\x))))
+ (assert (raises-error? (merge type '(#\q #\x) "uu" 'char<)))
+ (assert (raises-error? (concatenate type "qu" '(#\u #\x))))
+ (assert (raises-error? (make-sequence type 4 :initial-element #\u)))))
+
+(defun test-bit-position (size set start end from-end res)
+ (let ((v (make-array size :element-type 'bit :initial-element 0)))
+ (dolist (i set)
+ (setf (bit v i) 1))
+ (dolist (f (list (compile nil
+ `(lambda (b v s e fe)
+ (position b (the bit-vector v) :start s :end e :from-end fe)))
+ (compile nil
+ `(lambda (b v s e fe)
+ (assert (eql b 1))
+ (position 1 (the bit-vector v) :start s :end e :from-end fe)))
+ (compile nil
+ `(lambda (b v s e fe)
+ (position b (the vector v) :start s :end e :from-end fe)))))
+ (let ((got (funcall f 1 v start end from-end)))
+ (unless (eql res got)
+ (cerror "Continue" "POSITION 1, Wanted ~S, got ~S.~% size = ~S, set = ~S, from-end = ~S"
+ res got
+ size set from-end)))))
+ (let ((v (make-array size :element-type 'bit :initial-element 1)))
+ (dolist (i set)
+ (setf (bit v i) 0))
+ (dolist (f (list (compile nil
+ `(lambda (b v s e fe)
+ (position b (the bit-vector v) :start s :end e :from-end fe)))
+ (compile nil
+ `(lambda (b v s e fe)
+ (assert (eql b 0))
+ (position 0 (the bit-vector v) :start s :end e :from-end fe)))
+ (compile nil
+ `(lambda (b v s e fe)
+ (position b (the vector v) :start s :end e :from-end fe)))))
+ (let ((got (funcall f 0 v start end from-end)))
+ (unless (eql res got)
+ (cerror "Continue" "POSITION 0, Wanted ~S, got ~S.~% size = ~S, set = ~S, from-end = ~S"
+ res got
+ size set from-end))))))
+
+(defun random-test-bit-position (n)
+ (loop repeat n
+ do (let* ((vector (make-array (+ 2 (random 5000)) :element-type 'bit))
+ (offset (random (1- (length vector))))
+ (size (1+ (random (- (length vector) offset))))
+ (disp (make-array size :element-type 'bit :displaced-to vector
+ :displaced-index-offset offset)))
+ (assert (plusp size))
+ (loop repeat 10
+ do (setf (bit vector (random (length vector))) 1))
+ (flet ((test (orig)
+ (declare (bit-vector orig))
+ (let ((copy (coerce orig 'simple-vector))
+ (p0 (random (length orig)))
+ (p1 (1+ (random (length orig)))))
+ (multiple-value-bind (s e)
+ (if (> p1 p0)
+ (values p0 p1)
+ (values p1 p0))
+ (assert (eql (position 1 copy :start s :end e)
+ (position 1 orig :start s :end e)))
+ (assert (eql (position 1 copy :start s :end e :from-end t)
+ (position 1 orig :start s :end e :from-end t)))))))
+ (test vector)
+ (test disp)))))
+
+(with-test (:name :bit-position)
+ (test-bit-position 0 (list) 0 0 nil nil)
+ (test-bit-position 0 (list) 0 0 t nil)
+ (test-bit-position 1 (list 0) 0 0 nil nil)
+ (test-bit-position 1 (list 0) 0 0 t nil)
+ (test-bit-position 1 (list 0) 0 1 nil 0)
+ (test-bit-position 1 (list 0) 0 1 t 0)
+ (test-bit-position 10 (list 0 1) 0 1 nil 0)
+ (test-bit-position 10 (list 0 1) 1 1 nil nil)
+ (test-bit-position 10 (list 0 1) 0 1 t 0)
+ (test-bit-position 10 (list 0 1) 1 1 t nil)
+ (test-bit-position 10 (list 0 3) 1 4 nil 3)
+ (test-bit-position 10 (list 0 3) 1 4 t 3)
+ (test-bit-position 10 (list 0 3 6) 1 10 nil 3)
+ (test-bit-position 10 (list 0 3 6) 1 10 t 6)
+ (test-bit-position 1000 (list 128 700) 20 500 nil 128)
+ (test-bit-position 1000 (list 128 700) 20 500 t 128)
+ (test-bit-position 1000 (list 423 762) 200 800 nil 423)
+ (test-bit-position 1000 (list 423 762) 200 800 t 762)
+ (test-bit-position 1000 (list 298 299) 100 400 nil 298)
+ (test-bit-position 1000 (list 298 299) 100 400 t 299))
+
+(with-test (:name (:bit-position :random-test))
+ (random-test-bit-position 10000))
+
;;; success