X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;ds=sidebyside;f=src%2Fcompiler.lisp;h=6605ddebfe67f526cfc744a532980da8d27a195c;hb=fdff53251d15ceeb567dc7faa06736de0e8c5ed2;hp=a81de2f46705c9690f672bc32076b55d3585ad8e;hpb=81acf0d435f13d0850a0fa48b7502e8b3ea8f2d0;p=jscl.git

diff --git a/src/compiler.lisp b/src/compiler.lisp
index a81de2f..6605dde 100644
--- a/src/compiler.lisp
+++ b/src/compiler.lisp
@@ -18,6 +18,8 @@
 
 ;;;; Compiler
 
+(/debug "loading compiler.lisp!")
+
 ;;; Translate the Lisp code to Javascript. It will compile the special
 ;;; forms. Some primitive functions are compiled as special forms
 ;;; too. The respective real functions are defined in the target (see
@@ -48,7 +50,7 @@
 ;;; Wrap X with a Javascript code to convert the result from
 ;;; Javascript generalized booleans to T or NIL.
 (defun js!bool (x)
-  `(code "(" ,x "?" ,(ls-compile t) ": " ,(ls-compile nil) ")"))
+  `(if ,x ,(ls-compile t) ,(ls-compile nil)))
 
 ;;; Concatenate the arguments and wrap them with a self-calling
 ;;; Javascript anonymous function. It is used to make some Javascript
@@ -56,7 +58,11 @@
 ;;; It could be defined as function, but we could do some
 ;;; preprocessing in the future.
 (defmacro js!selfcall (&body body)
-  ``(code "(function(){" (code ,,@body) "})()"))
+  ``(call (function nil (code ,,@body))))
+
+(defmacro js!selfcall* (&body body)
+  ``(call (function nil ,,@body)))
+
 
 ;;; Like CODE, but prefix each line with four spaces. Two versions
 ;;; of this function are available, because the Ecmalisp version is
@@ -111,7 +117,7 @@
 
 (defun gvarname (symbol)
   (declare (ignore symbol))
-  `(code "v" ,(incf *variable-counter*)))
+  (code "v" (incf *variable-counter*)))
 
 (defun translate-variable (symbol)
   (awhen (lookup-in-lexenv symbol *environment* 'variable)
@@ -188,10 +194,9 @@
          *compilations*))
 
 (define-compilation if (condition true &optional false)
-  `(code "(" ,(ls-compile condition) " !== " ,(ls-compile nil)
-         " ? " ,(ls-compile true *multiple-value-p*)
-         " : " ,(ls-compile false *multiple-value-p*)
-         ")"))
+  `(if (!== ,(ls-compile condition) ,(ls-compile nil))
+       ,(ls-compile true *multiple-value-p*)
+       ,(ls-compile false *multiple-value-p*)))
 
 (defvar *ll-keywords* '(&optional &rest &key))
 
@@ -244,7 +249,7 @@
 (defun lambda-name/docstring-wrapper (name docstring &rest code)
   (if (or name docstring)
       (js!selfcall
-        "var func = " `(code ,code) ";" 
+        "var func = " `(code ,@code) ";"
         (when name
           `(code "func.fname = " ,(js-escape-string name) ";"))
         (when docstring
@@ -327,43 +332,40 @@
       ,(flet ((parse-keyword (keyarg)
                ;; ((keyword-name var) init-form)
                `(code "for (i=" ,(+ n-required-arguments n-optional-arguments)
-                      "; i<nargs; i+=2){" 
-                      (code
-                       "if (arguments[i+2] === " ,(ls-compile (caar keyarg)) "){" 
-                       (code ,(translate-variable (cadr (car keyarg)))
-                             " = arguments[i+3];"
-                             
-                             ,(let ((svar (third keyarg)))
-                                (when svar
-                                  `(code ,(translate-variable svar) " = " ,(ls-compile t) ";" )))
-                             "break;" )
-                       "}" )
-                      "}" 
+                      "; i<nargs; i+=2){"
+                      "if (arguments[i+2] === " ,(ls-compile (caar keyarg)) "){"
+                      ,(translate-variable (cadr (car keyarg)))
+                      " = arguments[i+3];"
+                      ,(let ((svar (third keyarg)))
+                            (when svar
+                              `(code ,(translate-variable svar) " = " ,(ls-compile t) ";" )))
+                      "break;"
+                      "}"
+                      "}"
                       ;; Default value
-                      "if (i == nargs){" 
-                      (code ,(translate-variable (cadr (car keyarg)))
-                            " = "
-                            ,(ls-compile (cadr keyarg))
-                            ";" )
-                      "}" )))
+                      "if (i == nargs){"
+                      ,(translate-variable (cadr (car keyarg)))
+                      " = "
+                      ,(ls-compile (cadr keyarg))
+                      ";"
+                      "}")))
         (when keyword-arguments
-          `(code "var i;" 
+          `(code "var i;"
                  ,@(mapcar #'parse-keyword keyword-arguments))))
       ;; Check for unknown keywords
       ,(when keyword-arguments
-        `(code "var start = " ,(+ n-required-arguments n-optional-arguments) ";" 
-               "if ((nargs - start) % 2 == 1){" 
-               (code "throw 'Odd number of keyword arguments';" )
-               "}" 
-               "for (i = start; i<nargs; i+=2){" 
-               (code "if ("
-                     ,(interleave (mapcar (lambda (x)
-                                            `(code "arguments[i+2] !== " ,(ls-compile (caar x))))
-                                          keyword-arguments)
-                                  " && ")
-                     ")" 
-                     (code
-                      "throw 'Unknown keyword argument ' + xstring(arguments[i+2].name);" ))
+        `(code "var start = " ,(+ n-required-arguments n-optional-arguments) ";"
+               "if ((nargs - start) % 2 == 1){"
+               "throw 'Odd number of keyword arguments';" 
+               "}"
+               "for (i = start; i<nargs; i+=2){"
+               "if ("
+               ,@(interleave (mapcar (lambda (x)
+                                       `(code "arguments[i+2] !== " ,(ls-compile (caar x))))
+                                     keyword-arguments)
+                            " && ")
+               ")"
+               "throw 'Unknown keyword argument ' + xstring(arguments[i+2].name);" 
                "}" )))))
 
 (defun parse-lambda-list (ll)
@@ -423,7 +425,7 @@
                          (mapcar #'translate-variable
                                  (append required-arguments optional-arguments)))
                   ",")
-           "){" 
+           "){"
            ;; Check number of arguments
            ,(lambda-check-argument-count n-required-arguments
                                          n-optional-arguments
@@ -435,7 +437,7 @@
                  (if block
                      (ls-compile-block `((block ,block ,@body)) t)
                      (ls-compile-block body t)))
-          "})"))))))
+           "})"))))))
 
 
 (defun setq-pair (var val)
@@ -495,7 +497,7 @@
 (defvar *literal-counter* 0)
 
 (defun genlit ()
-  `(code "l" ,(incf *literal-counter*)))
+  (code "l" (incf *literal-counter*)))
 
 (defun dump-symbol (symbol)
   #-jscl
@@ -513,7 +515,7 @@
   (let ((head (butlast cons))
         (tail (last cons)))
     `(code "QIList("
-           ,@(interleave (mapcar (lambda (x) (literal x t)) head) ",")
+           ,@(interleave (mapcar (lambda (x) (literal x t)) head) "," t)
            ,(literal (car tail) t)
            ","
            ,(literal (cdr tail) t)
@@ -560,10 +562,10 @@
 
 (define-compilation %while (pred &rest body)
   (js!selfcall
-    "while(" (ls-compile pred) " !== " (ls-compile nil) "){" 
+    "while(" (ls-compile pred) " !== " (ls-compile nil) "){" *newline*
     `(code ,(ls-compile-block body))
-    "}"
-    "return " (ls-compile nil) ";" ))
+    "}" *newline*
+    "return " (ls-compile nil) ";" *newline*))
 
 (define-compilation function (x)
   (cond
@@ -608,9 +610,9 @@
                          'function)))
     `(code "(function("
            ,@(interleave (mapcar #'translate-function fnames) ",")
-           "){" 
+           "){"
            ,(ls-compile-block body t)
-           "})(" ,@cfuncs ")")))
+           "})(" ,@(interleave cfuncs ",") ")")))
 
 (define-compilation labels (definitions &rest body)
   (let* ((fnames (mapcar #'car definitions))
@@ -675,19 +677,19 @@
   (when (null bindings)
     (return-from let-binding-wrapper body))
   `(code
-    "try {" 
-    (code "var tmp;" 
+    "try {"
+    (code "var tmp;"
           ,@(mapcar
              (lambda (b)
                (let ((s (ls-compile `(quote ,(car b)))))
-                 `(code "tmp = " ,s ".value;" 
-                        ,s ".value = " ,(cdr b) ";" 
+                 `(code "tmp = " ,s ".value;"
+                        ,s ".value = " ,(cdr b) ";"
                         ,(cdr b) " = tmp;" )))
              bindings)
           ,body
           )
-    "}" 
-    "finally {"  
+    "}"
+    "finally {"
     (code
      ,@(mapcar (lambda (b)
                  (let ((s (ls-compile `(quote ,(car b)))))
@@ -711,7 +713,7 @@
                             (translate-variable x)))
                       variables)
               ",")
-           "){" 
+           "){"
            ,(let ((body (ls-compile-block body t t)))
              `(code ,(let-binding-wrapper dynamic-bindings body)))
            "})(" ,@(interleave cvalues ",") ")")))
@@ -738,15 +740,15 @@
   (let ((store (mapcar (lambda (s) (cons s (gvarname s)))
                        (remove-if-not #'special-variable-p symbols))))
     `(code
-      "try {" 
+      "try {"
       (code
        ,@(mapcar (lambda (b)
                    (let ((s (ls-compile `(quote ,(car b)))))
                      `(code "var " ,(cdr b) " = " ,s ".value;" )))
                  store)
        ,body)
-      "}" 
-      "finally {" 
+      "}"
+      "finally {"
       (code
        ,@(mapcar (lambda (b)
                    (let ((s (ls-compile `(quote ,(car b)))))
@@ -779,18 +781,18 @@
            (cbody (ls-compile-block body t)))
       (if (member 'used (binding-declarations b))
           (js!selfcall
-            "try {" 
-            "var " idvar " = [];" 
+            "try {"
+            "var " idvar " = [];"
             `(code ,cbody)
-            "}" 
-            "catch (cf){" 
-            "    if (cf.type == 'block' && cf.id == " idvar ")" 
+            "}"
+            "catch (cf){"
+            "    if (cf.type == 'block' && cf.id == " idvar ")"
             (if *multiple-value-p*
                 "        return values.apply(this, forcemv(cf.values));"
                 "        return cf.values;")
-            
-            "    else" 
-            "        throw cf;" 
+
+            "    else"
+            "        throw cf;"
             "}" )
           (js!selfcall cbody)))))
 
@@ -815,23 +817,23 @@
 
 (define-compilation catch (id &rest body)
   (js!selfcall
-    "var id = " (ls-compile id) ";" 
-    "try {" 
-    `(code ,(ls-compile-block body t)) 
-    "}" 
-    "catch (cf){" 
-    "    if (cf.type == 'catch' && cf.id == id)" 
+    "var id = " (ls-compile id) ";"
+    "try {"
+    `(code ,(ls-compile-block body t))
+    "}"
+    "catch (cf){"
+    "    if (cf.type == 'catch' && cf.id == id)"
     (if *multiple-value-p*
         "        return values.apply(this, forcemv(cf.values));"
         "        return pv.apply(this, forcemv(cf.values));")
-    
-    "    else" 
-    "        throw cf;" 
+
+    "    else"
+    "        throw cf;"
     "}" ))
 
 (define-compilation throw (id value)
   (js!selfcall
-    "var values = mv;" 
+    "var values = mv;"
     "throw ({"
     "type: 'catch', "
     "id: " (ls-compile id) ", "
@@ -869,31 +871,31 @@
         (setq initag (second (binding-value b))))
       (js!selfcall
         ;; TAGBODY branch to take
-        "var " branch " = " initag ";" 
-        "var " tbidx " = [];" 
-        "tbloop:" 
-        "while (true) {" 
-        `(code "try {" 
+        "var " branch " = " initag ";"
+        "var " tbidx " = [];"
+        "tbloop:"
+        "while (true) {"
+        `(code "try {"
                ,(let ((content nil))
-                  `(code "switch(" ,branch "){" 
-                        "case " ,initag ":" 
+                  `(code "switch(" ,branch "){"
+                        "case " ,initag ":"
                         ,@(dolist (form (cdr body) (reverse content))
                           (push (if (not (go-tag-p form))
                                     `(code ,(ls-compile form) ";" )
                                     (let ((b (lookup-in-lexenv form *environment* 'gotag)))
                                       `(code "case " ,(second (binding-value b)) ":" )))
                                 content))
-                           "default:" 
-                           "    break tbloop;" 
+                           "default:"
+                           "    break tbloop;"
                            "}" ))
-               "}" 
-               "catch (jump) {" 
-               "    if (jump.type == 'tagbody' && jump.id == " ,tbidx ")" 
-               "        " ,branch " = jump.label;" 
-               "    else" 
-               "        throw(jump);" 
+               "}"
+               "catch (jump) {"
+               "    if (jump.type == 'tagbody' && jump.id == " ,tbidx ")"
+               "        " ,branch " = jump.label;"
+               "    else"
+               "        throw(jump);"
                "}" )
-        "}" 
+        "}"
         "return " (ls-compile nil) ";" ))))
 
 (define-compilation go (label)
@@ -913,36 +915,36 @@
 
 (define-compilation unwind-protect (form &rest clean-up)
   (js!selfcall
-    "var ret = " (ls-compile nil) ";" 
-    "try {" 
+    "var ret = " (ls-compile nil) ";"
+    "try {"
     `(code "ret = " ,(ls-compile form) ";" )
-    "} finally {" 
+    "} finally {"
     `(code ,(ls-compile-block clean-up))
-    "}" 
+    "}"
     "return ret;" ))
 
 (define-compilation multiple-value-call (func-form &rest forms)
   (js!selfcall
-    "var func = " (ls-compile func-form) ";" 
-    "var args = [" (if *multiple-value-p* "values" "pv") ", 0];" 
+    "var func = " (ls-compile func-form) ";"
+    "var args = [" (if *multiple-value-p* "values" "pv") ", 0];"
     "return "
     (js!selfcall
-      "var values = mv;" 
-      "var vs;" 
+      "var values = mv;"
+      "var vs;"
       `(code
         ,@(mapcar (lambda (form)
-                    `(code "vs = " ,(ls-compile form t) ";" 
-                           "if (typeof vs === 'object' && 'multiple-value' in vs)" 
-                           (code "args = args.concat(vs);" )
-                           "else" 
+                    `(code "vs = " ,(ls-compile form t) ";"
+                           "if (typeof vs === 'object' && 'multiple-value' in vs)"
+                           (code " args = args.concat(vs);" )
+                           " else "
                            (code "args.push(vs);" )))
                   forms))
-      "args[1] = args.length-2;" 
+      "args[1] = args.length-2;"
       "return func.apply(window, args);" ) ";" ))
 
 (define-compilation multiple-value-prog1 (first-form &rest forms)
   (js!selfcall
-    "var args = " (ls-compile first-form *multiple-value-p*) ";" 
+    "var args = " (ls-compile first-form *multiple-value-p*) ";"
     (ls-compile-block forms)
     "return args;" ))
 
@@ -977,7 +979,7 @@
      ,@(mapcar (lambda (decl)
                  `(let ((name ,(first decl))
                         (type ,(second decl)))
-                    `(code "if (typeof " ,name " != '" ,type "')" 
+                    `(code "if (typeof " ,name " != '" ,type "')"
                            (code "throw 'The value ' + "
                                  ,name
                                  " + ' is not a type "
@@ -1005,9 +1007,8 @@
         ((numberp x) (push (integer-to-string x) fargs))
         (t (let ((v (code "x" (incf counter))))
              (push v fargs)
-             (push `(code "var " ,v " = " ,(ls-compile x) ";" 
-                          "if (typeof " v " !== 'number') throw 'Not a number!';"
-                          )
+             (push `(code "var " ,v " = " ,(ls-compile x) ";"
+                          "if (typeof " ,v " !== 'number') throw 'Not a number!';")
                    prelude)))))
     (js!selfcall
       `(code ,@(reverse prelude))
@@ -1095,24 +1096,24 @@
     "make_lisp_string(x.toString())"))
 
 (define-builtin cons (x y)
-  (code "({car: " x ", cdr: " y "})"))
+  `(code "({car: " ,x ", cdr: " ,y "})"))
 
 (define-builtin consp (x)
   (js!bool
    (js!selfcall
-     "var tmp = " x ";" 
+     "var tmp = " x ";"
      "return (typeof tmp == 'object' && 'car' in tmp);" )))
 
 (define-builtin car (x)
   (js!selfcall
-    "var tmp = " x ";" 
+    "var tmp = " x ";"
     "return tmp === " (ls-compile nil)
     "? " (ls-compile nil)
     ": tmp.car;" ))
 
 (define-builtin cdr (x)
   (js!selfcall
-    "var tmp = " x ";" 
+    "var tmp = " x ";"
     "return tmp === " (ls-compile nil) "? "
     (ls-compile nil)
     ": tmp.cdr;" ))
@@ -1148,16 +1149,16 @@
 
 (define-builtin symbol-value (x)
   (js!selfcall
-    "var symbol = " x ";" 
-    "var value = symbol.value;" 
-    "if (value === undefined) throw \"Variable `\" + xstring(symbol.name) + \"' is unbound.\";" 
+    "var symbol = " x ";"
+    "var value = symbol.value;"
+    "if (value === undefined) throw \"Variable `\" + xstring(symbol.name) + \"' is unbound.\";"
     "return value;" ))
 
 (define-builtin symbol-function (x)
   (js!selfcall
-    "var symbol = " x ";" 
-    "var func = symbol.fvalue;" 
-    "if (func === undefined) throw \"Function `\" + xstring(symbol.name) + \"' is undefined.\";" 
+    "var symbol = " x ";"
+    "var func = symbol.fvalue;"
+    "if (func === undefined) throw \"Function `\" + xstring(symbol.name) + \"' is undefined.\";"
     "return func;" ))
 
 (define-builtin symbol-plist (x)
@@ -1180,7 +1181,7 @@
 (define-builtin characterp (x)
   (js!bool
    (js!selfcall
-     "var x = " x ";" 
+     "var x = " x ";"
      "return (typeof(" x ") == \"string\") && (x.length == 1 || x.length == 2);")))
 
 (define-builtin char-upcase (x)
@@ -1192,12 +1193,12 @@
 (define-builtin stringp (x)
   (js!bool
    (js!selfcall
-     "var x = " x ";" 
+     "var x = " x ";"
      "return typeof(x) == 'object' && 'length' in x && x.stringp == 1;")))
 
 (define-raw-builtin funcall (func &rest args)
   (js!selfcall
-    "var f = " (ls-compile func) ";" 
+    "var f = " (ls-compile func) ";"
     "return (typeof f === 'function'? f: f.fvalue)("
     `(code
      ,@(interleave (list* (if *multiple-value-p* "values" "pv")
@@ -1212,25 +1213,25 @@
       (let ((args (butlast args))
             (last (car (last args))))
         (js!selfcall
-          "var f = " (ls-compile func) ";" 
+          "var f = " (ls-compile func) ";"
           "var args = [" `(code
                            ,@(interleave (list* (if *multiple-value-p* "values" "pv")
                                                 (integer-to-string (length args))
                                                 (mapcar #'ls-compile args))
                                          ", "))
-          "];" 
-          "var tail = (" (ls-compile last) ");" 
-          "while (tail != " (ls-compile nil) "){" 
-          "    args.push(tail.car);" 
-          "    args[1] += 1;" 
-          "    tail = tail.cdr;" 
-          "}" 
+          "];"
+          "var tail = (" (ls-compile last) ");"
+          "while (tail != " (ls-compile nil) "){"
+          "    args.push(tail.car);"
+          "    args[1] += 1;"
+          "    tail = tail.cdr;"
+          "}"
           "return (typeof f === 'function'? f : f.fvalue).apply(this, args);" ))))
 
 (define-builtin js-eval (string)
   (if *multiple-value-p*
       (js!selfcall
-        "var v = globalEval(xstring(" string "));" 
+        "var v = globalEval(xstring(" string "));"
         "return values.apply(this, forcemv(v));" )
       `(code "globalEval(xstring(" ,string "))")))
 
@@ -1243,6 +1244,9 @@
 (define-builtin %write-string (x)
   `(code "lisp.write(" ,x ")"))
 
+(define-builtin /debug (x)
+  `(code "console.log(xstring(" ,x "))"))
+
 
 ;;; Storage vectors. They are used to implement arrays and (in the
 ;;; future) structures.
@@ -1250,13 +1254,13 @@
 (define-builtin storage-vector-p (x)
   (js!bool
    (js!selfcall
-     "var x = " x ";" 
+     "var x = " x ";"
      "return typeof x === 'object' && 'length' in x;")))
 
 (define-builtin make-storage-vector (n)
   (js!selfcall
-    "var r = [];" 
-    "r.length = " n ";" 
+    "var r = [];"
+    "r.length = " n ";"
     "return r;" ))
 
 (define-builtin storage-vector-size (x)
@@ -1267,23 +1271,23 @@
 
 (define-builtin storage-vector-ref (vector n)
   (js!selfcall
-    "var x = " "(" vector ")[" n "];" 
-    "if (x === undefined) throw 'Out of range';" 
+    "var x = " "(" vector ")[" n "];"
+    "if (x === undefined) throw 'Out of range';"
     "return x;" ))
 
 (define-builtin storage-vector-set (vector n value)
   (js!selfcall
-    "var x = " vector ";" 
-    "var i = " n ";" 
-    "if (i < 0 || i >= x.length) throw 'Out of range';" 
+    "var x = " vector ";"
+    "var i = " n ";"
+    "if (i < 0 || i >= x.length) throw 'Out of range';"
     "return x[i] = " value ";" ))
 
 (define-builtin concatenate-storage-vector (sv1 sv2)
   (js!selfcall
-    "var sv1 = " sv1 ";" 
-    "var r = sv1.concat(" sv2 ");" 
-    "r.type = sv1.type;" 
-    "r.stringp = sv1.stringp;" 
+    "var sv1 = " sv1 ";"
+    "var r = sv1.concat(" sv2 ");"
+    "r.type = sv1.type;"
+    "r.stringp = sv1.stringp;"
     "return r;" ))
 
 (define-builtin get-internal-real-time ()
@@ -1306,10 +1310,10 @@
 
 (define-raw-builtin oget* (object key &rest keys)
   (js!selfcall
-    "var tmp = (" (ls-compile object) ")[xstring(" (ls-compile key) ")];" 
+    "var tmp = (" (ls-compile object) ")[xstring(" (ls-compile key) ")];"
     `(code
       ,@(mapcar (lambda (key)
-                  `(code "if (tmp === undefined) return " ,(ls-compile nil) ";" 
+                  `(code "if (tmp === undefined) return " ,(ls-compile nil) ";"
                          "tmp = tmp[xstring(" ,(ls-compile key) ")];" ))
                 keys))
     "return tmp === undefined? " (ls-compile nil) " : tmp;" ))
@@ -1317,36 +1321,36 @@
 (define-raw-builtin oset* (value object key &rest keys)
   (let ((keys (cons key keys)))
     (js!selfcall
-      "var obj = " (ls-compile object) ";" 
+      "var obj = " (ls-compile object) ";"
       `(code ,@(mapcar (lambda (key)
                          `(code "obj = obj[xstring(" ,(ls-compile key) ")];"
                                 "if (obj === undefined) throw 'Impossible to set Javascript property.';" ))
                        (butlast keys)))
-      "var tmp = obj[xstring(" (ls-compile (car (last keys))) ")] = " (ls-compile value) ";" 
+      "var tmp = obj[xstring(" (ls-compile (car (last keys))) ")] = " (ls-compile value) ";"
       "return tmp === undefined? " (ls-compile nil) " : tmp;" )))
 
 (define-raw-builtin oget (object key &rest keys)
-  `(code "js_to_lisp(" ,(ls-compile `(oget* ,object ,key ,@keys)) ")"))
+  `(call |js_to_lisp| ,(ls-compile `(oget* ,object ,key ,@keys))))
 
 (define-raw-builtin oset (value object key &rest keys)
   (ls-compile `(oset* (lisp-to-js ,value) ,object ,key ,@keys)))
 
 (define-builtin objectp (x)
-  (js!bool `(code "(typeof (" ,x ") === 'object')")))
+  (js!bool `(=== (typeof ,x) "object")))
 
-(define-builtin lisp-to-js (x) `(code "lisp_to_js(" ,x ")"))
-(define-builtin js-to-lisp (x) `(code "js_to_lisp(" ,x ")"))
+(define-builtin lisp-to-js (x) `(call |lisp_to_js| ,x))
+(define-builtin js-to-lisp (x) `(call |js_to_lisp| ,x))
 
 
 (define-builtin in (key object)
-  (js!bool `(code "(xstring(" ,key ") in (" ,object "))")))
+  (js!bool `(in (call |xstring| ,key) ,object)))
 
 (define-builtin map-for-in (function object)
   (js!selfcall
-   "var f = " function ";" 
-   "var g = (typeof f === 'function' ? f : f.fvalue);" 
-   "var o = " object ";" 
-   "for (var key in o){" 
+   "var f = " function ";"
+   "var g = (typeof f === 'function' ? f : f.fvalue);"
+   "var o = " object ";"
+   "for (var key in o){"
    `(code "g(" ,(if *multiple-value-p* "values" "pv") ", 1, o[key]);" )
    "}"
    " return " (ls-compile nil) ";" ))
@@ -1447,13 +1451,14 @@
         `(code ,(ls-compile-block (butlast sexps) nil decls-allowed-p)
                "return " ,(ls-compile (car (last sexps)) *multiple-value-p*) ";")
         `(code
-          ,@(mapcar #'ls-compile sexps)
-          ";"))))
+          ,@(interleave (mapcar #'ls-compile sexps) ";
+" *newline*)
+          ";" ,*newline*))))
 
-(defun ls-compile (sexp &optional multiple-value-p)
+(defun ls-compile* (sexp &optional multiple-value-p)
   (multiple-value-bind (sexp expandedp) (!macroexpand-1 sexp)
     (when expandedp
-      (return-from ls-compile (ls-compile sexp multiple-value-p)))
+      (return-from ls-compile* (ls-compile sexp multiple-value-p)))
     ;; The expression has been macroexpanded. Now compile it!
     (let ((*multiple-value-p* multiple-value-p))
       (cond
@@ -1487,6 +1492,9 @@
         (t
          (error "How should I compile `~S'?" sexp))))))
 
+(defun ls-compile (sexp &optional multiple-value-p)
+  `(code "(" ,(ls-compile* sexp multiple-value-p) ")"))
+
 
 (defvar *compile-print-toplevels* nil)
 
@@ -1495,20 +1503,27 @@
                (min width (length string)))))
     (subseq string 0 n)))
 
-(defun ls-compile-toplevel (sexp &optional multiple-value-p)
+(defun convert-toplevel (sexp &optional multiple-value-p)
   (let ((*toplevel-compilations* nil))
     (cond
-      ((and (consp sexp) (eq (car sexp) 'progn))
-       (let ((subs (mapcar (lambda (s)
-                             (ls-compile-toplevel s t))
-                           (cdr sexp))))
-         (join subs)))
+      ;; Non-empty toplevel progn
+      ((and (consp sexp)
+            (eq (car sexp) 'progn)
+            (cdr sexp))
+       `(progn
+          ,@(mapcar (lambda (s) (convert-toplevel s t))
+                    (cdr sexp))))
       (t
        (when *compile-print-toplevels*
          (let ((form-string (prin1-to-string sexp)))
            (format t "Compiling ~a..." (truncate-string form-string))))
        (let ((code (ls-compile sexp multiple-value-p)))
          `(code
-           ,@(interleave (get-toplevel-compilations) ";" t)
+           ,@(interleave (get-toplevel-compilations) ";
+" t)
            ,(when code
-             `(code ,code ";"))))))))
+                  `(code ,code ";"))))))))
+
+(defun ls-compile-toplevel (sexp &optional multiple-value-p)
+  (with-output-to-string (*standard-output*)
+    (js (convert-toplevel sexp multiple-value-p))))