X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fassembly%2Fx86%2Farith.lisp;h=54f94890a1fe3a57515b99157b581050d74d4a1e;hb=95591ed483dbb8c0846c129953acac1554f28809;hp=f3081f82456079e53c2394b1126fe2ec5354b536;hpb=d95f1e6476aa63695e018a7769a1ae9e002fca36;p=sbcl.git diff --git a/src/assembly/x86/arith.lisp b/src/assembly/x86/arith.lisp index f3081f8..54f9489 100644 --- a/src/assembly/x86/arith.lisp +++ b/src/assembly/x86/arith.lisp @@ -40,13 +40,12 @@ (inst ret) DO-STATIC-FUN - (inst pop eax) + ;; Same as: (inst enter (fixnumize 1)) (inst push ebp-tn) - (inst lea - ebp-tn - (make-ea :dword :base esp-tn :disp n-word-bytes)) - (inst sub esp-tn (fixnumize 2)) - (inst push eax) ; callers return addr + (inst mov ebp-tn esp-tn) + (inst sub esp-tn (fixnumize 1)) + (inst push (make-ea :dword :base ebp-tn + :disp (frame-byte-offset return-pc-save-offset))) (inst mov ecx (fixnumize 2)) ; arg count (inst jmp (make-ea :dword @@ -86,7 +85,7 @@ (move eax x) ; must use eax for 64-bit result (inst sar eax n-fixnum-tag-bits) ; remove *4 fixnum bias (inst imul y) ; result in edx:eax - (inst jmp :no okay) ; still fixnum + (inst jmp :no OKAY) ; still fixnum ;; zzz jrd changed edx to ebx in here, as edx isn't listed as a temp, above ;; pfw says that loses big -- edx is target for arg x and result res @@ -130,11 +129,11 @@ (inst test x fixnum-tag-mask) (inst jmp :z FIXNUM) - (inst pop eax) (inst push ebp-tn) - (inst lea ebp-tn (make-ea :dword :base esp-tn :disp n-word-bytes)) - (inst sub esp-tn (fixnumize 2)) - (inst push eax) + (inst mov ebp-tn esp-tn) + (inst sub esp-tn (fixnumize 1)) + (inst push (make-ea :dword :base ebp-tn + :disp (frame-byte-offset return-pc-save-offset))) (inst mov ecx (fixnumize 1)) ; arg count (inst jmp (make-ea :dword :disp (+ nil-value (static-fun-offset '%negate)))) @@ -171,12 +170,18 @@ (inst ret) DO-STATIC-FUN - (move ecx esp-tn) (inst sub esp-tn (fixnumize 3)) - (inst mov (make-ea :dword - :base ecx :disp (fixnumize -1)) + (inst mov (make-ea :dword :base esp-tn + :disp (frame-byte-offset + (+ sp->fp-offset + -3 + ocfp-save-offset))) ebp-tn) - (move ebp-tn ecx) + (inst lea ebp-tn (make-ea :dword :base esp-tn + :disp (frame-byte-offset + (+ sp->fp-offset + -3 + ocfp-save-offset)))) (inst mov ecx (fixnumize 2)) (inst call (make-ea :dword :disp (+ nil-value @@ -189,7 +194,7 @@ (:g `((inst cmp x (1+ nil-value))))) (inst ret)) #-sb-assembling - `(define-vop (,name) + `(define-vop (,name) (:translate ,translate) (:policy :safe) (:save-p t) @@ -230,7 +235,7 @@ (inst cmp ecx other-pointer-lowtag) (inst jmp :e DO-STATIC-FUN) - ;; Not both other pointers + ;; At least one fixnum (inst cmp x y) RET (inst ret) @@ -240,13 +245,18 @@ (inst cmp x y) (inst jmp :e RET) - (move ecx esp-tn) (inst sub esp-tn (fixnumize 3)) - (inst mov (make-ea :dword - :base ecx - :disp (fixnumize -1)) + (inst mov (make-ea :dword :base esp-tn + :disp (frame-byte-offset + (+ sp->fp-offset + -3 + ocfp-save-offset))) ebp-tn) - (move ebp-tn ecx) + (inst lea ebp-tn (make-ea :dword :base esp-tn + :disp (frame-byte-offset + (+ sp->fp-offset + -3 + ocfp-save-offset)))) (inst mov ecx (fixnumize 2)) (inst call (make-ea :dword :disp (+ nil-value (static-fun-offset 'eql)))) @@ -297,13 +307,18 @@ (inst ret) DO-STATIC-FUN - (move ecx esp-tn) (inst sub esp-tn (fixnumize 3)) - (inst mov (make-ea :dword - :base ecx - :disp (fixnumize -1)) + (inst mov (make-ea :dword :base esp-tn + :disp (frame-byte-offset + (+ sp->fp-offset + -3 + ocfp-save-offset))) ebp-tn) - (move ebp-tn ecx) + (inst lea ebp-tn (make-ea :dword :base esp-tn + :disp (frame-byte-offset + (+ sp->fp-offset + -3 + ocfp-save-offset)))) (inst mov ecx (fixnumize 2)) (inst call (make-ea :dword :disp (+ nil-value (static-fun-offset 'two-arg-=))))