X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcode%2Fdefmacro.lisp;h=92fbb48b1f08082410a79c04af52636cd42f2cf1;hb=54da325f13fb41669869aea688ae195426c0e231;hp=a77c741103a3490a7f206fbe797db0be3d14cc25;hpb=872175cd9cb5b4966a36d4bd92421cc407a0355b;p=sbcl.git diff --git a/src/code/defmacro.lisp b/src/code/defmacro.lisp index a77c741..92fbb48 100644 --- a/src/code/defmacro.lisp +++ b/src/code/defmacro.lisp @@ -12,57 +12,95 @@ (in-package "SB!IMPL") ;;; the guts of the DEFMACRO macro, pulled out into a separate -;;; function in order to make it easier to express the common +;;; function in order to make it easier to express the common ;;; bootstrap idiom ;;; CL:DEFMACRO SB!XC:DEFMACRO ;;; SB!XC:DEFMACRO CL:DEFMACRO -(eval-when (:compile-toplevel :load-toplevel :execute) +(eval-when (#-sb-xc :compile-toplevel :load-toplevel :execute) (defun %expander-for-defmacro (name lambda-list body) - (let ((whole (gensym "WHOLE-")) - (environment (gensym "ENV-"))) + (unless (symbolp name) + (error "The macro name ~S is not a symbol." name)) + ;; When we are building the cross-compiler, we could be in a host + ;; lisp which implements CL macros (e.g. CL:AND) as special + ;; operators (while still providing a macroexpansion for + ;; compliance): therefore can't use the host's SPECIAL-OPERATOR-P + ;; as a discriminator, but that's OK because the set of forms the + ;; cross-compiler compiles is tightly controlled. -- CSR, + ;; 2003-04-20 + #-sb-xc-host + (when (special-operator-p name) + (error "The special operator ~S can't be redefined as a macro." + name)) + (with-unique-names (whole environment) (multiple-value-bind (new-body local-decs doc) - (parse-defmacro lambda-list whole body name 'defmacro - :environment environment) - (let ((def `(lambda (,whole ,environment) - ,@local-decs - (block ,name - ,new-body)))) - `(sb!c::%defmacro ',name #',def ',lambda-list ,doc)))))) + (parse-defmacro lambda-list whole body name 'defmacro + :environment environment) + (let ((def `(#+sb-xc-host lambda + ;; Use a named-lambda rather than a lambda so that + ;; proper xref information can be stored. Use a + ;; list-based name, since otherwise the compiler + ;; will momentarily assume that it names a normal + ;; function, and report spurious warnings about + ;; redefinition a macro as a function, and then + ;; vice versa. + #-sb-xc-host named-lambda #-sb-xc-host (defmacro ,name) + (,whole ,environment) + ,@local-decs + ,new-body)) + (debug-name (sb!c::debug-name 'macro-function name))) + `(progn + (eval-when (:compile-toplevel :load-toplevel :execute) + (sb!c::%defmacro ',name #',def ',lambda-list ,doc ',debug-name + (sb!c:source-location))))))))) -;;; Ordinarily this definition of SB!C:%DEFMACRO as an ordinary -;;; function is not used: the parallel (but different) definition as -;;; an IR1 transform takes precedence. However, this definition is -;;; still useful in the target interpreter, and in the -;;; cross-compilation host. -(defun sb!c::%defmacro (name definition lambda-list doc) - (declare (ignore lambda-list)) - (sb!c::%%defmacro name definition doc)) - -;;; (called by SB!C::%DEFMACRO) -(eval-when (:compile-toplevel :load-toplevel :execute) - (defun sb!c::%%defmacro (name definition doc) - ;; old note (ca. 1985, maybe:-): "Eventually %%DEFMACRO should - ;; deal with clearing old compiler information for the functional - ;; value." - (clear-info :function :where-from name) - ;; FIXME: It would be nice to warn about DEFMACRO of an - ;; already-defined macro, but that's slightly hard to do because - ;; in common usage DEFMACRO is defined at compile time and then - ;; redefined at load time. We'd need to make a distinction between - ;; the defined-at-compile-time state and the defined-at-load-time - ;; state to make this work. (Trying to warn about duplicate - ;; DEFTYPEs runs into the same problem.) - #+nil (when (sb!xc:macro-function name) - (style-warn "redefining ~S in DEFMACRO" name)) - (setf (sb!xc:macro-function name) definition - (fdocumentation name 'function) doc) - name)) +(macrolet + ((def (times set-p) + `(eval-when (,@times) + (defun sb!c::%defmacro (name definition lambda-list doc debug-name + source-location) + ;; old note (ca. 1985, maybe:-): "Eventually %%DEFMACRO + ;; should deal with clearing old compiler information for + ;; the functional value." + ,@(unless set-p + '((declare (ignore lambda-list debug-name doc)))) + (let ((kind (info :function :kind name))) + ;; Check for special form before package locks. + (when (eq :special-form kind) + (error "The special operator ~S can't be redefined as a macro." + name)) + (with-single-package-locked-error (:symbol name "defining ~S as a macro") + (when (eq :function kind) + (style-warn + "~S is being redefined as a macro when it was ~ + previously ~(~A~) to be a function." + name (info :function :where-from name)) + (undefine-fun-name name)) + (clear-info :function :where-from name) + #-sb-xc-host + (when (fboundp name) + ;; Someday we could check for macro arguments + ;; being incompatibly redefined. Doing this right + ;; will involve finding the old macro lambda-list + ;; and comparing it with the new one. + (warn 'sb!kernel::redefinition-with-defmacro + :name name + :new-function definition + :new-location source-location)) + (setf (sb!xc:macro-function name) definition) + ,(when set-p + `(setf (%fun-doc definition) doc + (%fun-lambda-list definition) lambda-list + (%fun-name definition) debug-name)))) + name)))) + (progn + (def (:load-toplevel :execute) #-sb-xc-host t #+sb-xc-host nil) + (def (#-sb-xc :compile-toplevel) nil))) ;;; Parse the definition and make an expander function. The actual -;;; definition is done by %DEFMACRO which we expand into, and which is -;;; handled magically by an IR1 transform. After the compiler has -;;; gotten the information it wants out of macro definition, it -;;; compiles a call to %%DEFMACRO which happens at load time. +;;; definition is done by %DEFMACRO which we expand into. After the +;;; compiler has gotten the information it wants out of macro +;;; definition, it compiles a call to %DEFMACRO which happens at load +;;; time. (defmacro sb!xc:defmacro (name lambda-list &rest body) (%expander-for-defmacro name lambda-list body)) @@ -79,17 +117,22 @@ ;;; have any EVAL-WHEN or IR1 magic associated with it, so it only ;;; takes effect in :LOAD-TOPLEVEL or :EXECUTE situations. (def!macro defmacro-mundanely (name lambda-list &body body) - (let ((whole (gensym "WHOLE-")) - (environment (gensym "ENVIRONMENT-"))) - (multiple-value-bind (new-body local-decs doc) - (parse-defmacro lambda-list whole body name 'defmacro - :environment environment) - `(progn - (setf (sb!xc:macro-function ',name) - (lambda (,whole ,environment) - ,@local-decs - (block ,name - ,new-body))) - (setf (fdocumentation ',name 'macro) - ,doc) - ',name)))) + + ;; old way: + ;;(let ((whole (gensym "WHOLE-")) + ;; (environment (gensym "ENVIRONMENT-"))) + ;; (multiple-value-bind (new-body local-decs doc) + ;; (parse-defmacro lambda-list whole body name 'defmacro + ;; :environment environment) + ;; `(progn + ;; (setf (sb!xc:macro-function ',name) + ;; (lambda (,whole ,environment) + ;; ,@local-decs + ;; (block ,name + ;; ,new-body))) + ;; (setf (fdocumentation ',name 'macro) + ;; ,doc) + ;; ',name))) + + `(let () + (sb!xc:defmacro ,name ,lambda-list ,@body)))