X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcode%2Fhost-c-call.lisp;h=805023197fcc863f4d1aabb1e98c172e25f8d8db;hb=b0a7abdf2bd6f2d66fcce97196024cdb0e1a1886;hp=4ad089a32096f35219b4aec6005bef79adb97f36;hpb=d1355f6b79af346f05cf21c18637e269e0b499a1;p=sbcl.git

diff --git a/src/code/host-c-call.lisp b/src/code/host-c-call.lisp
index 4ad089a..8050231 100644
--- a/src/code/host-c-call.lisp
+++ b/src/code/host-c-call.lisp
@@ -14,9 +14,8 @@
 (define-alien-type-class (c-string :include pointer :include-args (to)))
 
 (define-alien-type-translator c-string ()
-  (make-alien-c-string-type :to
-			    (parse-alien-type 'char
-					      (sb!kernel::make-null-lexenv))))
+  (make-alien-c-string-type
+   :to (parse-alien-type 'char (sb!kernel:make-null-lexenv))))
 
 (define-alien-type-method (c-string :unparse) (type)
   (declare (ignore type))
@@ -24,7 +23,7 @@
 
 (define-alien-type-method (c-string :lisp-rep) (type)
   (declare (ignore type))
-  '(or simple-base-string null (alien (* char))))
+  '(or simple-string null (alien (* char))))
 
 (define-alien-type-method (c-string :naturalize-gen) (type alien)
   (declare (ignore type))
@@ -37,7 +36,33 @@
   `(etypecase ,value
      (null (int-sap 0))
      ((alien (* char)) (alien-sap ,value))
-     (simple-base-string (vector-sap ,value))))
+     ;; FIXME: GC safety alert! These SAPs are not safe, since the
+     ;; Lisp string can move. This is not hard to arrange, for example
+     ;; the following will fail very quickly on a SB-UNICODE build:
+     ;;
+     ;;   (setf (bytes-consed-between-gcs) 4096)
+     ;;   (define-alien-routine "strcmp" int (s1 c-string) (s2 c-string))
+     ;;
+     ;;   (loop
+     ;;     (let ((string "hello, world"))
+     ;;       (assert (zerop (strcmp string string)))))
+     ;;
+     ;; (This will appear to work on post-0.9.8.19 GENCGC, since
+     ;;  the GC no longer zeroes memory immediately after releasing
+     ;;  it after a minor GC. Either enabling the READ_PROTECT_FREE_PAGES
+     ;;  #define in gencgc.c or modifying the example so that a major
+     ;;  GC will occasionally be triggered would unmask the bug).
+     ;;
+     ;; The SIMPLE-BASE-STRING case will generally be very hard to
+     ;; trigger on GENCGC (even when threaded) thanks to GC
+     ;; conservativeness. It's mostly a problem on cheneygc.
+     ;; -- JES, 2006-01-13
+     (simple-base-string (vector-sap ,value))
+     ;; This case, on the other hand, will cause trouble on GENCGC, since
+     ;; we're taking the SAP of a immediately discarded temporary -> the
+     ;; conservativeness doesn't protect us.
+     ;; -- JES, 2006-01-13
+     (simple-string (vector-sap (coerce ,value 'simple-base-string)))))
 
 (/show0 "host-c-call.lisp 42")
 
@@ -66,6 +91,7 @@
   `(etypecase ,value
      (null (int-sap 0))
      ((alien (* char)) (alien-sap ,value))
+     ;; See the C-STRING :DEPORT-GEN comments for GC safety issues.
      (simple-base-string (vector-sap ,value))
      (simple-string (vector-sap (%deport-utf8-string ,value)))))