X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcode%2Firrat.lisp;h=68e5d9fbef81f4f8c1adfb89d1bb6f4aeff48a03;hb=b4831dc945c0754b3ba77881e67c8ea4d0a3d905;hp=20be275d02d5a67f8b04a7889d6ff29649698e30;hpb=e33fb894f991b2926d8f3bace9058e4c0b2c3a37;p=sbcl.git

diff --git a/src/code/irrat.lisp b/src/code/irrat.lisp
index 20be275..68e5d9f 100644
--- a/src/code/irrat.lisp
+++ b/src/code/irrat.lisp
@@ -14,8 +14,9 @@
 
 ;;;; miscellaneous constants, utility functions, and macros
 
-(defconstant pi 3.14159265358979323846264338327950288419716939937511L0)
-;(defconstant e 2.71828182845904523536028747135266249775724709369996L0)
+(defconstant pi
+  #!+long-float 3.14159265358979323846264338327950288419716939937511l0
+  #!-long-float 3.14159265358979323846264338327950288419716939937511d0)
 
 ;;; Make these INLINE, since the call to C is at least as compact as a
 ;;; Lisp call, and saves number consing to boot.
@@ -41,8 +42,9 @@
 ) ; EVAL-WHEN
 
 ;;;; stubs for the Unix math library
-
-;;; Please refer to the Unix man pages for details about these routines.
+;;;;
+;;;; Many of these are unnecessary on the X86 because they're built
+;;;; into the FPU.
 
 ;;; trigonometric
 #!-x86 (def-math-rtn "sin" 1)
@@ -268,18 +270,54 @@
 	     (* base power)
 	     (exp (* power (log base)))))))))
 
+;;; FIXME: Maybe rename this so that it's clearer that it only works
+;;; on integers?
+(defun log2 (x)
+  (declare (type integer x))
+  ;; CMUCL comment:
+  ;;
+  ;;   Write x = 2^n*f where 1/2 < f <= 1.  Then log2(x) = n +
+  ;;   log2(f).  So we grab the top few bits of x and scale that
+  ;;   appropriately, take the log of it and add it to n.
+  ;;
+  ;; Motivated by an attempt to get LOG to work better on bignums.
+  (let ((n (integer-length x)))
+    (if (< n sb!vm:double-float-digits)
+	(log (coerce x 'double-float) 2.0d0)
+	(let ((f (ldb (byte sb!vm:double-float-digits
+			    (- n sb!vm:double-float-digits))
+		      x)))
+	  (+ n (log (scale-float (coerce f 'double-float)
+				 (- sb!vm:double-float-digits))
+		    2.0d0))))))
+
 (defun log (number &optional (base nil base-p))
   #!+sb-doc
   "Return the logarithm of NUMBER in the base BASE, which defaults to e."
   (if base-p
-      (if (zerop base)
-	  base				; ANSI spec
-	  (/ (log number) (log base)))
+      (cond
+	((zerop base) 0f0) ; FIXME: type
+	((and (typep number '(integer (0) *))
+	      (typep base '(integer (0) *)))
+	 (coerce (/ (log2 number) (log2 base)) 'single-float))
+	(t (/ (log number) (log base))))
       (number-dispatch ((number number))
-	(((foreach fixnum bignum ratio))
+	(((foreach fixnum bignum))
+	 (if (minusp number)
+	     (complex (log (- number)) (coerce pi 'single-float))
+	     (coerce (/ (log2 number) (log (exp 1.0d0) 2.0d0)) 'single-float)))
+	((ratio)
 	 (if (minusp number)
 	     (complex (log (- number)) (coerce pi 'single-float))
-	     (coerce (%log (coerce number 'double-float)) 'single-float)))
+	     (let ((numerator (numerator number))
+		   (denominator (denominator number)))
+	       (if (= (integer-length numerator)
+		      (integer-length denominator))
+		   (coerce (%log1p (coerce (- number 1) 'double-float))
+			   'single-float)
+		   (coerce (/ (- (log2 numerator) (log2 denominator))
+			      (log (exp 1.0d0) 2.0d0))
+			   'single-float)))))
 	(((foreach single-float double-float))
 	 ;; Is (log -0) -infinity (libm.a) or -infinity + i*pi (Kahan)?
 	 ;; Since this doesn't seem to be an implementation issue
@@ -435,7 +473,7 @@
 			   (float-sign y pi))
 		       (float-sign y (/ pi 2)))
 		   (%atan2 y x))))
-	(number-dispatch ((y number) (x number))
+	(number-dispatch ((y real) (x real))
 	  ((double-float
 	    (foreach double-float single-float fixnum bignum ratio))
 	   (atan2 y (coerce x 'double-float)))
@@ -451,11 +489,11 @@
 	((complex)
 	 (complex-atan y)))))
 
-;; It seems that everyone has a C version of sinh, cosh, and
-;; tanh. Let's use these for reals because the original
-;; implementations based on the definitions lose big in round-off
-;; error. These bad definitions also mean that sin and cos for
-;; complex numbers can also lose big.
+;;; It seems that every target system has a C version of sinh, cosh,
+;;; and tanh. Let's use these for reals because the original
+;;; implementations based on the definitions lose big in round-off
+;;; error. These bad definitions also mean that sin and cos for
+;;; complex numbers can also lose big.
 
 (defun sinh (number)
   #!+sb-doc
@@ -595,7 +633,7 @@
 ;;;;
 ;;;; The original CMU CL code requested:
 ;;;;   Please send any bug reports, comments, or improvements to
-;;;;   Raymond Toy at toy@rtp.ericsson.se.
+;;;;   Raymond Toy at <email address deleted during 2002 spam avalanche>.
 
 ;;; FIXME: In SBCL, the floating point infinity constants like
 ;;; SB!EXT:DOUBLE-FLOAT-POSITIVE-INFINITY aren't available as
@@ -866,13 +904,18 @@
       ;; space 0 to get maybe-inline functions inlined
       (declare (optimize (speed 3) (space 0)))
     (cond ((> (abs x)
-	      #-(or linux hpux) #.(/ (asinh most-positive-double-float) 4d0)
-	      ;; This is more accurate under linux.
-	      #+(or linux hpux) #.(/ (+ (log 2.0d0)
-					(log most-positive-double-float))
-				     4d0))
-              (coerce-to-complex-type (float-sign x)
-                                      (float-sign y) z))
+	      ;; FIXME: this form is hideously broken wrt
+	      ;; cross-compilation portability.  Much else in this
+	      ;; file is too, of course, sometimes hidden by
+	      ;; constant-folding, but this one in particular clearly
+	      ;; depends on host and target
+	      ;; MOST-POSITIVE-DOUBLE-FLOATs being equal.  -- CSR,
+	      ;; 2003-04-20
+	      #.(/ (+ (log 2.0d0)
+		      (log most-positive-double-float))
+		   4d0))
+	   (coerce-to-complex-type (float-sign x)
+				   (float-sign y) z))
 	  (t
 	   (let* ((tv (%tan y))
 		  (beta (+ 1.0d0 (* tv tv)))