X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcold%2Fset-up-cold-packages.lisp;h=6533047ddd6134cdcf8f2b41927df1f629b67c50;hb=771b864c8f32af7734bc0550aeaf1539fc4df194;hp=d3c1e2b8b2798d9081f71f2f3a90426bb610af99;hpb=6139c89c89f45c03509e4f3156293ff656716a8c;p=sbcl.git

diff --git a/src/cold/set-up-cold-packages.lisp b/src/cold/set-up-cold-packages.lisp
index d3c1e2b..6533047 100644
--- a/src/cold/set-up-cold-packages.lisp
+++ b/src/cold/set-up-cold-packages.lisp
@@ -103,26 +103,36 @@
 
     ;; Now that all package-package references exist, we can handle
     ;; REEXPORT operations. (We have to wait until now because they
-    ;; interact with USE operations.) KLUDGE: This code doesn't detect
-    ;; dependencies and do exports in proper order to work around them, so
-    ;; it could break randomly (with build-time errors, not with silent
-    ;; errors or runtime errors) if multiple levels of re-exportation are
-    ;; used, e.g. package A exports X, package B uses A and reexports X,
-    ;; and package C uses B and reexports X. That doesn't seem to be an
-    ;; issue in the current code, and it's hard to see why anyone would
-    ;; want to do it, and it should be straightforward (though tedious) to
-    ;; extend the code here to deal with that if it ever becomes necessary.
-    (dolist (package-data package-data-list)
-      (let ((package (find-package (package-data-name package-data))))
-	(dolist (symbol-name (package-data-reexport package-data))
-	  (multiple-value-bind (symbol status)
-	      (find-symbol symbol-name package)
-	    (unless status
-	      (error "No symbol named ~S is accessible in ~S."
-		     symbol-name
-		     package))
-	    (when (eq (symbol-package symbol) package)
-	      (error "~S is not inherited/imported, but native to ~S."
-		     symbol-name
-		     package))
-	    (export symbol package))))))
+    ;; interact with USE operations.)  This code handles dependencies
+    ;; properly, but is somewhat ugly.
+    (let (done)
+      (labels
+	  ((reexport (package-data)
+	     (let ((package (find-package (package-data-name package-data))))
+	       (cond
+		 ((member package done))
+		 ((null (package-data-reexport package-data))
+		  (push package done))
+		 (t
+		  (mapcar #'reexport
+			  (remove-if-not
+			   (lambda (x)
+			     (member x (package-data-use package-data)
+				     :test #'string=))
+			   package-data-list
+			   :key #'package-data-name))
+		  (dolist (symbol-name (package-data-reexport package-data))
+		    (multiple-value-bind (symbol status)
+			(find-symbol symbol-name package)
+		      (unless status
+			(error "No symbol named ~S is accessible in ~S."
+			       symbol-name package))
+		      (when (eq (symbol-package symbol) package)
+			(error
+			 "~S is not inherited/imported, but native to ~S."
+			 symbol-name package))
+		      (export symbol package)))
+		  (push package done))))))
+	(dolist (x package-data-list)
+	  (reexport x))
+	(assert (= (length done) (length package-data-list))))))