X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcompiler%2Fdebug.lisp;h=7f67f0ffb7294b5681b72853d3f4f59a4cb823e3;hb=c7dc5b2a1f56ed0583a0b3ea61b6ceb540c6f89e;hp=19c3c64be2945892fde2caad763aeff16ac729f1;hpb=b05f52060838600d14b5d8ad4604a61351dd7017;p=sbcl.git

diff --git a/src/compiler/debug.lisp b/src/compiler/debug.lisp
index 19c3c64..7f67f0f 100644
--- a/src/compiler/debug.lisp
+++ b/src/compiler/debug.lisp
@@ -52,10 +52,12 @@
 ;;; *SEEN-BLOCKS* is a hashtable with true values for all blocks which
 ;;; appear in the DFO for one of the specified components.
 ;;;
-;;; *SEEN-FUNCTIONS* is similar, but records all the lambdas we
+;;; *SEEN-FUNS* is similar, but records all the lambdas we
 ;;; reached by recursing on top level functions.
+;;; FIXME: Is it really only LAMBDAs, not e.g. FUNCTIONALs? Then
+;;; shouldn't it be *SEEN-LAMBDAS*?
 (defvar *seen-blocks* (make-hash-table :test 'eq))
-(defvar *seen-functions* (make-hash-table :test 'eq))
+(defvar *seen-funs* (make-hash-table :test 'eq))
 
 ;;; Barf if NODE is in a block which wasn't reached during the graph
 ;;; walk.
@@ -65,31 +67,32 @@
     (barf "~S was not reached." node))
   (values))
 
-;;; Check everything that we can think of for consistency. When a definite
-;;; inconsistency is detected, we BARF. Possible problems just cause us to
-;;; BURP. Our argument is a list of components, but we also look at the
-;;; *FREE-VARIABLES*, *FREE-FUNCTIONS* and *CONSTANTS*.
+;;; Check everything that we can think of for consistency. When a
+;;; definite inconsistency is detected, we BARF. Possible problems
+;;; just cause us to BURP. Our argument is a list of components, but
+;;; we also look at the *FREE-VARS*, *FREE-FUNS* and *CONSTANTS*.
 ;;;
-;;; First we do a pre-pass which finds all the blocks and lambdas, testing
-;;; that they are linked together properly and entering them in hashtables.
-;;; Next, we iterate over the blocks again, looking at the actual code and
-;;; control flow. Finally, we scan the global leaf hashtables, looking for
-;;; lossage.
+;;; First we do a pre-pass which finds all the CBLOCKs and CLAMBDAs,
+;;; testing that they are linked together properly and entering them
+;;; in hashtables. Next, we iterate over the blocks again, looking at
+;;; the actual code and control flow. Finally, we scan the global leaf
+;;; hashtables, looking for lossage.
 (declaim (ftype (function (list) (values)) check-ir1-consistency))
 (defun check-ir1-consistency (components)
   (clrhash *seen-blocks*)
-  (clrhash *seen-functions*)
+  (clrhash *seen-funs*)
   (dolist (c components)
     (let* ((head (component-head c))
 	   (tail (component-tail c)))
-      (unless (and (null (block-pred head)) (null (block-succ tail)))
+      (unless (and (null (block-pred head))
+		   (null (block-succ tail)))
 	(barf "~S is malformed." c))
 
       (do ((prev nil block)
 	   (block head (block-next block)))
 	  ((null block)
 	   (unless (eq prev tail)
-	     (barf "wrong Tail for DFO, ~S in ~S" prev c)))
+	     (barf "wrong TAIL for DFO, ~S in ~S" prev c)))
 	(setf (gethash block *seen-blocks*) t)
 	(unless (eq (block-prev block) prev)
 	  (barf "bad PREV for ~S, should be ~S" block prev))
@@ -107,45 +110,45 @@
 |#
     ))
 
-  (check-function-consistency components)
+  (check-fun-consistency components)
 
   (dolist (c components)
     (do ((block (block-next (component-head c)) (block-next block)))
 	((null (block-next block)))
       (check-block-consistency block)))
 
-  (maphash #'(lambda (k v)
-	       (declare (ignore k))
-	       (unless (or (constant-p v)
-			   (and (global-var-p v)
-				(member (global-var-kind v)
-					'(:global :special))))
-		 (barf "strange *FREE-VARIABLES* entry: ~S" v))
-	       (dolist (n (leaf-refs v))
-		 (check-node-reached n))
-	       (when (basic-var-p v)
-		 (dolist (n (basic-var-sets v))
-		   (check-node-reached n))))
-	   *free-variables*)
-
-  (maphash #'(lambda (k v)
-	       (declare (ignore k))
-	       (unless (constant-p v)
-		 (barf "strange *CONSTANTS* entry: ~S" v))
-	       (dolist (n (leaf-refs v))
-		 (check-node-reached n)))
+  (maphash (lambda (k v)
+	     (declare (ignore k))
+	     (unless (or (constant-p v)
+			 (and (global-var-p v)
+			      (member (global-var-kind v)
+				      '(:global :special))))
+	       (barf "strange *FREE-VARS* entry: ~S" v))
+	     (dolist (n (leaf-refs v))
+	       (check-node-reached n))
+	     (when (basic-var-p v)
+	       (dolist (n (basic-var-sets v))
+		 (check-node-reached n))))
+	   *free-vars*)
+
+  (maphash (lambda (k v)
+	     (declare (ignore k))
+	     (unless (constant-p v)
+	       (barf "strange *CONSTANTS* entry: ~S" v))
+	     (dolist (n (leaf-refs v))
+	       (check-node-reached n)))
 	   *constants*)
 
-  (maphash #'(lambda (k v)
-	       (declare (ignore k))
-	       (unless (or (functional-p v)
-			   (and (global-var-p v)
-				(eq (global-var-kind v) :global-function)))
-		 (barf "strange *FREE-FUNCTIONS* entry: ~S" v))
-	       (dolist (n (leaf-refs v))
-		 (check-node-reached n)))
-	   *free-functions*)
-  (clrhash *seen-functions*)
+  (maphash (lambda (k v)
+	     (declare (ignore k))
+	     (unless (or (functional-p v)
+			 (and (global-var-p v)
+			      (eq (global-var-kind v) :global-function)))
+	       (barf "strange *FREE-FUNS* entry: ~S" v))
+	     (dolist (n (leaf-refs v))
+	       (check-node-reached n)))
+	   *free-funs*)
+  (clrhash *seen-funs*)
   (clrhash *seen-blocks*)
   (values))
 
@@ -153,31 +156,31 @@
 
 (defun observe-functional (x)
   (declare (type functional x))
-  (when (gethash x *seen-functions*)
+  (when (gethash x *seen-funs*)
     (barf "~S was seen more than once." x))
   (unless (eq (functional-kind x) :deleted)
-    (setf (gethash x *seen-functions*) t)))
+    (setf (gethash x *seen-funs*) t)))
 
 ;;; Check that the specified function has been seen.
-(defun check-function-reached (fun where)
+(defun check-fun-reached (fun where)
   (declare (type functional fun))
-  (unless (gethash fun *seen-functions*)
+  (unless (gethash fun *seen-funs*)
     (barf "unseen function ~S in ~S" fun where)))
 
 ;;; In a CLAMBDA, check that the associated nodes are in seen blocks.
 ;;; In an OPTIONAL-DISPATCH, check that the entry points were seen. If
 ;;; the function is deleted, ignore it.
-(defun check-function-stuff (functional)
+(defun check-fun-stuff (functional)
   (ecase (functional-kind functional)
     (:external
      (let ((fun (functional-entry-fun functional)))
-       (check-function-reached fun functional)
+       (check-fun-reached fun functional)
        (when (functional-kind fun)
 	 (barf "The function for XEP ~S has kind." functional))
        (unless (eq (functional-entry-fun fun) functional)
 	 (barf "bad back-pointer in function for XEP ~S" functional))))
-    ((:let :mv-let :assignment)
-     (check-function-reached (lambda-home functional) functional)
+    ((:let :mv-let :assignment) ; i.e. SOMEWHAT-LETLIKE-P
+     (check-fun-reached (lambda-home functional) functional)
      (when (functional-entry-fun functional)
        (barf "The LET ~S has entry function." functional))
      (unless (member functional (lambda-lets (lambda-home functional)))
@@ -191,7 +194,7 @@
      (when (functional-entry-fun functional)
        (barf ":OPTIONAL ~S has an ENTRY-FUN." functional))
      (let ((ef (lambda-optional-dispatch functional)))
-       (check-function-reached ef functional)
+       (check-fun-reached ef functional)
        (unless (or (member functional (optional-dispatch-entry-points ef))
 		   (eq functional (optional-dispatch-more-entry ef))
 		   (eq functional (optional-dispatch-main-entry ef)))
@@ -203,11 +206,11 @@
     ((nil :escape :cleanup)
      (let ((ef (functional-entry-fun functional)))
        (when ef
-	 (check-function-reached ef functional)
+	 (check-fun-reached ef functional)
 	 (unless (eq (functional-kind ef) :external)
 	   (barf "The ENTRY-FUN in ~S isn't an XEP: ~S." functional ef)))))
     (:deleted
-     (return-from check-function-stuff)))
+     (return-from check-fun-stuff)))
 
   (case (functional-kind functional)
     ((nil :optional :external :toplevel :escape :cleanup)
@@ -215,7 +218,7 @@
        (dolist (fun (lambda-lets functional))
 	 (unless (eq (lambda-home fun) functional)
 	   (barf "The home in ~S is not ~S." fun functional))
-	 (check-function-reached fun functional))
+	 (check-fun-reached fun functional))
        (unless (eq (lambda-home functional) functional)
 	 (barf "home not self-pointer in ~S" functional)))))
 
@@ -235,15 +238,15 @@
 	 (barf "HOME in ~S should be ~S." var functional))))
     (optional-dispatch
      (dolist (ep (optional-dispatch-entry-points functional))
-       (check-function-reached ep functional))
+       (check-fun-reached ep functional))
      (let ((more (optional-dispatch-more-entry functional)))
-       (when more (check-function-reached more functional)))
-     (check-function-reached (optional-dispatch-main-entry functional)
-			     functional))))
+       (when more (check-fun-reached more functional)))
+     (check-fun-reached (optional-dispatch-main-entry functional)
+			functional))))
 
-(defun check-function-consistency (components)
+(defun check-fun-consistency (components)
   (dolist (c components)
-    (dolist (new-fun (component-new-funs c))
+    (dolist (new-fun (component-new-functionals c))
       (observe-functional new-fun))
     (dolist (fun (component-lambdas c))
       (when (eq (functional-kind fun) :external)
@@ -255,14 +258,14 @@
 	(observe-functional let))))
 
   (dolist (c components)
-    (dolist (new-fun (component-new-funs c))
-      (check-function-stuff new-fun))
+    (dolist (new-fun (component-new-functionals c))
+      (check-fun-stuff new-fun))
     (dolist (fun (component-lambdas c))
       (when (eq (functional-kind fun) :deleted)
 	(barf "deleted lambda ~S in Lambdas for ~S" fun c))
-      (check-function-stuff fun)
+      (check-fun-stuff fun)
       (dolist (let (lambda-lets fun))
-	(check-function-stuff let)))))
+	(check-fun-stuff let)))))
 
 ;;;; loop consistency checking
 
@@ -332,7 +335,7 @@
 	 (this-cont (block-start block))
 	 (last (block-last block)))
     (unless fun-deleted
-      (check-function-reached fun block))
+      (check-fun-reached fun block))
     (when (not this-cont)
       (barf "~S has no START." block))
     (when (not last)
@@ -375,7 +378,7 @@
       (when dest
 	(check-node-reached dest)))
 
-    (loop	
+    (loop
       (unless (eq (continuation-block this-cont) block)
 	(barf "BLOCK in ~S should be ~S." this-cont block))
 
@@ -391,7 +394,7 @@
 
 	(unless fun-deleted
 	  (check-node-consistency node))
-	
+
 	(let ((cont (node-cont node)))
 	  (when (not cont)
 	    (barf "~S has no CONT." node))
@@ -405,11 +408,11 @@
 	  (unless (eq (continuation-use cont) node)
 	    (barf "USE in ~S should be ~S." cont node))
 	  (setq this-cont cont))))
-	
+
     (check-block-successors block))
   (values))
 
-;;; Check that Block is properly terminated. Each successor must be
+;;; Check that BLOCK is properly terminated. Each successor must be
 ;;; accounted for by the type of the last node.
 (declaim (ftype (function (cblock) (values)) check-block-successors))
 (defun check-block-successors (block)
@@ -455,8 +458,8 @@
 
 ;;;; node consistency checking
 
-;;; Check that the Dest for Cont is the specified Node. We also mark the
-;;; block Cont is in as Seen.
+;;; Check that the DEST for CONT is the specified NODE. We also mark
+;;; the block CONT is in as SEEN.
 (declaim (ftype (function (continuation node) (values)) check-dest))
 (defun check-dest (cont node)
   (let ((kind (continuation-kind cont)))
@@ -475,8 +478,8 @@
 	 (barf "DEST for ~S should be ~S." cont node)))))
   (values))
 
-;;; This function deals with checking for consistency the type-dependent
-;;; information in a node.
+;;; This function deals with checking for consistency of the
+;;; type-dependent information in a node.
 (defun check-node-consistency (node)
   (declare (type node node))
   (etypecase node
@@ -488,7 +491,7 @@
 			 :toplevel)
 	       (barf ":TOPLEVEL-XEP ref in non-top-level component: ~S"
 		     node))
-	     (check-function-reached leaf node)))))
+	     (check-fun-reached leaf node)))))
     (basic-combination
      (check-dest (basic-combination-fun node) node)
      (dolist (arg (basic-combination-args node))
@@ -526,9 +529,9 @@
     (cset
      (check-dest (set-value node) node))
     (bind
-     (check-function-reached (bind-lambda node) node))
+     (check-fun-reached (bind-lambda node) node))
     (creturn
-     (check-function-reached (return-lambda node) node)
+     (check-fun-reached (return-lambda node) node)
      (check-dest (return-result node) node)
      (unless (eq (block-last (node-block node)) node)
        (barf "RETURN not at block end: ~S" node)))
@@ -555,12 +558,12 @@
 
 ;;;; IR2 consistency checking
 
-;;; Check for some kind of consistency in some Refs linked together by
-;;; TN-Ref-Across. VOP is the VOP that the references are in. Write-P is the
-;;; value of Write-P that should be present. Count is the minimum number of
-;;; operands expected. If More-P is true, then any larger number will also be
-;;; accepted. What is a string describing the kind of operand in error
-;;; messages.
+;;; Check for some kind of consistency in some REFs linked together by
+;;; TN-REF-ACROSS. VOP is the VOP that the references are in. WRITE-P
+;;; is the value of WRITE-P that should be present. COUNT is the
+;;; minimum number of operands expected. If MORE-P is true, then any
+;;; larger number will also be accepted. WHAT is a string describing
+;;; the kind of operand in error messages.
 (defun check-tn-refs (refs vop write-p count more-p what)
   (let ((vop-refs (vop-refs vop)))
     (do ((ref refs (tn-ref-across ref))
@@ -591,7 +594,7 @@
 	  (unless (find-in #'tn-ref-next-ref target vop-refs)
 	    (barf "The target for ~S isn't in REFS for ~S." ref vop)))))))
 
-;;; Verify the sanity of the VOP-Refs slot in VOP. This involves checking
+;;; Verify the sanity of the VOP-REFS slot in VOP. This involves checking
 ;;; that each referenced TN appears as an argument, result or temp, and also
 ;;; basic checks for the plausibility of the specified ordering of the refs.
 (defun check-vop-refs (vop)
@@ -618,8 +621,8 @@
   (values))
 
 ;;; Check the basic sanity of the VOP linkage, then call some other
-;;; functions to check on the TN-Refs. We grab some info out of the VOP-Info
-;;; to tell us what to expect.
+;;; functions to check on the TN-REFS. We grab some info out of the
+;;; VOP-INFO to tell us what to expect.
 ;;;
 ;;; [### Check that operand type restrictions are met?]
 (defun check-ir2-block-consistency (2block)
@@ -642,9 +645,9 @@
 	   (atypes (template-arg-types info))
 	   (rtypes (template-result-types info)))
       (check-tn-refs (vop-args vop) vop nil
-		     (count-if-not #'(lambda (x)
-				       (and (consp x)
-					    (eq (car x) :constant)))
+		     (count-if-not (lambda (x)
+				     (and (consp x)
+					  (eq (car x) :constant)))
 				   atypes)
 		     (template-more-args-type info) "args")
       (check-tn-refs (vop-results vop) vop t
@@ -656,12 +659,12 @@
 	(barf "wrong number of codegen info args in ~S" vop))))
   (values))
 
-;;; Check stuff about the IR2 representation of Component. This assumes the
+;;; Check stuff about the IR2 representation of COMPONENT. This assumes the
 ;;; sanity of the basic flow graph.
 ;;;
 ;;; [### Also grovel global TN data structures?  Assume pack not
-;;; done yet?  Have separate check-tn-consistency for pre-pack and
-;;; check-pack-consistency for post-pack?]
+;;; done yet?  Have separate CHECK-TN-CONSISTENCY for pre-pack and
+;;; CHECK-PACK-CONSISTENCY for post-pack?]
 (defun check-ir2-consistency (component)
   (declare (type component component))
   (do-ir2-blocks (block component)
@@ -701,7 +704,7 @@
 	       ((:environment :debug-environment) (incf environment))
 	       (t (incf global)))
 	     (do ((conf (tn-global-conflicts tn)
-			(global-conflicts-tn-next conf)))
+			(global-conflicts-next-tnwise conf)))
 		 ((null conf))
 	       (incf confs)))
 	    (t
@@ -720,7 +723,7 @@
        confs))
   (values))
 
-;;; If the entry in Local-TNs for TN in Block is :More, then do some checks
+;;; If the entry in Local-TNs for TN in BLOCK is :MORE, then do some checks
 ;;; for the validity of the usage.
 (defun check-more-tn-entry (tn block)
   (let* ((vop (ir2-block-start-vop block))
@@ -750,9 +753,9 @@
        ((eq kind :component)
 	(unless (member tn (ir2-component-component-tns
 			    (component-info component)))
-	  (barf "~S not in Component-TNs for ~S" tn component)))
+	  (barf "~S not in COMPONENT-TNs for ~S" tn component)))
        (conf
-	(do ((conf conf (global-conflicts-tn-next conf))
+	(do ((conf conf (global-conflicts-next-tnwise conf))
 	     (prev nil conf))
 	    ((null conf))
 	  (unless (eq (global-conflicts-tn conf) tn)
@@ -795,7 +798,7 @@
 (defun check-block-conflicts (component)
   (do-ir2-blocks (block component)
     (do ((conf (ir2-block-global-tns block)
-	       (global-conflicts-next conf))
+	       (global-conflicts-next-blockwise conf))
 	 (prev nil conf))
 	((null conf))
       (when prev
@@ -803,7 +806,7 @@
 		   (tn-number (global-conflicts-tn prev)))
 	  (barf "~S and ~S out of order in ~S" prev conf block)))
 
-      (unless (find-in #'global-conflicts-tn-next
+      (unless (find-in #'global-conflicts-next-tnwise
 		       conf
 		       (tn-global-conflicts
 			(global-conflicts-tn conf)))
@@ -832,7 +835,7 @@
 	   (fp (ir2-physenv-old-fp 2env))
 	   (2block (block-info (lambda-block (physenv-lambda env)))))
       (do ((conf (ir2-block-global-tns 2block)
-		 (global-conflicts-next conf)))
+		 (global-conflicts-next-blockwise conf)))
 	  ((null conf))
 	(let ((tn (global-conflicts-tn conf)))
 	  (unless (or (eq (global-conflicts-kind conf) :write)
@@ -877,27 +880,36 @@
 
 ;;;; data structure dumping routines
 
-;;; When we print Continuations and TNs, we assign them small numeric IDs so
-;;; that we can get a handle on anonymous objects given a printout.
-(macrolet ((def-frob (counter vto vfrom fto ffrom)
+;;; When we print CONTINUATIONs and TNs, we assign them small numeric
+;;; IDs so that we can get a handle on anonymous objects given a
+;;; printout.
+;;;
+;;; FIXME:
+;;;   * Perhaps this machinery should be #!+SB-SHOW.
+;;;   * Probably the hash tables should either be weak hash tables,
+;;;     or only allocated within a single compilation unit. Otherwise
+;;;     there will be a tendency for them to grow without bound and
+;;;     keep garbage from being collected.
+(macrolet ((def (counter vto vfrom fto ffrom)
 	     `(progn
 		(defvar ,vto (make-hash-table :test 'eq))
 		(defvar ,vfrom (make-hash-table :test 'eql))
 		(proclaim '(hash-table ,vto ,vfrom))
 		(defvar ,counter 0)
 		(proclaim '(fixnum ,counter))
-		
+
 		(defun ,fto (x)
 		  (or (gethash x ,vto)
 		      (let ((num (incf ,counter)))
 			(setf (gethash num ,vfrom) x)
 			(setf (gethash x ,vto) num))))
-		
+
 		(defun ,ffrom (num)
 		  (values (gethash num ,vfrom))))))
-  (def-frob *continuation-number* *continuation-numbers* *number-continuations* cont-num num-cont)
-  (def-frob *tn-id* *tn-ids* *id-tns* tn-id id-tn)
-  (def-frob *label-id* *id-labels* *label-ids* label-id id-label))
+  (def *continuation-number* *continuation-numbers* *number-continuations*
+       cont-num num-cont)
+  (def *tn-id* *tn-ids* *id-tns* tn-id id-tn)
+  (def *label-id* *id-labels* *label-ids* label-id id-label))
 
 ;;; Print a terse one-line description of LEAF.
 (defun print-leaf (leaf &optional (stream *standard-output*))
@@ -925,7 +937,7 @@
     (integer (continuation-block (num-cont thing)))
     (functional (lambda-block (main-entry thing)))
     (null (error "Bad thing: ~S." thing))
-    (symbol (block-or-lose (gethash thing *free-functions*)))))
+    (symbol (block-or-lose (gethash thing *free-funs*)))))
 
 ;;; Print cN.
 (defun print-continuation (cont)
@@ -937,61 +949,63 @@
 ;;; representing what the code does.
 (defun print-nodes (block)
   (setq block (block-or-lose block))
-  (format t "~%block start c~D" (cont-num (block-start block)))
-
-  (let ((last (block-last block)))
-    (terpri)
-    (do ((cont (block-start block) (node-cont (continuation-next cont))))
-	(())
-      (let ((node (continuation-next cont)))
-	(format t "~3D: " (cont-num (node-cont node)))
-	(etypecase node
-	  (ref (print-leaf (ref-leaf node)))
-	  (basic-combination
-	   (let ((kind (basic-combination-kind node)))
-	     (format t "~(~A ~A~) c~D"
-		     (if (function-info-p kind) "known" kind)
-		     (type-of node)
-		     (cont-num (basic-combination-fun node)))
-	     (dolist (arg (basic-combination-args node))
-	       (if arg
-		   (print-continuation arg)
-		   (format t " <none>")))))
-	  (cset
-	   (write-string "set ")
-	   (print-leaf (set-var node))
-	   (print-continuation (set-value node)))
-	  (cif
-	   (format t "if c~D" (cont-num (if-test node)))
-	   (print-continuation (block-start (if-consequent node)))
-	   (print-continuation (block-start (if-alternative node))))
-	  (bind
-	   (write-string "bind ")
-	   (print-leaf (bind-lambda node)))
-	  (creturn
-	   (format t "return c~D " (cont-num (return-result node)))
-	   (print-leaf (return-lambda node)))
-	  (entry
-	   (format t "entry ~S" (entry-exits node)))
-	  (exit
-	   (let ((value (exit-value node)))
-	     (cond (value
-		    (format t "exit c~D" (cont-num value)))
-		   ((exit-entry node)
-		    (format t "exit <no value>"))
-		   (t
-		    (format t "exit <degenerate>"))))))
-	(terpri)
-	(when (eq node last) (return)))))
-
-  (let ((succ (block-succ block)))
-    (format t "successors~{ c~D~}~%"
-	    (mapcar #'(lambda (x) (cont-num (block-start x))) succ)))
+  (pprint-logical-block (nil nil)
+    (format t "~:@_IR1 block ~D start c~D"
+           (block-number block) (cont-num (block-start block)))
+
+    (let ((last (block-last block)))
+     (pprint-newline :mandatory)
+     (do ((cont (block-start block) (node-cont (continuation-next cont))))
+         ((not cont))
+       (let ((node (continuation-next cont)))
+         (format t "~3D: " (cont-num (node-cont node)))
+         (etypecase node
+           (ref (print-leaf (ref-leaf node)))
+           (basic-combination
+            (let ((kind (basic-combination-kind node)))
+              (format t "~(~A ~A~) c~D"
+                      (if (fun-info-p kind) "known" kind)
+                      (type-of node)
+                      (cont-num (basic-combination-fun node)))
+              (dolist (arg (basic-combination-args node))
+                (if arg
+                    (print-continuation arg)
+                    (format t " <none>")))))
+           (cset
+            (write-string "set ")
+            (print-leaf (set-var node))
+            (print-continuation (set-value node)))
+           (cif
+            (format t "if c~D" (cont-num (if-test node)))
+            (print-continuation (block-start (if-consequent node)))
+            (print-continuation (block-start (if-alternative node))))
+           (bind
+            (write-string "bind ")
+            (print-leaf (bind-lambda node)))
+           (creturn
+            (format t "return c~D " (cont-num (return-result node)))
+            (print-leaf (return-lambda node)))
+           (entry
+            (format t "entry ~S" (entry-exits node)))
+           (exit
+            (let ((value (exit-value node)))
+              (cond (value
+                     (format t "exit c~D" (cont-num value)))
+                    ((exit-entry node)
+                     (format t "exit <no value>"))
+                    (t
+                     (format t "exit <degenerate>"))))))
+         (pprint-newline :mandatory)
+         (when (eq node last) (return)))))
+
+   (let ((succ (block-succ block)))
+     (format t "successors~{ c~D~}~%"
+             (mapcar (lambda (x) (cont-num (block-start x))) succ))))
   (values))
 
-;;; Print a useful representation of a TN. If the TN has a leaf, then do a
-;;; Print-Leaf on that, otherwise print a generated ID.
-(defun print-tn (tn &optional (stream *standard-output*))
+;;; Print the guts of a TN. (logic shared between PRINT-OBJECT (TN T)
+;;; and printers for compound objects which contain TNs)
+(defun print-tn-guts (tn &optional (stream *standard-output*))
   (declare (type tn tn))
   (let ((leaf (tn-leaf tn)))
     (cond (leaf
@@ -1002,8 +1016,8 @@
     (when (and (tn-sc tn) (tn-offset tn))
       (format stream "[~A]" (location-print-name tn)))))
 
-;;; Print the TN-Refs representing some operands to a VOP, linked by
-;;; TN-Ref-Across.
+;;; Print the TN-REFs representing some operands to a VOP, linked by
+;;; TN-REF-ACROSS.
 (defun print-operands (refs)
   (declare (type (or tn-ref null) refs))
   (pprint-logical-block (*standard-output* nil)
@@ -1012,15 +1026,15 @@
       (let ((tn (tn-ref-tn ref))
 	    (ltn (tn-ref-load-tn ref)))
 	(cond ((not ltn)
-	       (print-tn tn))
+	       (print-tn-guts tn))
 	      (t
-	       (print-tn tn)
+	       (print-tn-guts tn)
 	       (princ (if (tn-ref-write-p ref) #\< #\>))
-	       (print-tn ltn)))
+	       (print-tn-guts ltn)))
 	(princ #\space)
 	(pprint-newline :fill)))))
 
-;;; Print the vop, putting args, info and results on separate lines, if
+;;; Print the VOP, putting args, info and results on separate lines, if
 ;;; necessary.
 (defun print-vop (vop)
   (pprint-logical-block (*standard-output* nil)
@@ -1038,27 +1052,29 @@
     (when (vop-results vop)
       (princ "=> ")
       (print-operands (vop-results vop))))
-  (terpri))
+  (pprint-newline :mandatory))
 
 ;;; Print the VOPs in the specified IR2 block.
 (defun print-ir2-block (block)
   (declare (type ir2-block block))
-  (cond
-   ((eq (block-info (ir2-block-block block)) block)
-    (format t "~%IR2 block start c~D~%"
-	    (cont-num (block-start (ir2-block-block block))))
-    (let ((label (ir2-block-%label block)))
-      (when label
-	(format t "L~D:~%" (label-id label)))))
-   (t
-    (format t "<overflow>~%")))
-
-  (do ((vop (ir2-block-start-vop block)
-	    (vop-next vop))
-       (number 0 (1+ number)))
-      ((null vop))
-    (format t "~W: " number)
-    (print-vop vop)))
+  (pprint-logical-block (*standard-output* nil)
+    (cond
+      ((eq (block-info (ir2-block-block block)) block)
+       (format t "~:@_IR2 block ~D start c~D~:@_"
+               (ir2-block-number block)
+               (cont-num (block-start (ir2-block-block block))))
+       (let ((label (ir2-block-%label block)))
+         (when label
+           (format t "L~D:~:@_" (label-id label)))))
+      (t
+       (format t "<overflow>~:@_")))
+
+    (do ((vop (ir2-block-start-vop block)
+              (vop-next vop))
+         (number 0 (1+ number)))
+        ((null vop))
+      (format t "~W: " number)
+      (print-vop vop))))
 
 ;;; This is like PRINT-NODES, but dumps the IR2 representation of the
 ;;; code in BLOCK.
@@ -1072,9 +1088,24 @@
   (values))
 
 ;;; Scan the IR2 blocks in emission order.
-(defun print-ir2-blocks (thing)
-  (do-ir2-blocks (block (block-component (block-or-lose thing)))
-    (print-ir2-block block))
+(defun print-ir2-blocks (thing &optional full)
+  (let* ((block (component-head (block-component (block-or-lose thing))))
+         (2block (block-info block)))
+    (pprint-logical-block (nil nil)
+      (loop while 2block
+         do (setq block (ir2-block-block 2block))
+         do (pprint-logical-block (*standard-output* nil)
+              (if full
+                  (print-nodes block)
+                  (format t "IR1 block ~D start c~D"
+                          (block-number block)
+                          (cont-num (block-start block))))
+              (pprint-indent :block 4)
+              (pprint-newline :mandatory)
+              (loop while (and 2block (eq (ir2-block-block 2block) block))
+                 do (print-ir2-block 2block)
+                 do (setq 2block (ir2-block-next 2block))))
+         do (pprint-newline :mandatory))))
   (values))
 
 ;;; Do a PRINT-NODES on BLOCK and all blocks reachable from it by
@@ -1108,7 +1139,7 @@
 (defun add-always-live-tns (block tn)
   (declare (type ir2-block block) (type tn tn))
   (do ((conf (ir2-block-global-tns block)
-	     (global-conflicts-next conf)))
+	     (global-conflicts-next-blockwise conf)))
       ((null conf))
     (when (eq (global-conflicts-kind conf) :live)
       (let ((btn (global-conflicts-tn conf)))
@@ -1127,10 +1158,10 @@
 ;;; Make a list out of all of the recorded conflicts.
 (defun listify-conflicts-table ()
   (collect ((res))
-    (maphash #'(lambda (k v)
-		 (declare (ignore v))
-		 (when k
-		   (res k)))
+    (maphash (lambda (k v)
+	       (declare (ignore v))
+	       (when k
+		 (res k)))
 	     *list-conflicts-table*)
     (clrhash *list-conflicts-table*)
     (res)))
@@ -1142,8 +1173,11 @@
   (let ((confs (tn-global-conflicts tn)))
     (cond (confs
 	   (clrhash *list-conflicts-table*)
-	   (do ((conf confs (global-conflicts-tn-next conf)))
+	   (do ((conf confs (global-conflicts-next-tnwise conf)))
 	       ((null conf))
+             (format t "~&#<block ~D kind ~S>~%"
+                     (block-number (ir2-block-block (global-conflicts-block conf)))
+                     (global-conflicts-kind conf))
 	     (let ((block (global-conflicts-block conf)))
 	       (add-always-live-tns block tn)
 	       (if (eq (global-conflicts-kind conf) :live)
@@ -1167,7 +1201,7 @@
 				(not (tn-global-conflicts tn)))
 		       (res tn)))))
 	       (do ((gtn (ir2-block-global-tns block)
-			 (global-conflicts-next gtn)))
+			 (global-conflicts-next-blockwise gtn)))
 		   ((null gtn))
 		 (when (or (eq (global-conflicts-kind gtn) :live)
 			   (/= (sbit confs (global-conflicts-number gtn)) 0))
@@ -1176,7 +1210,7 @@
 
 (defun nth-vop (thing n)
   #!+sb-doc
-  "Return the Nth VOP in the IR2-Block pointed to by Thing."
+  "Return the Nth VOP in the IR2-BLOCK pointed to by THING."
   (let ((block (block-info (block-or-lose thing))))
     (do ((i 0 (1+ i))
 	 (vop (ir2-block-start-vop block) (vop-next vop)))