X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcompiler%2Fearly-c.lisp;h=c748a0c481041bc8fd0a488aaf9cd85fed783d2f;hb=ea36d3d79b9dfe3598faca5e267efd5980b94d4a;hp=913bde5d8ef26ae7ec191a3bcefdf598559dbea2;hpb=4823297c200e5b1fcab240f06ce82c308b8ee7d7;p=sbcl.git diff --git a/src/compiler/early-c.lisp b/src/compiler/early-c.lisp index 913bde5..c748a0c 100644 --- a/src/compiler/early-c.lisp +++ b/src/compiler/early-c.lisp @@ -56,13 +56,13 @@ ;;; *FREE-VARIABLES*, only it deals with function names. (defvar *free-variables*) (defvar *free-functions*) -(declaim (hash-table *free-variables* *free-functions*)) +(declaim (type hash-table *free-variables* *free-functions*)) -;;; We use the same Constant structure to represent all equal anonymous -;;; constants. This hashtable translates from constants to the Leafs that +;;; We use the same CONSTANT structure to represent all equal anonymous +;;; constants. This hashtable translates from constants to the LEAFs that ;;; represent them. (defvar *constants*) -(declaim (hash-table *constants*)) +(declaim (type hash-table *constants*)) ;;; miscellaneous forward declarations (defvar *code-segment*) @@ -116,7 +116,6 @@ ;;; to be called when a variable is lexically bound (declaim (ftype (function (symbol) (values)) note-lexical-binding)) (defun note-lexical-binding (symbol) - (let ((name (symbol-name symbol))) ;; This check is intended to protect us from getting silently ;; burned when we define ;; foo.lisp: @@ -127,10 +126,9 @@ ;; (LET ((*FOO* X)) ;; (FOO 14))) ;; and then we happen to compile bar.lisp before foo.lisp. - (when (and (char= #\* (aref name 0)) - (char= #\* (aref name (1- (length name))))) + (when (looks-like-name-of-special-var-p symbol) ;; FIXME: should be COMPILER-STYLE-WARNING? (style-warn "using the lexical binding of the symbol ~S, not the~@ dynamic binding, even though the symbol name follows the usual naming~@ -convention (names like *FOO*) for special variables" symbol))) +convention (names like *FOO*) for special variables" symbol)) (values))