X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcompiler%2Fgeneric%2Fvm-tran.lisp;h=8b24413c345a1a68a3136d18db40cbb8d2e40986;hb=0c7ffa8fb85a94482814835c9f28abfd0400ab99;hp=a78cf36fb6a8f4b4b8c708988f393e65bcb88ea7;hpb=b1de52969f584c63d43fb35da4a8a6a4e0e619f0;p=sbcl.git diff --git a/src/compiler/generic/vm-tran.lisp b/src/compiler/generic/vm-tran.lisp index a78cf36..8b24413 100644 --- a/src/compiler/generic/vm-tran.lisp +++ b/src/compiler/generic/vm-tran.lisp @@ -16,34 +16,34 @@ ;;; FIXME: Add a comment telling whether this holds for all vectors ;;; or only for vectors based on simple arrays (non-adjustable, etc.). (defconstant vector-data-bit-offset - (* sb!vm:vector-data-offset sb!vm:word-bits)) + (* sb!vm:vector-data-offset sb!vm:n-word-bits)) ;;; We need to define these predicates, since the TYPEP source ;;; transform picks whichever predicate was defined last when there ;;; are multiple predicates for equivalent types. -(def-source-transform short-float-p (x) `(single-float-p ,x)) +(define-source-transform short-float-p (x) `(single-float-p ,x)) #!-long-float -(def-source-transform long-float-p (x) `(double-float-p ,x)) +(define-source-transform long-float-p (x) `(double-float-p ,x)) -(def-source-transform compiled-function-p (x) +(define-source-transform compiled-function-p (x) `(functionp ,x)) -(def-source-transform char-int (x) +(define-source-transform char-int (x) `(char-code ,x)) (deftransform abs ((x) (rational)) '(if (< x 0) (- x) x)) ;;; The layout is stored in slot 0. -(def-source-transform %instance-layout (x) +(define-source-transform %instance-layout (x) `(truly-the layout (%instance-ref ,x 0))) -(def-source-transform %set-instance-layout (x val) +(define-source-transform %set-instance-layout (x val) `(%instance-set ,x 0 (the layout ,val))) ;;;; character support ;;; In our implementation there are really only BASE-CHARs. -(def-source-transform characterp (obj) +(define-source-transform characterp (obj) `(base-char-p ,obj)) ;;;; simplifying HAIRY-DATA-VECTOR-REF and HAIRY-DATA-VECTOR-SET @@ -153,7 +153,7 @@ #+nil (macrolet ((frob (type bits) - (let ((elements-per-word (truncate sb!vm:word-bits bits))) + (let ((elements-per-word (truncate sb!vm:n-word-bits bits))) `(progn (deftransform data-vector-ref ((vector index) (,type *)) @@ -161,7 +161,7 @@ (floor index ,',elements-per-word) (ldb ,(ecase sb!vm:target-byte-order (:little-endian '(byte ,bits (* bit ,bits))) - (:big-endian '(byte ,bits (- sb!vm:word-bits + (:big-endian '(byte ,bits (- sb!vm:n-word-bits (* (1+ bit) ,bits))))) (%raw-bits vector (+ word sb!vm:vector-data-offset))))) (deftransform data-vector-set ((vector index new-value) @@ -171,7 +171,7 @@ (setf (ldb ,(ecase sb!vm:target-byte-order (:little-endian '(byte ,bits (* bit ,bits))) (:big-endian - '(byte ,bits (- sb!vm:word-bits + '(byte ,bits (- sb!vm:n-word-bits (* (1+ bit) ,bits))))) (%raw-bits vector (+ word sb!vm:vector-data-offset))) new-value))))))) @@ -179,47 +179,52 @@ (frob (simple-array (unsigned-byte 2) (*)) 2) (frob (simple-array (unsigned-byte 4) (*)) 4)) -;;;; bit vector hackery +;;;; BIT-VECTOR hackery -;;; SIMPLE-BIT-VECTOR bit-array operations are transformed to a word loop that -;;; does 32 bits at a time. +;;; SIMPLE-BIT-VECTOR bit-array operations are transformed to a word +;;; loop that does 32 bits at a time. ;;; -;;; FIXME: This is a lot of repeatedly macroexpanded code. It should be a -;;; function call instead. And do it with DEF-FROB instead of DOLIST. -(dolist (x '((bit-and 32bit-logical-and) - (bit-ior 32bit-logical-or) - (bit-xor 32bit-logical-xor) - (bit-eqv 32bit-logical-eqv) - (bit-nand 32bit-logical-nand) - (bit-nor 32bit-logical-nor) - (bit-andc1 32bit-logical-andc1) - (bit-andc2 32bit-logical-andc2) - (bit-orc1 32bit-logical-orc1) - (bit-orc2 32bit-logical-orc2))) - (destructuring-bind (bitfun wordfun) x - (deftransform bitfun - ((bit-array-1 bit-array-2 result-bit-array) - '(simple-bit-vector simple-bit-vector simple-bit-vector) '* - :eval-name t :node node :policy (>= speed space)) - `(progn - ,@(unless (policy node (zerop safety)) - '((unless (= (length bit-array-1) (length bit-array-2) - (length result-bit-array)) - (error "Argument and/or result bit arrays are not the same length:~ +;;; FIXME: This is a lot of repeatedly macroexpanded code. It should +;;; be a function call instead. +(macrolet ((def (bitfun wordfun) + `(deftransform ,bitfun ((bit-array-1 bit-array-2 result-bit-array) + (simple-bit-vector + simple-bit-vector + simple-bit-vector) + * + :node node :policy (>= speed space)) + `(progn + ,@(unless (policy node (zerop safety)) + '((unless (= (length bit-array-1) + (length bit-array-2) + (length result-bit-array)) + (error "Argument and/or result bit arrays are not the same length:~ ~% ~S~% ~S ~% ~S" - bit-array-1 bit-array-2 result-bit-array)))) - (do ((index sb!vm:vector-data-offset (1+ index)) - (end (+ sb!vm:vector-data-offset - (truncate (the index - (+ (length bit-array-1) - sb!vm:word-bits -1)) - sb!vm:word-bits)))) - ((= index end) result-bit-array) - (declare (optimize (speed 3) (safety 0)) - (type index index end)) - (setf (%raw-bits result-bit-array index) - (,wordfun (%raw-bits bit-array-1 index) - (%raw-bits bit-array-2 index)))))))) + bit-array-1 + bit-array-2 + result-bit-array)))) + (do ((index sb!vm:vector-data-offset (1+ index)) + (end (+ sb!vm:vector-data-offset + (truncate (the index + (+ (length bit-array-1) + sb!vm:n-word-bits -1)) + sb!vm:n-word-bits)))) + ((= index end) result-bit-array) + (declare (optimize (speed 3) (safety 0)) + (type index index end)) + (setf (%raw-bits result-bit-array index) + (,',wordfun (%raw-bits bit-array-1 index) + (%raw-bits bit-array-2 index)))))))) + (def bit-and 32bit-logical-and) + (def bit-ior 32bit-logical-or) + (def bit-xor 32bit-logical-xor) + (def bit-eqv 32bit-logical-eqv) + (def bit-nand 32bit-logical-nand) + (def bit-nor 32bit-logical-nor) + (def bit-andc1 32bit-logical-andc1) + (def bit-andc2 32bit-logical-andc2) + (def bit-orc1 32bit-logical-orc1) + (def bit-orc2 32bit-logical-orc2)) (deftransform bit-not ((bit-array result-bit-array) @@ -236,42 +241,52 @@ (end (+ sb!vm:vector-data-offset (truncate (the index (+ (length bit-array) - (1- sb!vm:word-bits))) - sb!vm:word-bits)))) + (1- sb!vm:n-word-bits))) + sb!vm:n-word-bits)))) ((= index end) result-bit-array) (declare (optimize (speed 3) (safety 0)) (type index index end)) (setf (%raw-bits result-bit-array index) (32bit-logical-not (%raw-bits bit-array index)))))) -;;;; primitive translator for BYTE-BLT +;;;; %BYTE-BLT -(def-primitive-translator byte-blt (src src-start dst dst-start dst-end) - `(let ((src ,src) - (src-start (* ,src-start sb!vm:byte-bits)) - (dst ,dst) - (dst-start (* ,dst-start sb!vm:byte-bits)) - (dst-end (* ,dst-end sb!vm:byte-bits))) - (let ((length (- dst-end dst-start))) - (etypecase src - (system-area-pointer - (etypecase dst - (system-area-pointer - (system-area-copy src src-start dst dst-start length)) - ((simple-unboxed-array (*)) - (copy-from-system-area src src-start - dst (+ dst-start ,vector-data-bit-offset) - length)))) - ((simple-unboxed-array (*)) - (etypecase dst - (system-area-pointer - (copy-to-system-area src (+ src-start ,vector-data-bit-offset) - dst dst-start - length)) - ((simple-unboxed-array (*)) - (bit-bash-copy src (+ src-start ,vector-data-bit-offset) - dst (+ dst-start ,vector-data-bit-offset) - length)))))))) +;;; FIXME: The old CMU CL code used various COPY-TO/FROM-SYSTEM-AREA +;;; stuff (with all the associated bit-index cruft and overflow +;;; issues) even for byte moves. In SBCL, we're converting to byte +;;; moves as problems are discovered with the old code, and this is +;;; currently (ca. sbcl-0.6.12.30) the main interface for code in +;;; SB!KERNEL and SB!SYS (e.g. i/o code). It's not clear that it's the +;;; ideal interface, though, and it probably deserves some thought. +(deftransform %byte-blt ((src src-start dst dst-start dst-end) + ((or (simple-unboxed-array (*)) system-area-pointer) + index + (or (simple-unboxed-array (*)) system-area-pointer) + index + index)) + ;; FIXME: CMU CL had a hairier implementation of this (back when it + ;; was still called (%PRIMITIVE BYTE-BLT). It had the small problem + ;; that it didn't work for large (>16M) values of SRC-START or + ;; DST-START. However, it might have been more efficient. In + ;; particular, I don't really know how much the foreign function + ;; call costs us here. My guess is that if the overhead is + ;; acceptable for SQRT and COS, it's acceptable here, but this + ;; should probably be checked. -- WHN + '(flet ((sapify (thing) + (etypecase thing + (system-area-pointer thing) + ;; FIXME: The code here rather relies on the simple + ;; unboxed array here having byte-sized entries. That + ;; should be asserted explicitly, I just haven't found + ;; a concise way of doing it. (It would be nice to + ;; declare it in the DEFKNOWN too.) + ((simple-unboxed-array (*)) (vector-sap thing))))) + (declare (inline sapify)) + (without-gcing + (memmove (sap+ (sapify dst) dst-start) + (sap+ (sapify src) src-start) + (- dst-end dst-start))) + nil)) ;;;; transforms for EQL of floating point values