X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fcompiler%2Fx86-64%2Fmove.lisp;h=f10a953a9da4147c2d62354b9ccd886f4e1e487a;hb=a189a69454ef7635149319ae213b337f17c50d20;hp=cc0a777b938efd88032dd1c1accee69a61130767;hpb=c50747a96774ec8164ead5e51d74a6d8bcf6e822;p=sbcl.git diff --git a/src/compiler/x86-64/move.lisp b/src/compiler/x86-64/move.lisp index cc0a777..f10a953 100644 --- a/src/compiler/x86-64/move.lisp +++ b/src/compiler/x86-64/move.lisp @@ -103,9 +103,7 @@ (let ((val (tn-value x))) (etypecase val (integer - (if (and (zerop val) (sc-is y any-reg descriptor-reg)) - (zeroize y) - (move-immediate y (fixnumize val) temp))) + (move-immediate y (fixnumize val) temp)) (symbol (inst mov y (+ nil-value (static-symbol-offset val)))) (character @@ -127,7 +125,9 @@ ;; If target is a register, we can just mov it there directly ((and (tn-p target) (sc-is target signed-reg unsigned-reg descriptor-reg any-reg)) - (inst mov target val)) + (if (zerop val) + (zeroize target) + (inst mov target val))) ;; Likewise if the value is small enough. ((typep val '(signed-byte 32)) (inst mov target val)) @@ -256,26 +256,50 @@ ;;; Arg is a fixnum or bignum, figure out which and load if necessary. +#-#.(cl:if (cl:= sb!vm:n-fixnum-tag-bits 1) '(:and) '(:or)) (define-vop (move-to-word/integer) - (:args (x :scs (descriptor-reg) :target eax)) + (:args (x :scs (descriptor-reg) :target rax)) (:results (y :scs (signed-reg unsigned-reg))) (:note "integer to untagged word coercion") - (:temporary (:sc unsigned-reg :offset eax-offset - :from (:argument 0) :to (:result 0) :target y) eax) + ;; I'm not convinced that increasing the demand for rAX is + ;; better than adding 1 byte to some instruction encodings. + ;; I'll leave it alone though. + (:temporary (:sc unsigned-reg :offset rax-offset + :from (:argument 0) :to (:result 0) :target y) rax) (:generator 4 - (move eax x) + (move rax x) (inst test al-tn fixnum-tag-mask) (inst jmp :z FIXNUM) - (loadw y eax bignum-digits-offset other-pointer-lowtag) + (loadw y rax bignum-digits-offset other-pointer-lowtag) (inst jmp DONE) FIXNUM - (inst sar eax n-fixnum-tag-bits) - (move y eax) + (inst sar rax n-fixnum-tag-bits) + (move y rax) + DONE)) + +#+#.(cl:if (cl:= sb!vm:n-fixnum-tag-bits 1) '(:and) '(:or)) +(define-vop (move-to-word/integer) + (:args (x :scs (descriptor-reg) :target y)) + (:results (y :scs (signed-reg unsigned-reg))) + (:note "integer to untagged word coercion") + (:temporary (:sc unsigned-reg) backup) + (:generator 4 + (move y x) + (if (location= x y) + ;; It would be great if a principled way existed to advise GC of + ;; algebraic transforms such as 2*R being a conservative root. + ;; Until that is possible, emit straightforward code that uses + ;; a copy of the potential reference. + (move backup x) + (setf backup x)) + (inst sar y 1) ; optimistically assume it's a fixnum + (inst jmp :nc DONE) ; no carry implies tag was 0 + (loadw y backup bignum-digits-offset other-pointer-lowtag) DONE)) + (define-move-vop move-to-word/integer :move (descriptor-reg) (signed-reg unsigned-reg)) - ;;; Result is a fixnum, so we can just shift. We need the result type ;;; restriction because of the control-stack ambiguity noted above. (define-vop (move-from-word/fixnum) @@ -303,35 +327,43 @@ ;;; as the case may be. Fixnum case inline, bignum case in an assembly ;;; routine. (define-vop (move-from-signed) - (:args (x :scs (signed-reg unsigned-reg) :to :result)) - (:results (y :scs (any-reg descriptor-reg) :from :argument)) + (:args (x :scs (signed-reg unsigned-reg) :to :result . #.(and (= 1 n-fixnum-tag-bits) + '(:target y)))) + (:results (y :scs (any-reg descriptor-reg) . #.(and (> n-fixnum-tag-bits 1) + '(:from :argument)))) (:note "signed word to integer coercion") ;; Worst case cost to make sure people know they may be number consing. (:generator 20 - (aver (not (location= x y))) - (let ((done (gen-label))) - (inst imul y x #.(ash 1 n-fixnum-tag-bits)) - (inst jmp :no done) - (inst mov y x) - (inst lea temp-reg-tn - (make-ea :qword :disp - (make-fixup (ecase (tn-offset y) - (#.rax-offset 'alloc-signed-bignum-in-rax) - (#.rcx-offset 'alloc-signed-bignum-in-rcx) - (#.rdx-offset 'alloc-signed-bignum-in-rdx) - (#.rbx-offset 'alloc-signed-bignum-in-rbx) - (#.rsi-offset 'alloc-signed-bignum-in-rsi) - (#.rdi-offset 'alloc-signed-bignum-in-rdi) - (#.r8-offset 'alloc-signed-bignum-in-r8) - (#.r9-offset 'alloc-signed-bignum-in-r9) - (#.r10-offset 'alloc-signed-bignum-in-r10) - (#.r12-offset 'alloc-signed-bignum-in-r12) - (#.r13-offset 'alloc-signed-bignum-in-r13) - (#.r14-offset 'alloc-signed-bignum-in-r14) - (#.r15-offset 'alloc-signed-bignum-in-r15)) - :assembly-routine))) - (inst call temp-reg-tn) - (emit-label done)))) + (cond ((= 1 n-fixnum-tag-bits) + (move y x) + (inst shl y 1) + (inst jmp :no DONE) + (if (location= y x) + (inst rcr y 1) ; we're about to cons a bignum. this RCR is noise + (inst mov y x))) + (t + (aver (not (location= x y))) + (inst imul y x #.(ash 1 n-fixnum-tag-bits)) + (inst jmp :no DONE) + (inst mov y x))) + (inst mov temp-reg-tn + (make-fixup (ecase (tn-offset y) + (#.rax-offset 'alloc-signed-bignum-in-rax) + (#.rcx-offset 'alloc-signed-bignum-in-rcx) + (#.rdx-offset 'alloc-signed-bignum-in-rdx) + (#.rbx-offset 'alloc-signed-bignum-in-rbx) + (#.rsi-offset 'alloc-signed-bignum-in-rsi) + (#.rdi-offset 'alloc-signed-bignum-in-rdi) + (#.r8-offset 'alloc-signed-bignum-in-r8) + (#.r9-offset 'alloc-signed-bignum-in-r9) + (#.r10-offset 'alloc-signed-bignum-in-r10) + (#.r12-offset 'alloc-signed-bignum-in-r12) + (#.r13-offset 'alloc-signed-bignum-in-r13) + (#.r14-offset 'alloc-signed-bignum-in-r14) + (#.r15-offset 'alloc-signed-bignum-in-r15)) + :assembly-routine)) + (inst call temp-reg-tn) + DONE)) (define-move-vop move-from-signed :move (signed-reg) (descriptor-reg)) @@ -362,23 +394,22 @@ :scale (ash 1 n-fixnum-tag-bits)))) (inst jmp :z done) (inst mov y x) - (inst lea temp-reg-tn - (make-ea :qword :disp - (make-fixup (ecase (tn-offset y) - (#.rax-offset 'alloc-unsigned-bignum-in-rax) - (#.rcx-offset 'alloc-unsigned-bignum-in-rcx) - (#.rdx-offset 'alloc-unsigned-bignum-in-rdx) - (#.rbx-offset 'alloc-unsigned-bignum-in-rbx) - (#.rsi-offset 'alloc-unsigned-bignum-in-rsi) - (#.rdi-offset 'alloc-unsigned-bignum-in-rdi) - (#.r8-offset 'alloc-unsigned-bignum-in-r8) - (#.r9-offset 'alloc-unsigned-bignum-in-r9) - (#.r10-offset 'alloc-unsigned-bignum-in-r10) - (#.r12-offset 'alloc-unsigned-bignum-in-r12) - (#.r13-offset 'alloc-unsigned-bignum-in-r13) - (#.r14-offset 'alloc-unsigned-bignum-in-r14) - (#.r15-offset 'alloc-unsigned-bignum-in-r15)) - :assembly-routine))) + (inst mov temp-reg-tn + (make-fixup (ecase (tn-offset y) + (#.rax-offset 'alloc-unsigned-bignum-in-rax) + (#.rcx-offset 'alloc-unsigned-bignum-in-rcx) + (#.rdx-offset 'alloc-unsigned-bignum-in-rdx) + (#.rbx-offset 'alloc-unsigned-bignum-in-rbx) + (#.rsi-offset 'alloc-unsigned-bignum-in-rsi) + (#.rdi-offset 'alloc-unsigned-bignum-in-rdi) + (#.r8-offset 'alloc-unsigned-bignum-in-r8) + (#.r9-offset 'alloc-unsigned-bignum-in-r9) + (#.r10-offset 'alloc-unsigned-bignum-in-r10) + (#.r12-offset 'alloc-unsigned-bignum-in-r12) + (#.r13-offset 'alloc-unsigned-bignum-in-r13) + (#.r14-offset 'alloc-unsigned-bignum-in-r14) + (#.r15-offset 'alloc-unsigned-bignum-in-r15)) + :assembly-routine)) (inst call temp-reg-tn) (emit-label done)))) (define-move-vop move-from-unsigned :move