X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fpcl%2Fslots.lisp;h=6d82bcd22b2f567d0c22979a4d30a82a8fd2f42e;hb=cbaa1997bb097a55d108df592ac3b7eb4a703fff;hp=ac09ca0fd3ba00a396c55242106a586155e3c3fa;hpb=2716573f357f204c5f546d1d34d285dd24ff43a1;p=sbcl.git diff --git a/src/pcl/slots.lisp b/src/pcl/slots.lisp index ac09ca0..6d82bcd 100644 --- a/src/pcl/slots.lisp +++ b/src/pcl/slots.lisp @@ -29,7 +29,7 @@ ((instance :reader unbound-slot-instance :initarg :instance) (slot :reader unbound-slot-slot :initarg :slot)) (:report (lambda(condition stream) - (format stream "The slot ~S is unbound in the object ~S" + (format stream "The slot ~S is unbound in the object ~S." (unbound-slot-slot condition) (unbound-slot-instance condition))))) @@ -58,7 +58,7 @@ (error "unrecognized instance type")))) (defun swap-wrappers-and-slots (i1 i2) - (without-interrupts + (sb-sys:without-interrupts (cond ((std-instance-p i1) (let ((w1 (std-instance-wrapper i1)) (s1 (std-instance-slots i1))) @@ -129,13 +129,15 @@ (let* ((class (class-of object)) (slot-definition (find-slot-definition class slot-name))) (if (null slot-definition) - (slot-missing class object slot-name 'setf) + (slot-missing class object slot-name 'setf new-value) (setf (slot-value-using-class class object slot-definition) new-value)))) (setf (gdefinition 'set-slot-value-normal) #'set-slot-value) -(define-compiler-macro set-slot-value (object-form slot-name-form new-value-form) +(define-compiler-macro set-slot-value (object-form + slot-name-form + new-value-form) (if (and (constantp slot-name-form) (let ((slot-name (eval slot-name-form))) (and (symbolp slot-name) (symbol-package slot-name)))) @@ -179,10 +181,10 @@ default)) (defun standard-instance-access (instance location) - (%instance-ref (std-instance-slots instance) location)) + (clos-slots-ref (std-instance-slots instance) location)) (defun funcallable-standard-instance-access (instance location) - (%instance-ref (fsc-instance-slots instance) location)) + (clos-slots-ref (fsc-instance-slots instance) location)) (defmethod slot-value-using-class ((class std-class) (object std-object) @@ -193,19 +195,24 @@ (cond ((std-instance-p object) ;; FIXME: EQ T (WRAPPER-STATE ..) is better done ;; through INVALID-WRAPPER-P (here and below). - (unless (eq 't (wrapper-state (std-instance-wrapper object))) + (unless (eq t (wrapper-state (std-instance-wrapper + object))) (check-wrapper-validity object)) - (%instance-ref (std-instance-slots object) location)) + (clos-slots-ref (std-instance-slots object) + location)) ((fsc-instance-p object) - (unless (eq 't (wrapper-state (fsc-instance-wrapper object))) + (unless (eq t (wrapper-state (fsc-instance-wrapper + object))) (check-wrapper-validity object)) - (%instance-ref (fsc-instance-slots object) location)) + (clos-slots-ref (fsc-instance-slots object) + location)) (t (error "unrecognized instance type")))) (cons (cdr location)) (t - (error "The slot ~S has neither :INSTANCE nor :CLASS allocation, ~@ - so it can't be read by the default ~S method." + (error "~@" slotd 'slot-value-using-class))))) (if (eq value +slot-unbound+) (slot-unbound class object (slot-definition-name slotd)) @@ -219,19 +226,21 @@ (typecase location (fixnum (cond ((std-instance-p object) - (unless (eq 't (wrapper-state (std-instance-wrapper object))) + (unless (eq t (wrapper-state (std-instance-wrapper object))) (check-wrapper-validity object)) - (setf (%instance-ref (std-instance-slots object) location) new-value)) + (setf (clos-slots-ref (std-instance-slots object) location) + new-value)) ((fsc-instance-p object) - (unless (eq 't (wrapper-state (fsc-instance-wrapper object))) + (unless (eq t (wrapper-state (fsc-instance-wrapper object))) (check-wrapper-validity object)) - (setf (%instance-ref (fsc-instance-slots object) location) new-value)) + (setf (clos-slots-ref (fsc-instance-slots object) location) + new-value)) (t (error "unrecognized instance type")))) (cons (setf (cdr location) new-value)) (t - (error "The slot ~S has neither :INSTANCE nor :CLASS allocation, ~@ - so it can't be written by the default ~S method." + (error "~@" slotd '(setf slot-value-using-class)))))) (defmethod slot-boundp-using-class @@ -242,19 +251,24 @@ (value (typecase location (fixnum (cond ((std-instance-p object) - (unless (eq 't (wrapper-state (std-instance-wrapper object))) + (unless (eq t (wrapper-state (std-instance-wrapper + object))) (check-wrapper-validity object)) - (%instance-ref (std-instance-slots object) location)) + (clos-slots-ref (std-instance-slots object) + location)) ((fsc-instance-p object) - (unless (eq 't (wrapper-state (fsc-instance-wrapper object))) + (unless (eq t (wrapper-state (fsc-instance-wrapper + object))) (check-wrapper-validity object)) - (%instance-ref (fsc-instance-slots object) location)) + (clos-slots-ref (fsc-instance-slots object) + location)) (t (error "unrecognized instance type")))) (cons (cdr location)) (t - (error "The slot ~S has neither :INSTANCE nor :CLASS allocation, ~@ - so it can't be read by the default ~S method." + (error "~@" slotd 'slot-boundp-using-class))))) (not (eq value +slot-unbound+)))) @@ -266,21 +280,21 @@ (typecase location (fixnum (cond ((std-instance-p object) - (unless (eq 't (wrapper-state (std-instance-wrapper object))) + (unless (eq t (wrapper-state (std-instance-wrapper object))) (check-wrapper-validity object)) - (setf (%instance-ref (std-instance-slots object) location) - +slot-unbound+)) + (setf (clos-slots-ref (std-instance-slots object) location) + +slot-unbound+)) ((fsc-instance-p object) - (unless (eq 't (wrapper-state (fsc-instance-wrapper object))) + (unless (eq t (wrapper-state (fsc-instance-wrapper object))) (check-wrapper-validity object)) - (setf (%instance-ref (fsc-instance-slots object) location) - +slot-unbound+)) + (setf (clos-slots-ref (fsc-instance-slots object) location) + +slot-unbound+)) (t (error "unrecognized instance type")))) (cons (setf (cdr location) +slot-unbound+)) (t - (error "The slot ~S has neither :INSTANCE nor :CLASS allocation, ~@ - so it can't be written by the default ~S method." + (error "~@" slotd 'slot-makunbound-using-class)))) nil) @@ -317,14 +331,15 @@ (defmethod slot-missing ((class t) instance slot-name operation &optional new-value) - (error "When attempting to ~A,~%the slot ~S is missing from the object ~S." + (error "~@" (ecase operation (slot-value "read the slot's value (slot-value)") (setf (format nil - "set the slot's value to ~S (setf of slot-value)" + "set the slot's value to ~S (SETF of SLOT-VALUE)" new-value)) - (slot-boundp "test to see whether slot is bound (slot-boundp)") - (slot-makunbound "make the slot unbound (slot-makunbound)")) + (slot-boundp "test to see whether slot is bound (SLOT-BOUNDP)") + (slot-makunbound "make the slot unbound (SLOT-MAKUNBOUND)")) slot-name instance))