X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fruntime%2Fbreakpoint.c;h=e45082f8c1a3224627e3a522eb08dc9c79002299;hb=94ac5b7c3ff37850210b6fc9a7593cf1c5752993;hp=903591a0e9bad804f704329c5f8552e65815932f;hpb=cea4896b2482b7b2b429c1631d774b4cfbc0efba;p=sbcl.git diff --git a/src/runtime/breakpoint.c b/src/runtime/breakpoint.c index 903591a..e45082f 100644 --- a/src/runtime/breakpoint.c +++ b/src/runtime/breakpoint.c @@ -35,7 +35,7 @@ static void *compute_pc(lispobj code_obj, int pc_offset) { struct code *code; - code = (struct code *)PTR(code_obj); + code = (struct code *)native_pointer(code_obj); return (void *)((char *)code + HeaderValue(code->header)*sizeof(lispobj) + pc_offset); } @@ -54,7 +54,15 @@ void breakpoint_remove(lispobj code_obj, int pc_offset, void breakpoint_do_displaced_inst(os_context_t* context, unsigned long orig_inst) { -#if !defined(hpux) && !defined(irix) && !defined(__i386__) + /* on platforms with sigreturn(), we go directly back from + * arch_do_displaced_inst() to lisp code, so we need to clean up + * our bindings now. (side note: I'd love to know in exactly what + * scenario the speed of breakpoint handling is critical enough to + * justify this maintenance mess) + * + * -dan 2001.08.09 */ + +#if (defined(sparc) && defined (solaris)) undo_fake_foreign_function_call(context); #endif arch_do_displaced_inst(context, orig_inst); @@ -67,12 +75,12 @@ static lispobj find_code(os_context_t *context) lispobj code = *os_context_register_addr(context, reg_CODE); lispobj header; - if (LowtagOf(code) != type_OtherPointer) + if (lowtag_of(code) != OTHER_POINTER_LOWTAG) return NIL; - header = *(lispobj *)(code-type_OtherPointer); + header = *(lispobj *)(code-OTHER_POINTER_LOWTAG); - if (TypeOf(header) == type_CodeHeader) + if (widetag_of(header) == CODE_HEADER_WIDETAG) return code; else return code - HeaderValue(header)*sizeof(lispobj); @@ -85,13 +93,14 @@ static lispobj find_code(os_context_t *context) #ifdef __i386__ static lispobj find_code(os_context_t *context) { - lispobj codeptr = component_ptr_from_pc(*os_context_pc_addr(context)); + lispobj codeptr = + (lispobj)component_ptr_from_pc((lispobj *)(*os_context_pc_addr(context))); - if (codeptr == 0) { - return NIL; - } else { - return codeptr + type_OtherPointer; - } + if (codeptr == 0) { + return NIL; + } else { + return codeptr + OTHER_POINTER_LOWTAG; + } } #endif @@ -101,7 +110,7 @@ static int compute_offset(os_context_t *context, lispobj code) return 0; else { unsigned long code_start; - struct code *codeptr = (struct code *)PTR(code); + struct code *codeptr = (struct code *)native_pointer(code); #ifdef parisc unsigned long pc = *os_context_pc_addr(context) & ~3; #else @@ -121,7 +130,10 @@ static int compute_offset(os_context_t *context, lispobj code) } } } - +/* FIXME: I can see no really good reason these couldn't be merged, but haven't + * tried. The sigprocmask() call would work just as well on alpha as it + * presumably does on x86 -dan 2001.08.10 + */ #ifndef __i386__ void handle_breakpoint(int signal, siginfo_t *info, os_context_t *context) { @@ -161,8 +173,8 @@ void handle_breakpoint(int signal, siginfo_t* info, os_context_t *context) #endif #ifndef __i386__ -void *handle_function_end_breakpoint(int signal, siginfo_t *info, - os_context_t *context) +void *handle_fun_end_breakpoint(int signal, siginfo_t *info, + os_context_t *context) { lispobj code, lra; struct code *codeptr; @@ -170,7 +182,7 @@ void *handle_function_end_breakpoint(int signal, siginfo_t *info, fake_foreign_function_call(context); code = find_code(context); - codeptr = (struct code *)PTR(code); + codeptr = (struct code *)native_pointer(code); funcall3(SymbolFunction(HANDLE_BREAKPOINT), compute_offset(context, code), @@ -184,11 +196,11 @@ void *handle_function_end_breakpoint(int signal, siginfo_t *info, } #endif undo_fake_foreign_function_call(context); - return (void *)(lra-type_OtherPointer+sizeof(lispobj)); + return (void *)(lra-OTHER_POINTER_LOWTAG+sizeof(lispobj)); } #else -void *handle_function_end_breakpoint(int signal, siginfo_t *info, - os_context_t *context) +void *handle_fun_end_breakpoint(int signal, siginfo_t *info, + os_context_t *context) { lispobj code, context_sap = alloc_sap(context); struct code *codeptr; @@ -196,7 +208,7 @@ void *handle_function_end_breakpoint(int signal, siginfo_t *info, fake_foreign_function_call(context); code = find_code(context); - codeptr = (struct code *)PTR(code); + codeptr = (struct code *)native_pointer(code); /* Don't disallow recursive breakpoint traps. Otherwise, we can't * use debugger breakpoints anywhere in here. */