X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fruntime%2Fthread.c;h=9871f9fbf6f8edca3831ebf543b99a6e946375a8;hb=17dc30054799dab20bdab6da296ad6083cdaecd6;hp=c6d2ad59a32b33e89ff4ea55e3240f946085c7bc;hpb=c580293e8550414004697173f7e2c2b6bdf81070;p=sbcl.git diff --git a/src/runtime/thread.c b/src/runtime/thread.c index c6d2ad5..9871f9f 100644 --- a/src/runtime/thread.c +++ b/src/runtime/thread.c @@ -1,14 +1,36 @@ +/* + * This software is part of the SBCL system. See the README file for + * more information. + * + * This software is derived from the CMU CL system, which was + * written at Carnegie Mellon University and released into the + * public domain. The software is in the public domain and is + * provided with absolutely no warranty. See the COPYING and CREDITS + * files for more information. + */ + +#include "sbcl.h" + #include #include #include +#ifndef LISP_FEATURE_WIN32 #include +#endif #include #include #include #include +#ifndef LISP_FEATURE_WIN32 #include +#endif + +#ifdef LISP_FEATURE_MACH_EXCEPTION_HANDLER +#include +#include +#include +#endif -#include "sbcl.h" #include "runtime.h" #include "validate.h" /* for CONTROL_STACK_SIZE etc */ #include "alloc.h" @@ -23,67 +45,58 @@ #include "interr.h" /* for lose() */ #include "gc-internal.h" +#ifdef LISP_FEATURE_WIN32 +/* + * Win32 doesn't have SIGSTKSZ, and we're not switching stacks anyway, + * so define it arbitrarily + */ +#define SIGSTKSZ 1024 +#endif + +#if defined(LISP_FEATURE_DARWIN) && defined(LISP_FEATURE_SB_THREAD) +#define QUEUE_FREEABLE_THREAD_STACKS +#define LOCK_CREATE_THREAD +#endif + +#ifdef LISP_FEATURE_FREEBSD +#define CREATE_CLEANUP_THREAD +#define LOCK_CREATE_THREAD +#endif + #define ALIEN_STACK_SIZE (1*1024*1024) /* 1Mb size chosen at random */ struct freeable_stack { +#ifdef QUEUE_FREEABLE_THREAD_STACKS + struct freeable_stack *next; +#endif os_thread_t os_thread; os_vm_address_t stack; }; + +#ifdef QUEUE_FREEABLE_THREAD_STACKS +static struct freeable_stack * volatile freeable_stack_queue = 0; +static int freeable_stack_count = 0; +pthread_mutex_t freeable_stack_lock = PTHREAD_MUTEX_INITIALIZER; +#else static struct freeable_stack * volatile freeable_stack = 0; +#endif int dynamic_values_bytes=4096*sizeof(lispobj); /* same for all threads */ struct thread * volatile all_threads; extern struct interrupt_data * global_interrupt_data; -extern int linux_no_threads_p; #ifdef LISP_FEATURE_SB_THREAD - pthread_mutex_t all_threads_lock = PTHREAD_MUTEX_INITIALIZER; - -/* When trying to get all_threads_lock one should make sure that - * SIG_STOP_FOR_GC is not blocked. Else there would be a possible - * deadlock: gc locks it, other thread blocks signals, gc sends stop - * request to other thread and waits, other thread blocks on lock. */ -void check_sig_stop_for_gc_can_arrive_or_lose() -{ - /* Get the current sigmask, by blocking the empty set. */ - sigset_t empty,current; - sigemptyset(&empty); - thread_sigmask(SIG_BLOCK, &empty, ¤t); - if (sigismember(¤t,SIG_STOP_FOR_GC)) - lose("SIG_STOP_FOR_GC cannot arrive: it is blocked\n"); - if (SymbolValue(GC_INHIBIT,arch_os_get_current_thread()) != NIL) - lose("SIG_STOP_FOR_GC cannot arrive: gc is inhibited\n"); - if (arch_pseudo_atomic_atomic(NULL)) - lose("SIG_STOP_FOR_GC cannot arrive: in pseudo atomic\n"); -} - -#define GET_ALL_THREADS_LOCK(name) \ - { \ - sigset_t _newset,_oldset; \ - sigemptyset(&_newset); \ - sigaddset_deferrable(&_newset); \ - thread_sigmask(SIG_BLOCK, &_newset, &_oldset); \ - check_sig_stop_for_gc_can_arrive_or_lose(); \ - FSHOW_SIGNAL((stderr,"/%s:waiting on lock=%ld, thread=%lu\n",name, \ - all_threads_lock,arch_os_get_current_thread()->os_thread)); \ - pthread_mutex_lock(&all_threads_lock); \ - FSHOW_SIGNAL((stderr,"/%s:got lock, thread=%lu\n", \ - name,arch_os_get_current_thread()->os_thread)); - -#define RELEASE_ALL_THREADS_LOCK(name) \ - FSHOW_SIGNAL((stderr,"/%s:released lock\n",name)); \ - pthread_mutex_unlock(&all_threads_lock); \ - thread_sigmask(SIG_SETMASK,&_oldset,0); \ - } +#ifdef LOCK_CREATE_THREAD +static pthread_mutex_t create_thread_lock = PTHREAD_MUTEX_INITIALIZER; +#endif +#endif #if defined(LISP_FEATURE_X86) || defined(LISP_FEATURE_X86_64) extern lispobj call_into_lisp_first_time(lispobj fun, lispobj *args, int nargs); #endif -#endif - static void link_thread(struct thread *th) { @@ -118,8 +131,9 @@ initial_thread_trampoline(struct thread *th) if(arch_os_thread_init(th)==0) return 1; link_thread(th); th->os_thread=thread_self(); +#ifndef LISP_FEATURE_WIN32 protect_control_stack_guard_page(1); - th->state = STATE_RUNNING; +#endif #if defined(LISP_FEATURE_X86) || defined(LISP_FEATURE_X86_64) return call_into_lisp_first_time(function,args,0); @@ -134,6 +148,100 @@ initial_thread_trampoline(struct thread *th) #ifdef LISP_FEATURE_SB_THREAD +#ifdef QUEUE_FREEABLE_THREAD_STACKS + +static void +queue_freeable_thread_stack(struct thread *thread_to_be_cleaned_up) +{ + if (thread_to_be_cleaned_up) { + pthread_mutex_lock(&freeable_stack_lock); + if (freeable_stack_queue) { + struct freeable_stack *new_freeable_stack = 0, *next; + next = freeable_stack_queue; + while (next->next) { + next = next->next; + } + new_freeable_stack = (struct freeable_stack *) + os_validate(0, sizeof(struct freeable_stack)); + new_freeable_stack->next = NULL; + new_freeable_stack->os_thread = thread_to_be_cleaned_up->os_thread; + new_freeable_stack->stack = (os_vm_address_t) + thread_to_be_cleaned_up->control_stack_start; + next->next = new_freeable_stack; + freeable_stack_count++; + } else { + struct freeable_stack *new_freeable_stack = 0; + new_freeable_stack = (struct freeable_stack *) + os_validate(0, sizeof(struct freeable_stack)); + new_freeable_stack->next = NULL; + new_freeable_stack->os_thread = thread_to_be_cleaned_up->os_thread; + new_freeable_stack->stack = (os_vm_address_t) + thread_to_be_cleaned_up->control_stack_start; + freeable_stack_queue = new_freeable_stack; + freeable_stack_count++; + } + pthread_mutex_unlock(&freeable_stack_lock); + } +} + +#define FREEABLE_STACK_QUEUE_SIZE 4 + +static void +free_freeable_stacks() { + if (freeable_stack_queue && (freeable_stack_count > FREEABLE_STACK_QUEUE_SIZE)) { + struct freeable_stack* old; + pthread_mutex_lock(&freeable_stack_lock); + old = freeable_stack_queue; + freeable_stack_queue = old->next; + freeable_stack_count--; + gc_assert(pthread_join(old->os_thread, NULL) == 0); + FSHOW((stderr, "freeing thread %x stack\n", old->os_thread)); + os_invalidate(old->stack, THREAD_STRUCT_SIZE); + os_invalidate((os_vm_address_t)old, sizeof(struct freeable_stack)); + pthread_mutex_unlock(&freeable_stack_lock); + } +} + +#elif defined(CREATE_CLEANUP_THREAD) +static void * +cleanup_thread(void *arg) +{ + struct freeable_stack *freeable = arg; + pthread_t self = pthread_self(); + + FSHOW((stderr, "/cleaner thread(%p): joining %p\n", + self, freeable->os_thread)); + gc_assert(pthread_join(freeable->os_thread, NULL) == 0); + FSHOW((stderr, "/cleaner thread(%p): free stack %p\n", + self, freeable->stack)); + os_invalidate(freeable->stack, THREAD_STRUCT_SIZE); + free(freeable); + + pthread_detach(self); + + return NULL; +} + +static void +create_cleanup_thread(struct thread *thread_to_be_cleaned_up) +{ + pthread_t thread; + int result; + + if (thread_to_be_cleaned_up) { + struct freeable_stack *freeable = + malloc(sizeof(struct freeable_stack)); + gc_assert(freeable != NULL); + freeable->os_thread = thread_to_be_cleaned_up->os_thread; + freeable->stack = + (os_vm_address_t) thread_to_be_cleaned_up->control_stack_start; + result = pthread_create(&thread, NULL, cleanup_thread, freeable); + gc_assert(result == 0); + sched_yield(); + } +} + +#else static void free_thread_stack_later(struct thread *thread_to_be_cleaned_up) { @@ -149,7 +257,7 @@ free_thread_stack_later(struct thread *thread_to_be_cleaned_up) swap_lispobjs((lispobj *)(void *)&freeable_stack, (lispobj)new_freeable_stack); if (new_freeable_stack) { - FSHOW((stderr,"/reaping %lu\n", new_freeable_stack->os_thread)); + FSHOW((stderr,"/reaping %p\n", (void*) new_freeable_stack->os_thread)); /* Under NPTL pthread_join really waits until the thread * exists and the stack can be safely freed. This is sadly not * mandated by the pthread spec. */ @@ -159,6 +267,7 @@ free_thread_stack_later(struct thread *thread_to_be_cleaned_up) sizeof(struct freeable_stack)); } } +#endif /* this is the first thing that runs in the child (which is why the * silly calling convention). Basically it calls the user's requested @@ -169,7 +278,8 @@ int new_thread_trampoline(struct thread *th) { lispobj function; - int result; + int result, lock_ret; + FSHOW((stderr,"/creating thread %lu\n", thread_self())); function = th->no_tls_value_marker; th->no_tls_value_marker = NO_TLS_VALUE_MARKER_WIDETAG; @@ -180,37 +290,56 @@ new_thread_trampoline(struct thread *th) th->os_thread=thread_self(); protect_control_stack_guard_page(1); - /* This thread is in STATE_STARTING so the GC is not sending it - * SIG_STOP_FOR_GC => no danger of deadlocking even with - * SIG_STOP_FOR_GC blocked. The lock is acquired in order not to - * enter running state with the gc running. */ - pthread_mutex_lock(&all_threads_lock); - th->state = STATE_RUNNING; - pthread_mutex_unlock(&all_threads_lock); - /* Now that we entered STATE_RUNNING let the gc suspend this - * thread. */ - { - sigset_t sigset; - sigemptyset(&sigset); - sigaddset(&sigset, SIG_STOP_FOR_GC); - thread_sigmask(SIG_UNBLOCK, &sigset, 0); - } + /* Since GC can only know about this thread from the all_threads + * list and we're just adding this thread to it there is no danger + * of deadlocking even with SIG_STOP_FOR_GC blocked (which it is + * not). */ + lock_ret = pthread_mutex_lock(&all_threads_lock); + gc_assert(lock_ret == 0); + link_thread(th); + lock_ret = pthread_mutex_unlock(&all_threads_lock); + gc_assert(lock_ret == 0); result = funcall0(function); + + /* Block GC */ + block_blockable_signals(); th->state=STATE_DEAD; /* SIG_STOP_FOR_GC is blocked and GC might be waiting for this * thread, but since we are already dead it won't wait long. */ - pthread_mutex_lock(&all_threads_lock); + lock_ret = pthread_mutex_lock(&all_threads_lock); + gc_assert(lock_ret == 0); + + gc_alloc_update_page_tables(0, &th->alloc_region); unlink_thread(th); pthread_mutex_unlock(&all_threads_lock); + gc_assert(lock_ret == 0); - gc_alloc_update_page_tables(0, &th->alloc_region); if(th->tls_cookie>=0) arch_os_thread_cleanup(th); os_invalidate((os_vm_address_t)th->interrupt_data, (sizeof (struct interrupt_data))); + +#ifdef LISP_FEATURE_MACH_EXCEPTION_HANDLER + FSHOW((stderr, "Deallocating mach port %x\n", THREAD_STRUCT_TO_EXCEPTION_PORT(th))); + mach_port_move_member(mach_task_self(), + THREAD_STRUCT_TO_EXCEPTION_PORT(th), + MACH_PORT_NULL); + mach_port_deallocate(mach_task_self(), + THREAD_STRUCT_TO_EXCEPTION_PORT(th)); + mach_port_destroy(mach_task_self(), + THREAD_STRUCT_TO_EXCEPTION_PORT(th)); +#endif + +#ifdef QUEUE_FREEABLE_THREAD_STACKS + queue_freeable_thread_stack(th); +#elif defined(CREATE_CLEANUP_THREAD) + create_cleanup_thread(th); +#else free_thread_stack_later(th); - FSHOW((stderr,"/exiting thread %lu\n", thread_self())); +#endif + + FSHOW((stderr,"/exiting thread %p\n", thread_self())); return result; } @@ -236,7 +365,14 @@ create_thread_struct(lispobj initial_function) { union per_thread_data *per_thread; struct thread *th=0; /* subdue gcc */ void *spaces=0; +#ifdef LISP_FEATURE_SB_THREAD + int i; +#endif +#ifdef CREATE_CLEANUP_THREAD + /* Give a chance for cleanup threads to run. */ + sched_yield(); +#endif /* may as well allocate all the spaces at once: it saves us from * having to decide what to do if only some of the allocations * succeed */ @@ -249,17 +385,14 @@ create_thread_struct(lispobj initial_function) { BINDING_STACK_SIZE+ ALIEN_STACK_SIZE); - if(all_threads) { - memcpy(per_thread,arch_os_get_current_thread(), - dynamic_values_bytes); - } else { #ifdef LISP_FEATURE_SB_THREAD - int i; - for(i=0;i<(dynamic_values_bytes/sizeof(lispobj));i++) - per_thread->dynamic_values[i]=NO_TLS_VALUE_MARKER_WIDETAG; + for(i = 0; i < (dynamic_values_bytes / sizeof(lispobj)); i++) + per_thread->dynamic_values[i] = NO_TLS_VALUE_MARKER_WIDETAG; + if (all_threads == 0) { if(SymbolValue(FREE_TLS_INDEX,0)==UNBOUND_MARKER_WIDETAG) { SetSymbolValue (FREE_TLS_INDEX, + /* FIXME: should be MAX_INTERRUPTS -1 ? */ make_fixnum(MAX_INTERRUPTS+ sizeof(struct thread)/sizeof(lispobj)), 0); @@ -275,12 +408,11 @@ create_thread_struct(lispobj initial_function) { STATIC_TLS_INIT(CONTROL_STACK_END,control_stack_end); STATIC_TLS_INIT(ALIEN_STACK,alien_stack_pointer); #if defined(LISP_FEATURE_X86) || defined (LISP_FEATURE_X86_64) - STATIC_TLS_INIT(PSEUDO_ATOMIC_ATOMIC,pseudo_atomic_atomic); - STATIC_TLS_INIT(PSEUDO_ATOMIC_INTERRUPTED,pseudo_atomic_interrupted); + STATIC_TLS_INIT(PSEUDO_ATOMIC_BITS,pseudo_atomic_bits); #endif #undef STATIC_TLS_INIT -#endif } +#endif th=&per_thread->thread; th->control_stack_start = spaces; @@ -292,7 +424,7 @@ create_thread_struct(lispobj initial_function) { th->binding_stack_pointer=th->binding_stack_start; th->this=th; th->os_thread=0; - th->state=STATE_STARTING; + th->state=STATE_RUNNING; #ifdef LISP_FEATURE_STACK_GROWS_DOWNWARD_NOT_UPWARD th->alien_stack_pointer=((void *)th->alien_stack_start + ALIEN_STACK_SIZE-N_WORD_BYTES); @@ -300,8 +432,7 @@ create_thread_struct(lispobj initial_function) { th->alien_stack_pointer=((void *)th->alien_stack_start); #endif #if defined(LISP_FEATURE_X86) || defined (LISP_FEATURE_X86_64) - th->pseudo_atomic_interrupted=0; - th->pseudo_atomic_atomic=0; + th->pseudo_atomic_bits=0; #endif #ifdef LISP_FEATURE_GENCGC gc_set_region_empty(&th->alloc_region); @@ -320,8 +451,7 @@ create_thread_struct(lispobj initial_function) { #if defined(LISP_FEATURE_X86) || defined (LISP_FEATURE_X86_64) SetSymbolValue(BINDING_STACK_POINTER,(lispobj)th->binding_stack_pointer,th); SetSymbolValue(ALIEN_STACK,(lispobj)th->alien_stack_pointer,th); - SetSymbolValue(PSEUDO_ATOMIC_ATOMIC,(lispobj)th->pseudo_atomic_atomic,th); - SetSymbolValue(PSEUDO_ATOMIC_INTERRUPTED,th->pseudo_atomic_interrupted,th); + SetSymbolValue(PSEUDO_ATOMIC_BITS,(lispobj)th->pseudo_atomic_bits,th); #else current_binding_stack_pointer=th->binding_stack_pointer; current_control_stack_pointer=th->control_stack_start; @@ -345,14 +475,27 @@ create_thread_struct(lispobj initial_function) { } th->interrupt_data->pending_handler = 0; th->no_tls_value_marker=initial_function; + + th->stepping = NIL; return th; } +#ifdef LISP_FEATURE_MACH_EXCEPTION_HANDLER +mach_port_t setup_mach_exception_handling_thread(); +kern_return_t mach_thread_init(mach_port_t thread_exception_port); + +#endif + void create_initial_thread(lispobj initial_function) { struct thread *th=create_thread_struct(initial_function); if(th) { +#ifdef LISP_FEATURE_MACH_EXCEPTION_HANDLER + kern_return_t ret; + + setup_mach_exception_handling_thread(); +#endif initial_thread_trampoline(th); /* no return */ - } else lose("can't create initial thread"); + } else lose("can't create initial thread\n"); } #ifdef LISP_FEATURE_SB_THREAD @@ -369,17 +512,54 @@ boolean create_os_thread(struct thread *th,os_thread_t *kid_tid) pthread_attr_t attr; sigset_t newset,oldset; boolean r=1; + int retcode, initcode, sizecode, addrcode; + + FSHOW_SIGNAL((stderr,"/create_os_thread: creating new thread\n")); + +#ifdef LOCK_CREATE_THREAD + retcode = pthread_mutex_lock(&create_thread_lock); + gc_assert(retcode == 0); + FSHOW_SIGNAL((stderr,"/create_os_thread: got lock\n")); +#endif sigemptyset(&newset); - sigaddset_blockable(&newset); + /* Blocking deferrable signals is enough, no need to block + * SIG_STOP_FOR_GC because the child process is not linked onto + * all_threads until it's ready. */ + sigaddset_deferrable(&newset); thread_sigmask(SIG_BLOCK, &newset, &oldset); - if((pthread_attr_init(&attr)) || +#if defined(LISP_FEATURE_DARWIN) +#define CONTROL_STACK_ADJUST 8192 /* darwin wants page-aligned stacks */ +#else +#define CONTROL_STACK_ADJUST 16 +#endif + + if((initcode = pthread_attr_init(&attr)) || + /* FIXME: why do we even have this in the first place? */ (pthread_attr_setstack(&attr,th->control_stack_start, - THREAD_CONTROL_STACK_SIZE-16)) || - (pthread_create - (kid_tid,&attr,(void *(*)(void *))new_thread_trampoline,th))) + THREAD_CONTROL_STACK_SIZE-CONTROL_STACK_ADJUST)) || +#undef CONTROL_STACK_ADJUST + (retcode = pthread_create + (kid_tid,&attr,(void *(*)(void *))new_thread_trampoline,th))) { + FSHOW_SIGNAL((stderr, "init, size, addr = %d, %d, %d\n", initcode, sizecode, addrcode)); + FSHOW_SIGNAL((stderr, printf("pthread_create returned %d, errno %d\n", retcode, errno))); + FSHOW_SIGNAL((stderr, "wanted stack size %d, min stack size %d\n", + THREAD_CONTROL_STACK_SIZE-16, PTHREAD_STACK_MIN)); + if(retcode < 0) { + perror("create_os_thread"); + } r=0; + } + +#ifdef QUEUE_FREEABLE_THREAD_STACKS + free_freeable_stacks(); +#endif thread_sigmask(SIG_SETMASK,&oldset,0); +#ifdef LOCK_CREATE_THREAD + retcode = pthread_mutex_unlock(&create_thread_lock); + gc_assert(retcode == 0); + FSHOW_SIGNAL((stderr,"/create_os_thread: released lock\n")); +#endif return r; } @@ -387,25 +567,16 @@ os_thread_t create_thread(lispobj initial_function) { struct thread *th; os_thread_t kid_tid; - if(linux_no_threads_p) return 0; - - /* The new thread must be linked immediately onto all_threads for - * gc. */ - GET_ALL_THREADS_LOCK("create_thread") - /* If it is too slow most of the allocation/initialization can - * be done without the lock. */ + /* Assuming that a fresh thread struct has no lisp objects in it, + * linking it to all_threads can be left to the thread itself + * without fear of gc lossage. initial_function violates this + * assumption and must stay pinned until the child starts up. */ th = create_thread_struct(initial_function); - if (th) - link_thread(th); - RELEASE_ALL_THREADS_LOCK("create_thread") if(th==0) return 0; if (create_os_thread(th,&kid_tid)) { return kid_tid; } else { - GET_ALL_THREADS_LOCK("create_thread") - unlink_thread(th); - RELEASE_ALL_THREADS_LOCK("create_thread") free_thread_struct(th); return 0; } @@ -413,7 +584,8 @@ os_thread_t create_thread(lispobj initial_function) { /* Send the signo to os_thread, retry if the rt signal queue is * full. */ -static int kill_thread_safely(os_thread_t os_thread, int signo) +int +kill_thread_safely(os_thread_t os_thread, int signo) { int r; /* The man page does not mention EAGAIN as a valid return value @@ -440,7 +612,7 @@ int signal_interrupt_thread(os_thread_t os_thread) } else if (status == ESRCH) { return -1; } else { - lose("cannot send SIG_INTERRUPT_THREAD to thread=%lu: %d, %s", + lose("cannot send SIG_INTERRUPT_THREAD to thread=%lu: %d, %s\n", os_thread, status, strerror(status)); } } @@ -457,24 +629,38 @@ int signal_interrupt_thread(os_thread_t os_thread) void gc_stop_the_world() { struct thread *p,*th=arch_os_get_current_thread(); - int status; + int status, lock_ret; +#ifdef LOCK_CREATE_THREAD + /* KLUDGE: Stopping the thread during pthread_create() causes deadlock + * on FreeBSD. */ + FSHOW_SIGNAL((stderr,"/gc_stop_the_world:waiting on create_thread_lock, thread=%lu\n", + th->os_thread)); + lock_ret = pthread_mutex_lock(&create_thread_lock); + gc_assert(lock_ret == 0); + FSHOW_SIGNAL((stderr,"/gc_stop_the_world:got create_thread_lock, thread=%lu\n", + th->os_thread)); +#endif FSHOW_SIGNAL((stderr,"/gc_stop_the_world:waiting on lock, thread=%lu\n", th->os_thread)); /* keep threads from starting while the world is stopped. */ - pthread_mutex_lock(&all_threads_lock); \ + lock_ret = pthread_mutex_lock(&all_threads_lock); \ + gc_assert(lock_ret == 0); + FSHOW_SIGNAL((stderr,"/gc_stop_the_world:got lock, thread=%lu\n", th->os_thread)); /* stop all other threads by sending them SIG_STOP_FOR_GC */ for(p=all_threads; p; p=p->next) { + gc_assert(p->os_thread != 0); + FSHOW_SIGNAL((stderr,"/gc_stop_the_world: p->state: %x\n", p->state)); if((p!=th) && ((p->state==STATE_RUNNING))) { - FSHOW_SIGNAL((stderr,"/gc_stop_the_world: suspending %lu\n", - p->os_thread)); + FSHOW_SIGNAL((stderr,"/gc_stop_the_world: suspending %x, os_thread %x\n", + p, p->os_thread)); status=kill_thread_safely(p->os_thread,SIG_STOP_FOR_GC); if (status==ESRCH) { /* This thread has exited. */ gc_assert(p->state==STATE_DEAD); } else if (status) { - lose("cannot send suspend thread=%lu: %d, %s", + lose("cannot send suspend thread=%lu: %d, %s\n", p->os_thread,status,strerror(status)); } } @@ -482,8 +668,8 @@ void gc_stop_the_world() FSHOW_SIGNAL((stderr,"/gc_stop_the_world:signals sent\n")); /* wait for the running threads to stop or finish */ for(p=all_threads;p;) { + FSHOW_SIGNAL((stderr,"/gc_stop_the_world: th: %p, p: %p\n", th, p)); if((p!=th) && (p->state==STATE_RUNNING)) { - gc_assert(p->os_thread!=0); sched_yield(); } else { p=p->next; @@ -495,15 +681,15 @@ void gc_stop_the_world() void gc_start_the_world() { struct thread *p,*th=arch_os_get_current_thread(); - int status; + int status, lock_ret; /* if a resumed thread creates a new thread before we're done with * this loop, the new thread will get consed on the front of * all_threads, but it won't have been stopped so won't need * restarting */ FSHOW_SIGNAL((stderr,"/gc_start_the_world:begin\n")); for(p=all_threads;p;p=p->next) { - if((p!=th) && (p->state!=STATE_STARTING) && (p->state!=STATE_DEAD)) { - gc_assert(p->os_thread!=0); + gc_assert(p->os_thread!=0); + if((p!=th) && (p->state!=STATE_DEAD)) { if(p->state!=STATE_SUSPENDED) { lose("gc_start_the_world: wrong thread state is %d\n", fixnum_value(p->state)); @@ -511,9 +697,14 @@ void gc_start_the_world() FSHOW_SIGNAL((stderr, "/gc_start_the_world: resuming %lu\n", p->os_thread)); p->state=STATE_RUNNING; + +#if defined(SIG_RESUME_FROM_GC) + status=kill_thread_safely(p->os_thread,SIG_RESUME_FROM_GC); +#else status=kill_thread_safely(p->os_thread,SIG_STOP_FOR_GC); +#endif if (status) { - lose("cannot resume thread=%lu: %d, %s", + lose("cannot resume thread=%lu: %d, %s\n", p->os_thread,status,strerror(status)); } } @@ -522,7 +713,14 @@ void gc_start_the_world() * SIG_STOP_FOR_GC wouldn't need to be a rt signal. That has some * performance implications, but does away with the 'rt signal * queue full' problem. */ - pthread_mutex_unlock(&all_threads_lock); \ + + lock_ret = pthread_mutex_unlock(&all_threads_lock); + gc_assert(lock_ret == 0); +#ifdef LOCK_CREATE_THREAD + lock_ret = pthread_mutex_unlock(&create_thread_lock); + gc_assert(lock_ret == 0); +#endif + FSHOW_SIGNAL((stderr,"/gc_start_the_world:end\n")); } #endif