X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fruntime%2Fx86-64-arch.h;h=81ac4b77a779cc8300cfbfbfe8bccc968944e126;hb=eac461c1f1ca91cfe282c779291d582ed6b336cb;hp=baa5b8dbb13601537594852c988a8de98afdb6c5;hpb=1cf1afff10cfc48a2f4a26fd4533531081602219;p=sbcl.git diff --git a/src/runtime/x86-64-arch.h b/src/runtime/x86-64-arch.h index baa5b8d..81ac4b7 100644 --- a/src/runtime/x86-64-arch.h +++ b/src/runtime/x86-64-arch.h @@ -9,6 +9,8 @@ #error genesis/config.h (or sbcl.h) must be included before this file #endif +#include "interr.h" /* for declaration of lose() */ + #define ARCH_HAS_STACK_POINTER /* FIXME: Do we also want @@ -16,10 +18,11 @@ * here? (The answer wasn't obvious to me when merging the * architecture-abstracting patches for CSR's SPARC port. -- WHN 2002-02-15) */ -#include "interr.h" +#define COMPILER_BARRIER \ + do { __asm__ __volatile__ ( "" : : : "memory"); } while (0) static inline void -get_spinlock(volatile lispobj *word,long value) +get_spinlock(volatile lispobj *word, unsigned long value) { #ifdef LISP_FEATURE_SB_THREAD u64 rax=0; @@ -27,13 +30,15 @@ get_spinlock(volatile lispobj *word,long value) lose("recursive get_spinlock: 0x%x,%ld\n",word,value); do { #if defined(LISP_FEATURE_DARWIN) - asm ("xor %0,%0\n\ + asm volatile + ("xor %0,%0\n\ lock/cmpxchg %1,%2" : "=a" (rax) : "r" (value), "m" (*word) : "memory", "cc"); #else - asm ("xor %0,%0\n\ + asm volatile + ("xor %0,%0\n\ lock cmpxchg %1,%2" : "=a" (rax) : "r" (value), "m" (*word) @@ -48,14 +53,18 @@ get_spinlock(volatile lispobj *word,long value) static inline void release_spinlock(volatile lispobj *word) { + /* See comment in RELEASE-SPINLOCK in target-thread.lisp. */ + COMPILER_BARRIER; *word=0; + COMPILER_BARRIER; } static inline lispobj swap_lispobjs(volatile lispobj *dest, lispobj value) { lispobj old_value; - asm ("lock xchg %0,(%1)" + asm volatile + ("lock xchg %0,(%1)" : "=r" (old_value) : "r" (dest), "0" (value) : "memory");