X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=src%2Fruntime%2Fx86-arch.c;h=5063c986d34e135620e765b6b6aed235f921a068;hb=dc5e3163fe667e2629c7769aa8cf2e501eeeefa6;hp=acf928039df1f1184e22381727cc9dc15fb26979;hpb=358cad8bdef5c670e1bbe94c430bd27544995433;p=sbcl.git diff --git a/src/runtime/x86-arch.c b/src/runtime/x86-arch.c index acf9280..5063c98 100644 --- a/src/runtime/x86-arch.c +++ b/src/runtime/x86-arch.c @@ -23,6 +23,7 @@ #include "interrupt.h" #include "interr.h" #include "breakpoint.h" +#include "monitor.h" #define BREAKPOINT_INST 0xcc /* INT3 */ @@ -84,7 +85,7 @@ void arch_skip_instruction(os_context_t *context) break; case trap_Breakpoint: /* not tested */ - case trap_FunctionEndBreakpoint: /* not tested */ + case trap_FunEndBreakpoint: /* not tested */ break; case trap_PendingInterrupt: @@ -216,6 +217,16 @@ sigtrap_handler(int signal, siginfo_t *info, void *void_context) current_control_stack_pointer = (lispobj *)*os_context_sp_addr(context); + /* FIXME: CMUCL puts the float control restoration code here. + Thus, it seems to me that single-stepping won't restore the + float control. Since SBCL currently doesn't support + single-stepping (as far as I can tell) this is somewhat moot, + but it might be worth either moving this code up or deleting + the single-stepping code entirely. -- CSR, 2002-07-15 */ +#ifdef LISP_FEATURE_LINUX + os_restore_fp_control(context); +#endif + /* On entry %eip points just after the INT3 byte and aims at the * 'kind' value (eg trap_Cerror). For error-trap and Cerror-trap a * number of bytes will follow, the first is the length of the byte @@ -248,10 +259,10 @@ sigtrap_handler(int signal, siginfo_t *info, void *void_context) handle_breakpoint(signal, info, context); break; - case trap_FunctionEndBreakpoint: + case trap_FunEndBreakpoint: (char*)(*os_context_pc_addr(context)) -= 1; *os_context_pc_addr(context) = - (int)handle_function_end_breakpoint(signal, info, context); + (int)handle_fun_end_breakpoint(signal, info, context); break; default: @@ -262,12 +273,31 @@ sigtrap_handler(int signal, siginfo_t *info, void *void_context) } } +static void +sigill_handler(int signal, siginfo_t *siginfo, void *void_context) { + os_context_t *context = (os_context_t*)void_context; + fake_foreign_function_call(context); + monitor_or_something(); +} + void arch_install_interrupt_handlers() { SHOW("entering arch_install_interrupt_handlers()"); - undoably_install_low_level_interrupt_handler(SIGILL , sigtrap_handler); + + /* Note: The old CMU CL code here used sigtrap_handler() to handle + * SIGILL as well as SIGTRAP. I couldn't see any reason to do + * things that way. So, I changed to separate handlers when + * debugging a problem on OpenBSD, where SBCL wasn't catching + * SIGILL properly, but was instead letting the process be + * terminated with an "Illegal instruction" output. If this change + * turns out to break something (maybe breakpoint handling on some + * OS I haven't tested on?) and we have to go back to the old CMU + * CL way, I hope there will at least be a comment to explain + * why.. -- WHN 2001-06-07 */ + undoably_install_low_level_interrupt_handler(SIGILL , sigill_handler); undoably_install_low_level_interrupt_handler(SIGTRAP, sigtrap_handler); + SHOW("returning from arch_install_interrupt_handlers()"); }