X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=tests%2Farith.pure.lisp;h=af1932cce05cf0b57279a17548088b4a95946708;hb=2230ea0c1765a95fd2aa0a8996b3555b93ba3745;hp=3cc17fa8484806b0ddbb1129bae171d36c4aeed3;hpb=5cc68148d1a5f9bacf4eb12e396b680d992fc2c2;p=sbcl.git diff --git a/tests/arith.pure.lisp b/tests/arith.pure.lisp index 3cc17fa..af1932c 100644 --- a/tests/arith.pure.lisp +++ b/tests/arith.pure.lisp @@ -6,7 +6,7 @@ ;;;; While most of SBCL is derived from the CMU CL system, the test ;;;; files (like this one) were written from scratch after the fork ;;;; from CMU CL. -;;;; +;;;; ;;;; This software is in the public domain and is provided with ;;;; absolutely no warranty. See the COPYING and CREDITS files for ;;;; more information. @@ -18,13 +18,13 @@ ;;; unlikely that anything with such fundamental arithmetic errors as ;;; these are going to get this far, it's probably worth checking. (macrolet ((test (op res1 res2) - `(progn - (assert (= (,op 4 2) ,res1)) - (assert (= (,op 2 4) ,res2)) - (assert (= (funcall (compile nil (lambda (x y) (,op x y))) 4 2) - ,res1)) - (assert (= (funcall (compile nil (lambda (x y) (,op x y))) 2 4) - ,res2))))) + `(progn + (assert (= (,op 4 2) ,res1)) + (assert (= (,op 2 4) ,res2)) + (assert (= (funcall (compile nil '(lambda (x y) (,op x y))) 4 2) + ,res1)) + (assert (= (funcall (compile nil '(lambda (x y) (,op x y))) 2 4) + ,res2))))) (test + 6 6) (test - 2 -2) (test * 8 8) @@ -108,21 +108,21 @@ ;;; checkins later, we'll have doubled the coverage. (dotimes (i 100) (let* ((x (random most-positive-fixnum)) - (x2 (* x 2)) - (x3 (* x 3))) + (x2 (* x 2)) + (x3 (* x 3))) (let ((fn (handler-bind ((sb-ext:compiler-note (lambda (c) (when (<= x3 most-positive-fixnum) (error c))))) - (compile nil - `(lambda (y) - (declare (optimize speed) (type (integer 0 3) y)) - (* y ,x)))))) + (compile nil + `(lambda (y) + (declare (optimize speed) (type (integer 0 3) y)) + (* y ,x)))))) (unless (and (= (funcall fn 0) 0) - (= (funcall fn 1) x) - (= (funcall fn 2) x2) - (= (funcall fn 3) x3)) - (error "bad results for ~D" x))))) + (= (funcall fn 1) x) + (= (funcall fn 2) x2) + (= (funcall fn 3) x3)) + (error "bad results for ~D" x))))) ;;; Bugs reported by Paul Dietz: @@ -141,21 +141,21 @@ ;;; x86 LEA bug: (assert (= (funcall - (compile nil '(lambda (x) (declare (bit x)) (+ x #xf0000000))) - 1) - #xf0000001)) + (compile nil '(lambda (x) (declare (bit x)) (+ x #xf0000000))) + 1) + #xf0000001)) ;;; LOGBITP on bignums: (dolist (x '(((1+ most-positive-fixnum) 1 nil) - ((1+ most-positive-fixnum) -1 t) - ((1+ most-positive-fixnum) (1+ most-positive-fixnum) nil) - ((1+ most-positive-fixnum) (1- most-negative-fixnum) t) - (1 (ash most-negative-fixnum 1) nil) - (#.(- sb-vm:n-word-bits sb-vm:n-lowtag-bits) most-negative-fixnum t) - (#.(1+ (- sb-vm:n-word-bits sb-vm:n-lowtag-bits)) (ash most-negative-fixnum 1) t) - (#.(+ 2 (- sb-vm:n-word-bits sb-vm:n-lowtag-bits)) (ash most-negative-fixnum 1) t) - (#.(+ sb-vm:n-word-bits 32) (ash most-negative-fixnum #.(+ 32 sb-vm:n-lowtag-bits 1)) nil) - (#.(+ sb-vm:n-word-bits 33) (ash most-negative-fixnum #.(+ 32 sb-vm:n-lowtag-bits 1)) t))) + ((1+ most-positive-fixnum) -1 t) + ((1+ most-positive-fixnum) (1+ most-positive-fixnum) nil) + ((1+ most-positive-fixnum) (1- most-negative-fixnum) t) + (1 (ash most-negative-fixnum 1) nil) + (#.(- sb-vm:n-word-bits sb-vm:n-lowtag-bits) most-negative-fixnum t) + (#.(1+ (- sb-vm:n-word-bits sb-vm:n-lowtag-bits)) (ash most-negative-fixnum 1) t) + (#.(+ 2 (- sb-vm:n-word-bits sb-vm:n-lowtag-bits)) (ash most-negative-fixnum 1) t) + (#.(+ sb-vm:n-word-bits 32) (ash most-negative-fixnum #.(+ 32 sb-vm:n-lowtag-bits 1)) nil) + (#.(+ sb-vm:n-word-bits 33) (ash most-negative-fixnum #.(+ 32 sb-vm:n-lowtag-bits 1)) t))) (destructuring-bind (index int result) x (assert (eq (eval `(logbitp ,index ,int)) result)))) @@ -169,8 +169,8 @@ ;;; type inference leading to an internal compiler error: (let ((f (compile nil '(lambda (x) - (declare (type fixnum x)) - (ldb (byte 0 0) x))))) + (declare (type fixnum x)) + (ldb (byte 0 0) x))))) (assert (= (funcall f 1) 0)) (assert (= (funcall f most-positive-fixnum) 0)) (assert (= (funcall f -1) 0))) @@ -214,10 +214,10 @@ ;;; Whoops. Too much optimization in division operators for 0 ;;; divisor. (macrolet ((frob (name) - `(let ((fn (compile nil '(lambda (x) - (declare (optimize speed) (fixnum x)) - (,name x 0))))) - (assert (raises-error? (funcall fn 1) division-by-zero))))) + `(let ((fn (compile nil '(lambda (x) + (declare (optimize speed) (fixnum x)) + (,name x 0))))) + (assert (raises-error? (funcall fn 1) division-by-zero))))) (frob mod) (frob truncate) (frob rem) @@ -229,31 +229,31 @@ ;; comparisons without rationalizing the floats still gives the right anwers ;; in the edge cases (had a fencepost error). (macrolet ((test (range type sign) - `(let (ints - floats - (start (- ,(find-symbol (format nil - "MOST-~A-EXACTLY-~A-FIXNUM" - sign type) - :sb-kernel) - ,range))) - (dotimes (i (1+ (* ,range 2))) - (let* ((x (+ start i)) - (y (coerce x ',type))) - (push x ints) - (push y floats))) - (dolist (i ints) - (dolist (f floats) - (dolist (op '(< <= = >= >)) - (unless (eq (funcall op i f) - (funcall op i (rationalize f))) - (error "(not (eq (~a ~a ~f) (~a ~a ~a)))~%" - op i f - op i (rationalize f))) - (unless (eq (funcall op f i) - (funcall op (rationalize f) i)) - (error "(not (eq (~a ~f ~a) (~a ~a ~a)))~%" - op f i - op (rationalize f) i)))))))) + `(let (ints + floats + (start (- ,(find-symbol (format nil + "MOST-~A-EXACTLY-~A-FIXNUM" + sign type) + :sb-kernel) + ,range))) + (dotimes (i (1+ (* ,range 2))) + (let* ((x (+ start i)) + (y (coerce x ',type))) + (push x ints) + (push y floats))) + (dolist (i ints) + (dolist (f floats) + (dolist (op '(< <= = >= >)) + (unless (eq (funcall op i f) + (funcall op i (rationalize f))) + (error "(not (eq (~a ~a ~f) (~a ~a ~a)))~%" + op i f + op i (rationalize f))) + (unless (eq (funcall op f i) + (funcall op (rationalize f) i)) + (error "(not (eq (~a ~f ~a) (~a ~a ~a)))~%" + op f i + op (rationalize f) i)))))))) (test 32 double-float negative) (test 32 double-float positive) (test 32 single-float negative) @@ -261,6 +261,101 @@ ;; x86-64 sign-extension bug found using pfdietz's random tester. (assert (= 286142502 - (funcall (lambda () - (declare (notinline logxor)) - (min (logxor 0 0 0 286142502)))))) + (funcall (lambda () + (declare (notinline logxor)) + (min (logxor 0 0 0 286142502)))))) + +;; Small bugs in LOGCOUNT can still allow SBCL to be built and thus go +;; unnoticed, so check more thoroughly here. +(with-test (:name :logcount) + (flet ((test (x n) + (unless (= (logcount x) n) + (error "logcount failure for ~a" x)))) + ;; Test with some patterns with well known number of ones/zeroes ... + (dotimes (i 128) + (let ((x (ash 1 i))) + (test x 1) + (test (- x) i) + (test (1- x) i))) + ;; ... and with some random integers of varying length. + (flet ((test-logcount (x) + (declare (type integer x)) + (do ((result 0 (1+ result)) + (x (if (minusp x) + (lognot x) + x) + (logand x (1- x)))) + ((zerop x) result)))) + (dotimes (i 200) + (let ((x (random (ash 1 i)))) + (test x (test-logcount x)) + (test (- x) (test-logcount (- x)))))))) + +;; 1.0 had a broken ATANH on win32 +(with-test (:name :atanh) + (assert (= (atanh 0.9d0) 1.4722194895832204d0))) + +;; Test some cases of integer operations with constant arguments +(with-test (:name :constant-integers) + (labels ((test-forms (op x y header &rest forms) + (let ((val (funcall op x y))) + (dolist (form forms) + (let ((new-val (funcall (compile nil (append header form)) x y))) + (unless (eql val new-val) + (error "~S /= ~S: ~S ~S ~S~%" val new-val (append header form) x y)))))) + (test-case (op x y type) + (test-forms op x y `(lambda (x y &aux z) + (declare (type ,type x y) + (ignorable x y z) + (notinline identity) + (optimize speed (safety 0)))) + `((,op x ,y)) + `((setf z (,op x ,y)) + (identity x) + z) + `((values (,op x ,y) x)) + `((,op ,x y)) + `((setf z (,op ,x y)) + (identity y) + z) + `((values (,op ,x y) y)) + + `((identity x) + (,op x ,y)) + `((identity x) + (setf z (,op x ,y)) + (identity x) + z) + `((identity x) + (values (,op x ,y) x)) + `((identity y) + (,op ,x y)) + `((identity y) + (setf z (,op ,x y)) + (identity y) + z) + `((identity y) + (values (,op ,x y) y)))) + (test-op (op) + (let ((ub `(unsigned-byte ,sb-vm:n-word-bits)) + (sb `(signed-byte ,sb-vm:n-word-bits))) + (loop for (x y type) in `((2 1 fixnum) + (2 1 ,ub) + (2 1 ,sb) + (,(1+ (ash 1 28)) ,(1- (ash 1 28)) fixnum) + (,(+ 3 (ash 1 30)) ,(+ 2 (ash 1 30)) ,ub) + (,(- -2 (ash 1 29)) ,(- 3 (ash 1 29)) ,sb) + ,@(when (> sb-vm:n-word-bits 32) + `((,(1+ (ash 1 29)) ,(1- (ash 1 29)) fixnum) + (,(1+ (ash 1 31)) ,(1- (ash 1 31)) ,ub) + (,(- -2 (ash 1 31)) ,(- 3 (ash 1 30)) ,sb) + (,(ash 1 40) ,(ash 1 39) fixnum) + (,(ash 1 40) ,(ash 1 39) ,ub) + (,(ash 1 40) ,(ash 1 39) ,sb)))) + do + (test-case op x y type) + (test-case op x x type))))) + (mapc #'test-op '(+ - * truncate + < <= = >= > + eql + eq))))