X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=tests%2Ffloat.pure.lisp;h=289360f6eb07618dc3807fd772efe2a7e4ecbce7;hb=6d36f2d6954cb79e3c88fef33fe0c3ad63deaea8;hp=08513ddaa6b78548123e25e4a273e20e59415cef;hpb=a157ed0be79751f85b8243c06102eea95af06aa3;p=sbcl.git

diff --git a/tests/float.pure.lisp b/tests/float.pure.lisp
index 08513dd..289360f 100644
--- a/tests/float.pure.lisp
+++ b/tests/float.pure.lisp
@@ -93,7 +93,7 @@
 (assert (= 0.0d0 (scale-float 1.0d0 (1- most-negative-fixnum))))
 
 (with-test (:name (:scale-float-overflow :bug-372)
-            :fails-on '(or :ppc :darwin)) ;; bug 372
+            :fails-on :darwin) ;; bug 372
   (progn
     (assert (raises-error? (scale-float 1.0 most-positive-fixnum)
                            floating-point-overflow))
@@ -125,7 +125,7 @@
 (funcall (compile nil '(lambda () (tan (tan (round 0))))))
 
 (with-test (:name (:addition-overflow :bug-372)
-            :fails-on '(or :ppc :darwin (and :x86 :netbsd)))
+            :fails-on '(or (and :ppc :openbsd) :darwin (and :x86 :netbsd)))
   (assert (typep (nth-value
                   1
                   (ignore-errors
@@ -234,81 +234,139 @@
     (assert (eql 0.0d0 (funcall f 123.0d0 0.0d0)))
     (assert (eql 0.0d0 (funcall f 123.0 0.0d0)))))
 
+;; Bug reported by Eric Marsden on July 15 2009. The compiler
+;; used not to constant fold calls with arguments of type
+;; (EQL foo).
+(with-test (:name :eql-type-constant-fold)
+  (assert (equal '(FUNCTION (T) (VALUES (MEMBER T) &OPTIONAL))
+                 (sb-kernel:%simple-fun-type
+                  (compile nil `(lambda (x)
+                                  (eql #c(1.0 2.0)
+                                       (the (eql #c(1.0 2.0))
+                                         x))))))))
 
-;; 1.0.29.xFIXMEx introduces a ton of changes for complex floats
-;; on x86-64. Huge test of doom to help catch weird corner
-;; cases.
-(with-test (:name :complex-floats)
-  (labels ((equal-enough (x y)
-             (cond ((eql x y))
-                   ((or (complexp x)
-                        (complexp y))
-                    (or (eql (coerce x '(complex double-float))
-                             (coerce y '(complex double-float)))
-                        (and (equal-enough (realpart x) (realpart y))
-                             (equal-enough (imagpart x) (imagpart y)))))
-                   ((numberp x)
-                    (or (eql (coerce x 'double-float) (coerce y 'double-float))
-                        (< (abs (- x y))  1d-5)))))
-           (reflections (x)
-             (values x
-                     (conjugate x)
-                     (complex (- (realpart x)) (imagpart x))
-                     (- x)))
-           (compute (x y r)
-             (list (+ x y) (+ r x) (+ x r)
-                   (- x y) (- r x) (- x r)
-                   (* x y) (* x r) (* r x)
-                   (unless (zerop y)
-                     (/ x y))
-                   (unless (zerop r)
-                     (/ x r))
-                   (unless (zerop x)
-                     (/ r x))
-                   (conjugate x) (conjugate r)
-                   (- x)
-                   (complex r) (complex r r) (complex 0 r)
-                   (= x y) (= r x) (= y r) (= x (complex 0 r))
-                   (eql x y) (eql x (complex r)) (eql y (complex r))
-                   (eql x (complex r r)) (eql y (complex 0 r))))
-           (compute-all (x y r)
-             (multiple-value-bind (x1 x2 x3 x4) (reflections x)
-               (multiple-value-bind (y1 y2 y3 y4) (reflections y)
-                 #.(let ((form '(list)))
-                     (dolist (x '(x1 x2 x3 x4) (reverse form))
-                       (dolist (y '(y1 y2 y3 y4))
-                         (push `(list ,x ,y r
-                                      (append (compute ,x ,y r)
-                                              (compute ,x ,y (- r))))
-                               form))))))))
-    (declare (inline reflections compute compute-all))
-    (let* ((reals     '(0 1 2))
-           (complexes '#.(let ((reals '(0 1 2))
-                               (cpx   '()))
-                           (dolist (x reals (nreverse cpx))
-                             (dolist (y reals)
-                               (push (complex x y) cpx)))))
-           (val       ()))
-      (declare (notinline every))
-      (dolist (r reals (nreverse val))
-        (dolist (x complexes)
-          (dolist (y complexes)
-            (let ((value  (compute-all x y r))
-                  (single (compute-all (coerce x '(complex single-float))
-                                       (coerce y '(complex single-float))
-                                       (coerce r 'single-float)))
-                  (double (compute-all (coerce x '(complex double-float))
-                                       (coerce y '(complex double-float))
-                                       (coerce r 'double-float))))
-              (assert (every (lambda (pos ref single double)
-                               (every (lambda (ref single double)
-                                        (or (and (equal-enough ref single)
-                                                 (equal-enough ref double))
-                                            (and (not (numberp single)) ;; -ve 0s
-                                                 (equal-enough single double))))
-                                      (fourth ref) (fourth single) (fourth double)))
-                             '((0 0) (0 1) (0 2) (0 3)
-                               (1 0) (1 1) (1 2) (1 3)
-                               (2 0) (2 1) (2 2) (2 3)
-                               (3 0) (3 1) (3 2) (3 3))
-                             value single double)))))))))
+;; The x86 port used not to reduce the arguments of transcendentals
+;; correctly. On other platforms, we trust libm to DTRT.
+#+x86
+(with-test (:name :range-reduction)
+  (flet ((almost= (x y)
+           (< (abs (- x y)) 1d-5)))
+    (macrolet ((foo (op value)
+                 `(assert (almost= (,op (mod ,value (* 2 pi)))
+                                   (,op ,value)))))
+      (let ((big (* pi (expt 2d0 70)))
+            (mid (coerce most-positive-fixnum 'double-float))
+            (odd (* pi most-positive-fixnum)))
+        (foo sin big)
+        (foo sin mid)
+        (foo sin odd)
+        (foo sin (/ odd 2d0))
+
+        (foo cos big)
+        (foo cos mid)
+        (foo cos odd)
+        (foo cos (/ odd 2d0))
+
+        (foo tan big)
+        (foo tan mid)
+        (foo tan odd)))))
+
+;; Leakage from the host could result in wrong values for truncation.
+(with-test (:name :truncate)
+  (assert (plusp (sb-kernel:%unary-truncate/single-float (expt 2f0 33))))
+  (assert (plusp (sb-kernel:%unary-truncate/double-float (expt 2d0 33))))
+  ;; That'd be one strange host, but just in case
+  (assert (plusp (sb-kernel:%unary-truncate/single-float (expt 2f0 65))))
+  (assert (plusp (sb-kernel:%unary-truncate/double-float (expt 2d0 65)))))
+
+;; On x86-64, we sometimes forgot to clear the higher order bits of the
+;; destination register before using it with an instruction that doesn't
+;; clear the (unused) high order bits. Suspect instructions are operations
+;; with only one operand: for everything else, the destination has already
+;; been loaded with a value, making it safe (by induction).
+;;
+;; The tests are extremely brittle and could be broken by any number of
+;; back- or front-end optimisations. We should just keep the issue above
+;; in mind at all times when working with SSE or similar instruction sets.
+#+(or x86 x86-64) ;; No other platforms have SB-VM::TOUCH-OBJECT.
+(macrolet ((with-pinned-floats ((count type &rest names) &body body)
+             "Force COUNT float values to be kept live (and hopefully in registers),
+              fill a temporary register with noise, and execute BODY."
+             (let ((dummy (loop repeat count
+                                collect (or (pop names)
+                                            (gensym "TEMP")))))
+               `(let ,(loop for i downfrom -1
+                            for var in dummy
+                            for j = (coerce i type)
+                            collect
+                            `(,var ,(complex j j))) ; we don't actually need that, but
+                  (declare (type (complex ,type) ,@dummy)) ; future-proofing can't hurt
+                  ,@(loop for var in dummy
+                          for i upfrom 0
+                          collect `(setf ,var ,(complex i (coerce i type))))
+                  (multiple-value-prog1
+                      (progn
+                        (let ((x ,(complex 1d0 1d0)))
+                          (declare (type (complex double-float) x))
+                          (setf x ,(complex most-positive-fixnum (float most-positive-fixnum 1d0)))
+                          (sb-vm::touch-object x))
+                        (locally ,@body))
+                    ,@(loop for var in dummy
+                            collect `(sb-vm::touch-object ,var)))))))
+  (with-test (:name :clear-sqrtsd)
+    (flet ((test-sqrtsd (float)
+             (declare (optimize speed (safety 1))
+                      (type (double-float (0d0)) float))
+             (with-pinned-floats (14 double-float x0)
+               (let ((x (sqrt float)))
+                 (values (+ x x0) float)))))
+      (declare (notinline test-sqrtsd))
+      (assert (zerop (imagpart (test-sqrtsd 4d0))))))
+
+  (with-test (:name :clear-sqrtsd-single)
+    (flet ((test-sqrtsd-float (float)
+             (declare (optimize speed (safety 1))
+                      (type (single-float (0f0)) float))
+             (with-pinned-floats (14 single-float x0)
+               (let ((x (sqrt float)))
+                 (values (+ x x0) float)))))
+      (declare (notinline test-sqrtsd-float))
+      (assert (zerop (imagpart (test-sqrtsd-float 4f0))))))
+
+  (with-test (:name :clear-cvtss2sd)
+    (flet ((test-cvtss2sd (float)
+             (declare (optimize speed (safety 1))
+                      (type single-float float))
+             (with-pinned-floats (14 double-float x0)
+               (let ((x (float float 0d0)))
+                 (values (+ x x0) (+ 1e0 float))))))
+      (declare (notinline test-cvtss2sd))
+      (assert (zerop (imagpart (test-cvtss2sd 1f0))))))
+
+  (with-test (:name :clear-cvtsd2ss)
+    (flet ((test-cvtsd2ss (float)
+             (declare (optimize speed (safety 1))
+                      (type double-float float))
+             (with-pinned-floats (14 single-float x0)
+               (let ((x (float float 1e0)))
+                 (values (+ x x0) (+ 1d0 float))))))
+      (declare (notinline test-cvtsd2ss))
+      (assert (zerop (imagpart (test-cvtsd2ss 4d0))))))
+
+  (with-test (:name :clear-cvtsi2sd)
+    (flet ((test-cvtsi2sd (int)
+             (declare (optimize speed (safety 0))
+                      (type (unsigned-byte 10) int))
+             (with-pinned-floats (15 double-float x0)
+               (+ (float int 0d0) x0))))
+      (declare (notinline test-cvtsi2sd))
+      (assert (zerop (imagpart (test-cvtsi2sd 4))))))
+
+  (with-test (:name :clear-cvtsi2ss)
+    (flet ((test-cvtsi2ss (int)
+             (declare (optimize speed (safety 0))
+                      (type (unsigned-byte 10) int))
+             (with-pinned-floats (15 single-float x0)
+               (+ (float int 0e0) x0))))
+      (declare (notinline test-cvtsi2ss))
+      (assert (zerop (imagpart (test-cvtsi2ss 4)))))))