X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=tests%2Finterface.pure.lisp;h=4ad2ffa86e77c6bca2c7b48066f2c290fec1693d;hb=683874b497a99cd2c11b6c5d9b47e2785b1ede5f;hp=a03ba43566945219aae8d91cd5c8fcd8a5a7f3c6;hpb=30d3955b07af6b6b2e52699f213e3b87b11e0f2d;p=sbcl.git

diff --git a/tests/interface.pure.lisp b/tests/interface.pure.lisp
index a03ba43..4ad2ffa 100644
--- a/tests/interface.pure.lisp
+++ b/tests/interface.pure.lisp
@@ -1,3 +1,5 @@
+;;;; tests for problems in the interface presented to the user/programmer
+
 ;;;; This software is part of the SBCL system. See the README file for
 ;;;; more information.
 ;;;;
@@ -10,26 +12,33 @@
 ;;;; more information.
 
 (in-package :cl-user)
+
+;;;; properties of symbols, e.g. presence of doc strings for public symbols
 
 ;;; Check for fbound external symbols in public packages that have no
-;;; argument list information. (This can happen if we get carried away
-;;; with byte compilation, since at least in sbcl-0.6.12 the byte
-;;; compiler can't record argument list information.)
+;;; argument list information. (This used to be possible when we got
+;;; carried away with byte compilation, since the byte compiler can't
+;;; record argument list information. Now that there's no byte
+;;; compiler, that can't happen, but it still shouldn't hurt to check
+;;; in case the argument information goes astray some other way.)
 (defvar *public-package-names*
   '("SB-ALIEN" "SB-C-CALL" "SB-DEBUG" "SB-EXT" "SB-GRAY" "SB-MP"
     "SB-PROFILE" "SB-PCL" "COMMON-LISP"))
-(defun has-arglist-info-p (function)
-  (declare (type function function))
+(defun has-arglist-info-p (fun)
+  (declare (type function fun))
   ;; The Lisp-level type FUNCTION can conceal a multitude of sins..
-  (case (sb-kernel:get-type function)
-    (#.sb-vm:function-header-type (sb-kernel:%function-arglist function))
-    (#.sb-vm:closure-function-header-type (has-arglist-info-p
-					   (sb-kernel:%closure-function
-					    function)))
+  (case (sb-kernel:widetag-of fun)
+    ((#.sb-vm:simple-fun-header-widetag #.sb-vm:closure-fun-header-widetag)
+      (sb-kernel:%simple-fun-arglist fun))
+    (#.sb-vm:closure-header-widetag (has-arglist-info-p
+				     (sb-kernel:%closure-fun fun)))
+    ;; In code/describe.lisp, ll. 227 (%describe-function), we use a scheme
+    ;; like above, and it seems to work. -- MNA 2001-06-12
+    ;;
     ;; (There might be other cases with arglist info also.
-    ;; FUNCTION-HEADER-TYPE and CLOSURE-FUNCTION-HEADER-TYPE just
+    ;; SIMPLE-FUN-HEADER-WIDETAG and CLOSURE-HEADER-WIDETAG just
     ;; happen to be the two case that I had my nose rubbed in when
-    ;; debugging a GC problem caused by applying %FUNCTION-ARGLIST to
+    ;; debugging a GC problem caused by applying %SIMPLE-FUN-ARGLIST to
     ;; a closure. -- WHN 2001-06-05)
     (t nil)))
 (defun check-ext-symbols-arglist (package)
@@ -44,23 +53,8 @@
 	       ;; though, and I haven't figured out what does work
 	       ;; right. For now we just punt.
 	       (values))
-	      #+nil 
-	      ((sb-int:info :function :accessor-for ext-sym)
-	       (values))
 	      ((typep fun 'generic-function)
-	       ;; FIXME: Check the argument lists of generic functions,
-	       ;; instead of just punting like this. (DESCRIBE seems
-	       ;; to know how to do it, at least for #'DOCUMENTATION.)
-	       (values))
-	      (;; FIXME: CONDITION slot accessors (e.g.
-	       ;; PRINT-NOT-READABLE-OBJECT) fall into this category.
-	       ;; They seem to have argument lists -- since at least
-	       ;; DESCRIBE knows how to find them -- but I have
-	       ;; neither reverse engineered how it's finding them,
-	       ;; nor factored that into a function which can be
-	       ;; shared with the logic here..
-	       (= (sb-kernel:get-type fun) sb-vm:closure-header-type)
-	       (values)) ; ..so for now we just punt.
+                (sb-pcl::generic-function-pretty-arglist fun))
 	      (t
 	       (let ((fun (symbol-function ext-sym)))
 		 (unless (has-arglist-info-p fun)
@@ -71,8 +65,15 @@
     (check-ext-symbols-arglist public-package)))
 (terpri)
 
-;;; FIXME: It might also be good to require that every external symbol
-;;; either has a doc string or has some good excuse (like being an
-;;; accessor for a structure which has a doc string).
+;;; FIXME: It would probably be good to require here that every
+;;; external symbol either has a doc string or has some good excuse
+;;; (like being an accessor for a structure which has a doc string).
+
+;;;; tests of interface machinery
 
-(print "done with interface.pure.lisp")
+;;; APROPOS should accept a package designator, not just a package, and
+;;; furthermore do the right thing when it gets a package designator.
+;;; (bug reported and fixed by Alexey Dejneka sbcl-devel 2001-10-17)
+(assert (< 0
+	   (length (apropos-list "PRINT" :cl))
+	   (length (apropos-list "PRINT"))))