X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=tests%2Finterface.pure.lisp;h=6febe337831bd2a30f0f12866e7cadbeb5710ac1;hb=a37de74b393a808825585000bb5b2b92218d46c0;hp=5ab2fd3c02f49f64c0b181f223a44030d011525e;hpb=7a5fb799b50cda4f2546e1fa98a903281d9849c5;p=sbcl.git diff --git a/tests/interface.pure.lisp b/tests/interface.pure.lisp index 5ab2fd3..6febe33 100644 --- a/tests/interface.pure.lisp +++ b/tests/interface.pure.lisp @@ -12,28 +12,29 @@ (in-package :cl-user) ;;; Check for fbound external symbols in public packages that have no -;;; argument list information. (This can happen if we get carried away -;;; with byte compilation, since at least in sbcl-0.6.12 the byte -;;; compiler can't record argument list information.) +;;; argument list information. (This used to be possible when we got +;;; carried away with byte compilation, since the byte compiler can't +;;; record argument list information. Now that there's no byte +;;; compiler, that can't happen, but it still shouldn't hurt to check +;;; in case the argument information goes astray some other way.) (defvar *public-package-names* '("SB-ALIEN" "SB-C-CALL" "SB-DEBUG" "SB-EXT" "SB-GRAY" "SB-MP" "SB-PROFILE" "SB-PCL" "COMMON-LISP")) -(defun has-arglist-info-p (function) - (declare (type function function)) +(defun has-arglist-info-p (fun) + (declare (type function fun)) ;; The Lisp-level type FUNCTION can conceal a multitude of sins.. - (case (sb-kernel:get-type function) - ((#.sb-vm:function-header-type #.sb-vm:closure-function-header-type) - (sb-kernel:%function-arglist function)) - (#.sb-vm:closure-header-type (has-arglist-info-p - (sb-kernel:%closure-function - function))) - ;; in code/describe.lisp, ll. 227 (%describe-function), we use a scheme + (case (sb-kernel:get-type fun) + ((#.sb-vm:simple-fun-header-widetag #.sb-vm:closure-fun-header-widetag) + (sb-kernel:%simple-fun-arglist fun)) + (#.sb-vm:closure-header-widetag (has-arglist-info-p + (sb-kernel:%closure-fun fun))) + ;; In code/describe.lisp, ll. 227 (%describe-function), we use a scheme ;; like above, and it seems to work. -- MNA 2001-06-12 ;; ;; (There might be other cases with arglist info also. - ;; FUNCTION-HEADER-TYPE and CLOSURE-HEADER-TYPE just + ;; SIMPLE-FUN-HEADER-WIDETAG and CLOSURE-HEADER-WIDETAG just ;; happen to be the two case that I had my nose rubbed in when - ;; debugging a GC problem caused by applying %FUNCTION-ARGLIST to + ;; debugging a GC problem caused by applying %SIMPLE-FUN-ARGLIST to ;; a closure. -- WHN 2001-06-05) (t nil))) (defun check-ext-symbols-arglist (package) @@ -48,9 +49,6 @@ ;; though, and I haven't figured out what does work ;; right. For now we just punt. (values)) - #+nil - ((sb-int:info :function :accessor-for ext-sym) - (values)) ((typep fun 'generic-function) (sb-pcl::generic-function-pretty-arglist fun)) (t @@ -66,6 +64,3 @@ ;;; FIXME: It would probably be good to require here that every ;;; external symbol either has a doc string or has some good excuse ;;; (like being an accessor for a structure which has a doc string). - -(print "done with interface.pure.lisp") -