X-Git-Url: http://repo.macrolet.net/gitweb/?a=blobdiff_plain;f=tests%2Fthreads.impure.lisp;h=3672c92abc727d4ab7800d1cb627270d6de75e6a;hb=f81f78b9a2a4ec8e2bef6074de121885c6f19e44;hp=8002d5b1007c19cf46c60006b9ec5b6761b5dea3;hpb=2a860441fcd4181c0a511094397fdc6b6511b280;p=sbcl.git diff --git a/tests/threads.impure.lisp b/tests/threads.impure.lisp index 8002d5b..3672c92 100644 --- a/tests/threads.impure.lisp +++ b/tests/threads.impure.lisp @@ -11,12 +11,17 @@ ;;;; absoluely no warranty. See the COPYING and CREDITS files for ;;;; more information. -(in-package "SB-THREAD") ; this is white-box testing, really +; WHITE-BOX TESTS +(in-package "SB-THREAD") (use-package :test-util) +(use-package "ASSERTOID") + +(setf sb-unix::*on-dangerous-select* :error) (defun wait-for-threads (threads) - (loop while (some #'sb-thread:thread-alive-p threads) do (sleep 0.01))) + (mapc (lambda (thread) (sb-thread:join-thread thread :default nil)) threads) + (assert (not (some #'sb-thread:thread-alive-p threads)))) (assert (eql 1 (length (list-all-threads)))) @@ -39,6 +44,58 @@ #-sb-thread (sb-ext:quit :unix-status 104) +;;; compare-and-swap + +(defmacro defincf (name accessor &rest args) + `(defun ,name (x) + (let* ((old (,accessor x ,@args)) + (new (1+ old))) + (loop until (eq old (sb-ext:compare-and-swap (,accessor x ,@args) old new)) + do (setf old (,accessor x ,@args) + new (1+ old))) + new))) + +(defstruct cas-struct (slot 0)) + +(defincf incf-car car) +(defincf incf-cdr cdr) +(defincf incf-slot cas-struct-slot) +(defincf incf-symbol-value symbol-value) +(defincf incf-svref/1 svref 1) +(defincf incf-svref/0 svref 0) + +(defmacro def-test-cas (name init incf op) + `(progn + (defun ,name (n) + (declare (fixnum n)) + (let* ((x ,init) + (run nil) + (threads + (loop repeat 10 + collect (sb-thread:make-thread + (lambda () + (loop until run + do (sb-thread:thread-yield)) + (loop repeat n do (,incf x))))))) + (setf run t) + (dolist (th threads) + (sb-thread:join-thread th)) + (assert (= (,op x) (* 10 n))))) + (,name 200000))) + +(def-test-cas test-cas-car (cons 0 nil) incf-car car) +(def-test-cas test-cas-cdr (cons nil 0) incf-cdr cdr) +(def-test-cas test-cas-slot (make-cas-struct) incf-slot cas-struct-slot) +(def-test-cas test-cas-value (let ((x '.x.)) + (set x 0) + x) + incf-symbol-value symbol-value) +(def-test-cas test-cas-svref/0 (vector 0 nil) incf-svref/0 (lambda (x) + (svref x 0))) +(def-test-cas test-cas-svref/1 (vector nil 0) incf-svref/1 (lambda (x) + (svref x 1))) +(format t "~&compare-and-swap tests done~%") + (let ((old-threads (list-all-threads)) (thread (make-thread (lambda () (assert (find *current-thread* *all-threads*)) @@ -50,6 +107,19 @@ (sleep 3) (assert (not (thread-alive-p thread)))) +(with-test (:name '(:join-thread :nlx :default)) + (let ((sym (gensym))) + (assert (eq sym (join-thread (make-thread (lambda () (sb-ext:quit))) + :default sym))))) + +(with-test (:name '(:join-thread :nlx :error)) + (raises-error? (join-thread (make-thread (lambda () (sb-ext:quit)))))) + +(with-test (:name '(:join-thread :multiple-values)) + (assert (equal '(1 2 3) + (multiple-value-list + (join-thread (make-thread (lambda () (values 1 2 3)))))))) + ;;; We had appalling scaling properties for a while. Make sure they ;;; don't reappear. (defun scaling-test (function &optional (nthreads 5)) @@ -81,13 +151,16 @@ (with-open-file (o "threads-foreign.c" :direction :output :if-exists :supersede) (format o "void loop_forever() { while(1) ; }~%")) (sb-ext:run-program - "cc" - (or #+linux '("-shared" "-o" "threads-foreign.so" "threads-foreign.c") + #-sunos "cc" #+sunos "gcc" + (or #+(or linux freebsd sunos) '(#+x86-64 "-fPIC" + "-shared" "-o" "threads-foreign.so" "threads-foreign.c") + #+darwin '(#+x86-64 "-arch" #+x86-64 "x86_64" + "-dynamiclib" "-o" "threads-foreign.so" "threads-foreign.c") (error "Missing shared library compilation options for this platform")) :search t) -(sb-alien:load-shared-object "threads-foreign.so") +(sb-alien:load-shared-object (truename "threads-foreign.so")) (sb-alien:define-alien-routine loop-forever sb-alien:void) - +(delete-file "threads-foreign.c") ;;; elementary "can we get a lock and release it again" (let ((l (make-mutex :name "foo")) @@ -109,17 +182,35 @@ (assert (ours-p (mutex-value l)) nil "5")) (assert (eql (mutex-value l) nil) nil "6"))) +(labels ((ours-p (value) + (eq *current-thread* value))) + (let ((l (make-spinlock :name "rec"))) + (assert (eql (spinlock-value l) nil) nil "1") + (with-recursive-spinlock (l) + (assert (ours-p (spinlock-value l)) nil "3") + (with-recursive-spinlock (l) + (assert (ours-p (spinlock-value l)) nil "4")) + (assert (ours-p (spinlock-value l)) nil "5")) + (assert (eql (spinlock-value l) nil) nil "6"))) + (with-test (:name (:mutex :nesting-mutex-and-recursive-lock)) (let ((l (make-mutex :name "a mutex"))) (with-mutex (l) (with-recursive-lock (l))))) -(let ((l (make-spinlock :name "spinlock")) - (p *current-thread*)) - (assert (eql (spinlock-value l) 0) nil "1") +(with-test (:name (:spinlock :nesting-spinlock-and-recursive-spinlock)) + (let ((l (make-spinlock :name "a spinlock"))) + (with-spinlock (l) + (with-recursive-spinlock (l))))) + +(let ((l (make-spinlock :name "spinlock"))) + (assert (eql (spinlock-value l) nil) ((spinlock-value l)) + "spinlock not free (1)") (with-spinlock (l) - (assert (eql (spinlock-value l) p) nil "2")) - (assert (eql (spinlock-value l) 0) nil "3")) + (assert (eql (spinlock-value l) *current-thread*) ((spinlock-value l)) + "spinlock not taken")) + (assert (eql (spinlock-value l) nil) ((spinlock-value l)) + "spinlock not free (2)")) ;; test that SLEEP actually sleeps for at least the given time, even ;; if interrupted by another thread exiting/a gc/anything @@ -317,7 +408,8 @@ (lambda () (princ ".") (force-output) (assert (thread-alive-p *current-thread*)) - (assert (zerop SB-KERNEL:*PSEUDO-ATOMIC-ATOMIC*))))) + (assert + (not (logbitp 0 SB-KERNEL:*PSEUDO-ATOMIC-BITS*)))))) (terminate-thread c) (wait-for-threads (list c))) @@ -417,7 +509,9 @@ (force-output) (sb-ext:quit :unix-status 1))))))) -(let* ((nanosleep-errno (progn +;; (nanosleep -1 0) does not fail on FreeBSD +(let* (#-freebsd + (nanosleep-errno (progn (sb-unix:nanosleep -1 0) (sb-unix::get-errno))) (open-errno (progn @@ -426,6 +520,7 @@ (sb-unix::get-errno))) (threads (list + #-freebsd (exercise-syscall (lambda () (sb-unix:nanosleep -1 0)) nanosleep-errno) (exercise-syscall (lambda () (open "no-such-file" :if-does-not-exist nil)) @@ -449,6 +544,7 @@ (format t "~&thread startup sigmask test done~%") +;; FIXME: What is this supposed to test? (sb-debug::enable-debugger) (let* ((main-thread *current-thread*) (interruptor-thread @@ -456,7 +552,8 @@ (sleep 2) (interrupt-thread main-thread #'break) (sleep 2) - (interrupt-thread main-thread #'continue))))) + (interrupt-thread main-thread #'continue)) + :name "interruptor"))) (with-session-lock (*session*) (sleep 3)) (loop while (thread-alive-p interruptor-thread))) @@ -476,20 +573,211 @@ (lambda () (sb-ext:run-program "sleep" '("1") :search t :wait nil))) -(with-test (:name (:thread-start :dynamic-values-and-gc)) - (let ((gc-thread (sb-thread:make-thread (lambda () - (loop (sleep (random 0.2)) - (sb-ext:gc :full t)))))) - (wait-for-threads - (loop for i below 3000 - when (zerop (mod i 30)) - do (princ ".") - collect - (let ((*x* (lambda ()))) - (declare (special *x*)) - (sb-thread:make-thread (lambda () (functionp *x*)))))) - (sb-thread:terminate-thread gc-thread) - (terpri))) +;;;; Binding stack safety + +(defparameter *x* nil) +(defparameter *n-gcs-requested* 0) +(defparameter *n-gcs-done* 0) + +(let ((counter 0)) + (defun make-something-big () + (let ((x (make-string 32000))) + (incf counter) + (let ((counter counter)) + (sb-ext:finalize x (lambda () (format t " ~S" counter) + (force-output))))))) + +(defmacro wait-for-gc () + `(progn + (incf *n-gcs-requested*) + (loop while (< *n-gcs-done* *n-gcs-requested*)))) + +(defun send-gc () + (loop until (< *n-gcs-done* *n-gcs-requested*)) + (format t "G") + (force-output) + (sb-ext:gc) + (incf *n-gcs-done*)) + +(defun exercise-binding () + (loop + (let ((*x* (make-something-big))) + (let ((*x* 42)) + ;; at this point the binding stack looks like this: + ;; NO-TLS-VALUE-MARKER, *x*, SOMETHING, *x* + t)) + (wait-for-gc) + ;; sig_stop_for_gc_handler binds FREE_INTERRUPT_CONTEXT_INDEX. By + ;; now SOMETHING is gc'ed and the binding stack looks like this: 0, + ;; 0, SOMETHING, 0 (because the symbol slots are zeroed on + ;; unbinding but values are not). + (let ((*x* nil)) + ;; bump bsp as if a BIND had just started + (incf sb-vm::*binding-stack-pointer* 2) + (wait-for-gc) + (decf sb-vm::*binding-stack-pointer* 2)))) + +(with-test (:name (:binding-stack-gc-safety)) + (let (threads) + (unwind-protect + (progn + (push (sb-thread:make-thread #'exercise-binding) threads) + (push (sb-thread:make-thread (lambda () + (loop + (sleep 0.1) + (send-gc)))) + threads) + (sleep 4)) + (mapc #'sb-thread:terminate-thread threads)))) + +(format t "~&binding test done~%") + +;;; HASH TABLES + +(defvar *errors* nil) + +(defun oops (e) + (setf *errors* e) + (format t "~&oops: ~A in ~S~%" e *current-thread*) + (sb-debug:backtrace) + (catch 'done)) + +(with-test (:name (:unsynchronized-hash-table)) + ;; We expect a (probable) error here: parellel readers and writers + ;; on a hash-table are not expected to work -- but we also don't + ;; expect this to corrupt the image. + (let* ((hash (make-hash-table)) + (*errors* nil) + (threads (list (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + ;;(princ "1") (force-output) + (setf (gethash (random 100) hash) 'h))))) + :name "writer") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + ;;(princ "2") (force-output) + (remhash (random 100) hash))))) + :name "reader") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + (sleep (random 1.0)) + (sb-ext:gc :full t))))) + :name "collector")))) + (unwind-protect + (sleep 10) + (mapc #'sb-thread:terminate-thread threads)))) + +(format t "~&unsynchronized hash table test done~%") + +(with-test (:name (:synchronized-hash-table)) + (let* ((hash (make-hash-table :synchronized t)) + (*errors* nil) + (threads (list (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + ;;(princ "1") (force-output) + (setf (gethash (random 100) hash) 'h))))) + :name "writer") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + ;;(princ "2") (force-output) + (remhash (random 100) hash))))) + :name "reader") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + (sleep (random 1.0)) + (sb-ext:gc :full t))))) + :name "collector")))) + (unwind-protect + (sleep 10) + (mapc #'sb-thread:terminate-thread threads)) + (assert (not *errors*)))) + +(format t "~&synchronized hash table test done~%") + +(with-test (:name (:hash-table-parallel-readers)) + (let ((hash (make-hash-table)) + (*errors* nil)) + (loop repeat 50 + do (setf (gethash (random 100) hash) 'xxx)) + (let ((threads (list (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + until (eq t (gethash (random 100) hash)))))) + :name "reader 1") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + until (eq t (gethash (random 100) hash)))))) + :name "reader 2") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + until (eq t (gethash (random 100) hash)))))) + :name "reader 3") + (sb-thread:make-thread + (lambda () + (catch 'done + (handler-bind ((serious-condition 'oops)) + (loop + (sleep (random 1.0)) + (sb-ext:gc :full t))))) + :name "collector")))) + (unwind-protect + (sleep 10) + (mapc #'sb-thread:terminate-thread threads)) + (assert (not *errors*))))) + +(format t "~&multiple reader hash table test done~%") + +(with-test (:name (:hash-table-single-accessor-parallel-gc)) + (let ((hash (make-hash-table)) + (*errors* nil)) + (let ((threads (list (sb-thread:make-thread + (lambda () + (handler-bind ((serious-condition 'oops)) + (loop + (let ((n (random 100))) + (if (gethash n hash) + (remhash n hash) + (setf (gethash n hash) 'h)))))) + :name "accessor") + (sb-thread:make-thread + (lambda () + (handler-bind ((serious-condition 'oops)) + (loop + (sleep (random 1.0)) + (sb-ext:gc :full t)))) + :name "collector")))) + (unwind-protect + (sleep 10) + (mapc #'sb-thread:terminate-thread threads)) + (assert (not *errors*))))) + +(format t "~&single accessor hash table test~%") #| ;; a cll post from eric marsden | (defun crash () @@ -503,3 +791,260 @@ | (mp:make-process #'roomy) | (mp:make-process #'roomy))) |# + +(with-test (:name (:condition-variable :notify-multiple)) + (flet ((tester (notify-fun) + (let ((queue (make-waitqueue :name "queue")) + (lock (make-mutex :name "lock")) + (data nil)) + (labels ((test (x) + (loop + (with-mutex (lock) + (format t "condition-wait ~a~%" x) + (force-output) + (condition-wait queue lock) + (format t "woke up ~a~%" x) + (force-output) + (push x data))))) + (let ((threads (loop for x from 1 to 10 + collect + (let ((x x)) + (sb-thread:make-thread (lambda () + (test x))))))) + (sleep 5) + (with-mutex (lock) + (funcall notify-fun queue)) + (sleep 5) + (mapcar #'terminate-thread threads) + ;; Check that all threads woke up at least once + (assert (= (length (remove-duplicates data)) 10))))))) + (tester (lambda (queue) + (format t "~&(condition-notify queue 10)~%") + (force-output) + (condition-notify queue 10))) + (tester (lambda (queue) + (format t "~&(condition-broadcast queue)~%") + (force-output) + (condition-broadcast queue))))) + +(format t "waitqueue wakeup tests done~%") + +(with-test (:name (:mutex :finalization)) + (let ((a nil)) + (dotimes (i 500000) + (setf a (make-mutex))))) + +(format t "mutex finalization test done~%") + +;;; Check that INFO is thread-safe, at least when we're just doing reads. + +(let* ((symbols (loop repeat 10000 collect (gensym))) + (functions (loop for (symbol . rest) on symbols + for next = (car rest) + for fun = (let ((next next)) + (lambda (n) + (if next + (funcall next (1- n)) + n))) + do (setf (symbol-function symbol) fun) + collect fun))) + (defun infodb-test () + (funcall (car functions) 9999))) + +(with-test (:name (:infodb :read)) + (let* ((ok t) + (threads (loop for i from 0 to 10 + collect (sb-thread:make-thread + (lambda () + (dotimes (j 100) + (write-char #\-) + (finish-output) + (let ((n (infodb-test))) + (unless (zerop n) + (setf ok nil) + (format t "N != 0 (~A)~%" n) + (sb-ext:quit))))))))) + (wait-for-threads threads) + (assert ok))) + +(format t "infodb test done~%") + +(with-test (:name (:backtrace)) + ;; Printing backtraces from several threads at once used to hang the + ;; whole SBCL process (discovered by accident due to a timer.impure + ;; test misbehaving). The cause was that packages weren't even + ;; thread-safe for only doing FIND-SYMBOL, and while printing + ;; backtraces a loot of symbol lookups need to be done due to + ;; *PRINT-ESCAPE*. + (let* ((threads (loop repeat 10 + collect (sb-thread:make-thread + (lambda () + (dotimes (i 1000) + (with-output-to-string (*debug-io*) + (sb-debug::backtrace 10)))))))) + (wait-for-threads threads))) + +(format t "backtrace test done~%") + +(format t "~&starting gc deadlock test: WARNING: THIS TEST WILL HANG ON FAILURE!~%") + +(with-test (:name (:gc-deadlock)) + ;; Prior to 0.9.16.46 thread exit potentially deadlocked the + ;; GC due to *all-threads-lock* and session lock. On earlier + ;; versions and at least on one specific box this test is good enough + ;; to catch that typically well before the 1500th iteration. + (loop + with i = 0 + with n = 3000 + while (< i n) + do + (incf i) + (when (zerop (mod i 100)) + (write-char #\.) + (force-output)) + (handler-case + (if (oddp i) + (sb-thread:make-thread + (lambda () + (sleep (random 0.001))) + :name (list :sleep i)) + (sb-thread:make-thread + (lambda () + ;; KLUDGE: what we are doing here is explicit, + ;; but the same can happen because of a regular + ;; MAKE-THREAD or LIST-ALL-THREADS, and various + ;; session functions. + (sb-thread::with-all-threads-lock + (sb-thread::with-session-lock (sb-thread::*session*) + (sb-ext:gc)))) + :name (list :gc i))) + (error (e) + (format t "~%error creating thread ~D: ~A -- backing off for retry~%" i e) + (sleep 0.1) + (incf i))))) + +(format t "~&gc deadlock test done~%") + +(let ((count (make-array 8 :initial-element 0))) + (defun closure-one () + (declare (optimize safety)) + (values (incf (aref count 0)) (incf (aref count 1)) + (incf (aref count 2)) (incf (aref count 3)) + (incf (aref count 4)) (incf (aref count 5)) + (incf (aref count 6)) (incf (aref count 7)))) + (defun no-optimizing-away-closure-one () + (setf count (make-array 8 :initial-element 0)))) + +(defstruct box + (count 0)) + +(let ((one (make-box)) + (two (make-box)) + (three (make-box))) + (defun closure-two () + (declare (optimize safety)) + (values (incf (box-count one)) (incf (box-count two)) (incf (box-count three)))) + (defun no-optimizing-away-closure-two () + (setf one (make-box) + two (make-box) + three (make-box)))) + +(with-test (:name (:funcallable-instances)) + ;; the funcallable-instance implementation used not to be threadsafe + ;; against setting the funcallable-instance function to a closure + ;; (because the code and lexenv were set separately). + (let ((fun (sb-kernel:%make-funcallable-instance 0)) + (condition nil)) + (setf (sb-kernel:funcallable-instance-fun fun) #'closure-one) + (flet ((changer () + (loop (setf (sb-kernel:funcallable-instance-fun fun) #'closure-one) + (setf (sb-kernel:funcallable-instance-fun fun) #'closure-two))) + (test () + (handler-case (loop (funcall fun)) + (serious-condition (c) (setf condition c))))) + (let ((changer (make-thread #'changer)) + (test (make-thread #'test))) + (handler-case + (progn + ;; The two closures above are fairly carefully crafted + ;; so that if given the wrong lexenv they will tend to + ;; do some serious damage, but it is of course difficult + ;; to predict where the various bits and pieces will be + ;; allocated. Five seconds failed fairly reliably on + ;; both my x86 and x86-64 systems. -- CSR, 2006-09-27. + (sb-ext:with-timeout 5 + (wait-for-threads (list test))) + (error "~@" condition)) + (sb-ext:timeout () + (terminate-thread changer) + (terminate-thread test) + (wait-for-threads (list changer test)))))))) + +(format t "~&funcallable-instance test done~%") + +(defun random-type (n) + `(integer ,(random n) ,(+ n (random n)))) + +(defun subtypep-hash-cache-test () + (dotimes (i 10000) + (let ((type1 (random-type 500)) + (type2 (random-type 500))) + (let ((a (subtypep type1 type2))) + (dotimes (i 100) + (assert (eq (subtypep type1 type2) a)))))) + (format t "ok~%") + (force-output)) + +(with-test (:name '(:hash-cache :subtypep)) + (dotimes (i 10) + (sb-thread:make-thread #'subtypep-hash-cache-test))) +(format t "hash-cache tests done~%") + +;;;; BLACK BOX TESTS + +(in-package :cl-user) +(use-package :test-util) +(use-package "ASSERTOID") + +(format t "parallel defclass test -- WARNING, WILL HANG ON FAILURE!~%") +(with-test (:name :parallel-defclass) + (defclass test-1 () ((a :initform :orig-a))) + (defclass test-2 () ((b :initform :orig-b))) + (defclass test-3 (test-1 test-2) ((c :initform :orig-c))) + (let* ((run t) + (d1 (sb-thread:make-thread (lambda () + (loop while run + do (defclass test-1 () ((a :initform :new-a))) + (write-char #\1) + (force-output))) + :name "d1")) + (d2 (sb-thread:make-thread (lambda () + (loop while run + do (defclass test-2 () ((b :initform :new-b))) + (write-char #\2) + (force-output))) + :name "d2")) + (d3 (sb-thread:make-thread (lambda () + (loop while run + do (defclass test-3 (test-1 test-2) ((c :initform :new-c))) + (write-char #\3) + (force-output))) + :name "d3")) + (i (sb-thread:make-thread (lambda () + (loop while run + do (let ((i (make-instance 'test-3))) + (assert (member (slot-value i 'a) '(:orig-a :new-a))) + (assert (member (slot-value i 'b) '(:orig-b :new-b))) + (assert (member (slot-value i 'c) '(:orig-c :new-c)))) + (write-char #\i) + (force-output))) + :name "i"))) + (format t "~%sleeping!~%") + (sleep 2.0) + (format t "~%stopping!~%") + (setf run nil) + (mapc (lambda (th) + (sb-thread:join-thread th) + (format t "~%joined ~S~%" (sb-thread:thread-name th))) + (list d1 d2 d3 i)))) +(format t "parallel defclass test done~%")