From: Ryan Davis <ryan@acceleration.net>
Date: Fri, 2 Apr 2010 20:41:19 +0000 (-0400)
Subject: Add US-ASCII unprintable control characters to the exlusion list per RFC2396 2.4.3
X-Git-Url: http://repo.macrolet.net/gitweb/?a=commitdiff_plain;h=1c768744300916893c359ccf18cfe2dbb55b3978;p=puri-unicode.git

Add US-ASCII unprintable control characters to the exlusion list per RFC2396 2.4.3

http://www.ietf.org/rfc/rfc2396.txt

Adds to *excluded-characters*, with a test
---

diff --git a/src.lisp b/src.lisp
index ab13bad..d39d32b 100644
--- a/src.lisp
+++ b/src.lisp
@@ -355,10 +355,14 @@
 ;; Parsing
 
 (defparameter *excluded-characters*
-    '(;; `delims' (except #\%, because it's handled specially):
+    (append
+     (loop for i from 0 to #x1f
+	   collect (code-char i))
+     '(;; `delims' (except #\%, because it's handled specially):
       #\< #\> #\" #\space #\#
+
       ;; `unwise':
-      #\{ #\} #\| #\\ #\^ #\[ #\] #\`))
+      #\{ #\} #\| #\\ #\^ #\[ #\] #\`)))
 
 (defun reserved-char-vector (chars &key except)
   (do* ((a (make-array 127 :element-type 'bit :initial-element 0))
diff --git a/tests.lisp b/tests.lisp
index b5cbe37..77d1961 100644
--- a/tests.lisp
+++ b/tests.lisp
@@ -408,6 +408,16 @@
        :condition-type 'uri-parse-error)
      res)
 
+
+    ;;an escaped newline isn't rendered properly
+    (push
+    `(let ((weird-uri "https://example.com/q?foo%0abar%20baz"))
+       (test
+	weird-uri
+	(puri:render-uri (puri:parse-uri weird-uri) nil)
+	:test #'string=)
+     ) res)
+
     `(progn ,@(nreverse res))))
 
 (defun do-tests ()