From: David Vázquez <davazp@gmail.com>
Date: Mon, 17 Feb 2014 17:14:10 +0000 (+0100)
Subject: Simplify nbutlast
X-Git-Url: http://repo.macrolet.net/gitweb/?a=commitdiff_plain;h=44a805bb77c4572d10687b2b2e4053ceda49ce7e;p=jscl.git

Simplify nbutlast
---

diff --git a/src/list.lisp b/src/list.lisp
index 8b30aec..274d2f3 100644
--- a/src/list.lisp
+++ b/src/list.lisp
@@ -261,45 +261,23 @@
 (defun nbutlast (x &optional (n 1))
   "Destructively returns x, less the n last elements in the list."
   (cond
-    ((not (and (integerp n)
-               (>= n 0)))
+    ((not (and (integerp n) (>= n 0)))
      ;; TODO: turn this error into a type error, per CLHS spec.
      (error "n must be a non-negative integer"))
-
     ;; trivial optimizations
     ((zerop n) x)
-
     (t
      ;; O(n) walk of the linked list, trimming out the link where appropriate
-     (let*
-         ((head x)
-          (trailing x))
-
-       ;; find n in...
-       (do ((i 0 (1+ i)))
-           ((or ( >= i (1- n))
-                (not head)
-                (not (consp (cdr head)))))
-         (setf head (cdr head)))
-
-       (when (consp (cdr head))
-
-       (setf trailing x)
-       (setf head (cdr head))
-
-       ;; walk until the end
-       (do ()
-           ((or
-             (not (consp head))
-             (not (cdr head))))
-
-         (setf head (cdr head))
-         (setf trailing (cdr trailing)))
-
-       ;; snip
-       (rplacd trailing nil)
-
-       x)))))
+     (let* ((head x)
+            (trailing (nthcdr n x)))
+       ;; If there are enough conses
+       (when (consp trailing)
+         (while (consp (cdr trailing))
+           (setq head (cdr head))
+           (setq trailing (cdr trailing)))
+         ;; snip
+         (rplacd head nil)
+         x)))))
 
 (defun member (x list &key key (test #'eql testp) (test-not #'eql test-not-p))
   (while list