From: Thiemo Seufer <ths@networkno.de>
Date: Wed, 28 Sep 2005 13:25:42 +0000 (+0000)
Subject: 0.9.5.4:
X-Git-Url: http://repo.macrolet.net/gitweb/?a=commitdiff_plain;h=e08e932c669e0ca9382ffe4d7a4b3b484bd3cccf;p=sbcl.git

0.9.5.4:
	Less copy&paste in C code, minor code cleanups.
---

diff --git a/src/runtime/breakpoint.c b/src/runtime/breakpoint.c
index be487fa..4c587eb 100644
--- a/src/runtime/breakpoint.c
+++ b/src/runtime/breakpoint.c
@@ -71,7 +71,6 @@ void breakpoint_do_displaced_inst(os_context_t* context,
     arch_do_displaced_inst(context, orig_inst);
 }
 
-#if !(defined(LISP_FEATURE_X86) || defined(LISP_FEATURE_X86_64))
 static lispobj find_code(os_context_t *context)
 {
 #ifdef reg_CODE
@@ -88,22 +87,15 @@ static lispobj find_code(os_context_t *context)
     else
         return code - HeaderValue(header)*sizeof(lispobj);
 #else
-    return NIL;
-#endif
-}
-#else
-static lispobj find_code(os_context_t *context)
-{
     lispobj codeptr =
         (lispobj)component_ptr_from_pc((lispobj *)(*os_context_pc_addr(context)));
 
-    if (codeptr == 0) {
+    if (codeptr == 0)
         return NIL;
-    } else {
+    else
         return codeptr + OTHER_POINTER_LOWTAG;
-    }
-}
 #endif
+}
 
 static long compute_offset(os_context_t *context, lispobj code)
 {
@@ -153,15 +145,15 @@ void handle_breakpoint(int signal, siginfo_t* info, os_context_t *context)
     undo_fake_foreign_function_call(context);
 }
 
-#if !(defined(LISP_FEATURE_X86) || defined(LISP_FEATURE_X86_64))
 void *handle_fun_end_breakpoint(int signal, siginfo_t *info,
                                 os_context_t *context)
 {
-    lispobj code, lra;
+    lispobj code, context_sap, lra;
     struct code *codeptr;
 
     fake_foreign_function_call(context);
 
+    context_sap = alloc_sap(context);
     code = find_code(context);
     codeptr = (struct code *)native_pointer(code);
 
@@ -172,42 +164,20 @@ void *handle_fun_end_breakpoint(int signal, siginfo_t *info,
     funcall3(SymbolFunction(HANDLE_BREAKPOINT),
              compute_offset(context, code),
              code,
-             alloc_sap(context));
+             context_sap);
 
     lra = codeptr->constants[REAL_LRA_SLOT];
+
 #ifdef reg_CODE
-    if (codeptr->constants[KNOWN_RETURN_P_SLOT] == NIL) {
+    if (codeptr->constants[KNOWN_RETURN_P_SLOT] == NIL)
         *os_context_register_addr(context, reg_CODE) = lra;
-    }
 #endif
-    undo_fake_foreign_function_call(context);
-    return (void *)(lra-OTHER_POINTER_LOWTAG+sizeof(lispobj));
-}
-#else
-void *handle_fun_end_breakpoint(int signal, siginfo_t *info,
-                                os_context_t *context)
-{
-    lispobj code, context_sap;
-    struct code *codeptr;
-
-    fake_foreign_function_call(context);
-
-    context_sap = alloc_sap(context);
-    code = find_code(context);
-    codeptr = (struct code *)native_pointer(code);
-
-    /* Don't disallow recursive breakpoint traps. Otherwise, we can't
-     * use debugger breakpoints anywhere in here. */
-    thread_sigmask(SIG_SETMASK, os_context_sigmask_addr(context), 0);
-
-    funcall3(SymbolFunction(HANDLE_BREAKPOINT),
-             compute_offset(context, code),
-             code,
-             context_sap);
 
     undo_fake_foreign_function_call(context);
 
-    return compute_pc(codeptr->constants[REAL_LRA_SLOT],
-                      fixnum_value(codeptr->constants[REAL_LRA_SLOT+1]));
-}
+#ifdef reg_LRA
+    return (void *)(lra-OTHER_POINTER_LOWTAG+sizeof(lispobj));
+#else
+    return compute_pc(lra, fixnum_value(codeptr->constants[REAL_LRA_SLOT+1]));
 #endif
+}
diff --git a/src/runtime/interrupt.c b/src/runtime/interrupt.c
index 2be4af4..48c298a 100644
--- a/src/runtime/interrupt.c
+++ b/src/runtime/interrupt.c
@@ -298,7 +298,7 @@ void
 interrupt_internal_error(int signal, siginfo_t *info, os_context_t *context,
                          boolean continuable)
 {
-    lispobj context_sap = 0;
+    lispobj context_sap;
 
     fake_foreign_function_call(context);
 
@@ -326,9 +326,8 @@ interrupt_internal_error(int signal, siginfo_t *info, os_context_t *context,
              continuable ? T : NIL);
 
     undo_fake_foreign_function_call(context); /* blocks signals again */
-    if (continuable) {
+    if (continuable)
         arch_skip_instruction(context);
-    }
 }
 
 void
diff --git a/version.lisp-expr b/version.lisp-expr
index a39b04f..81e2c36 100644
--- a/version.lisp-expr
+++ b/version.lisp-expr
@@ -17,4 +17,4 @@
 ;;; checkins which aren't released. (And occasionally for internal
 ;;; versions, especially for internal versions off the main CVS
 ;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".)
-"0.9.5.3"
+"0.9.5.4"