From 14d9ae2d08892daee9a94da1a050bb6f2ca57dbe Mon Sep 17 00:00:00 2001 From: Juho Snellman Date: Sat, 27 Aug 2005 09:43:20 +0000 Subject: [PATCH] 0.9.4.10: * Record BUG: compile-time SYMBOL-PACKAGE-LOCKED-ERROR shouldn't be a subclass of error * Mark the test that tickles this bug as expected to fail * Fix typo in the unexpected case of "Unexcepted success" --- BUGS | 10 ++++++++++ tests/package-locks.impure.lisp | 16 +++++++++------- tests/run-tests.lisp | 2 +- version.lisp-expr | 2 +- 4 files changed, 21 insertions(+), 9 deletions(-) diff --git a/BUGS b/BUGS index 071dde6..a9bd148 100644 --- a/BUGS +++ b/BUGS @@ -2097,3 +2097,13 @@ WORKAROUND: According to , the stack exhaustion checking (implemented with a write-protected guard page) does not work on SunOS/x86. + +387: + 12:10 < jsnell> the package-lock test is basically due to a change in the test + behaviour when you install a handler for error around it. I + thought I'd disabled the test for now, but apparently that was + my imagination + 12:19 < Xophe> jsnell: ah, I see the problem in the package-locks stuff + 12:19 < Xophe> it's the same problem as we had with compiler-error conditions + 12:19 < Xophe> the thing that's signalled up and down the stack is a subtype of + ERROR, where it probably shouldn't be diff --git a/tests/package-locks.impure.lisp b/tests/package-locks.impure.lisp index f535e9e..f91a32f 100644 --- a/tests/package-locks.impure.lisp +++ b/tests/package-locks.impure.lisp @@ -436,14 +436,16 @@ package-lock-violation)))) ;;;; Program-errors from lexical violations -(reset-test) -(set-test-locks t) -(dolist (pair *illegal-compile-time-forms-alist*) - (destructuring-bind (sym . form) pair +;;;; In addition to that, this is also testing for bug 387 +(with-test (:fails-on :sbcl) + (reset-test) + (set-test-locks t) + (dolist (pair *illegal-compile-time-forms-alist*) + (destructuring-bind (sym . form) pair (declare (ignore sym)) - (let ((fun (compile nil `(lambda () - ,form)))) - (assert (raises-error? (funcall fun) program-error))))) + (let ((fun (compile nil `(lambda () + ,form)))) + (assert (raises-error? (funcall fun) program-error)))))) ;;;; See that trace on functions in locked packages doesn't break ;;;; anything. diff --git a/tests/run-tests.lisp b/tests/run-tests.lisp index 7845a6e..32f7bb9 100644 --- a/tests/run-tests.lisp +++ b/tests/run-tests.lisp @@ -57,7 +57,7 @@ (ecase (first fail) (:expected-failure "Expected failure:") (:unexpected-failure "Failure:") - (:unexpected-success "Unexcepted success:")) + (:unexpected-success "Unexpected success:")) (enough-namestring (second fail)) (third fail)))))) (t diff --git a/version.lisp-expr b/version.lisp-expr index 716efaf..a917079 100644 --- a/version.lisp-expr +++ b/version.lisp-expr @@ -17,4 +17,4 @@ ;;; checkins which aren't released. (And occasionally for internal ;;; versions, especially for internal versions off the main CVS ;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".) -"0.9.4.9" +"0.9.4.10" -- 1.7.10.4