From ded7da3c8971fd0c04830496199e366a6df83a18 Mon Sep 17 00:00:00 2001 From: Nikodemus Siivola Date: Thu, 30 Sep 2010 08:40:35 +0000 Subject: [PATCH] 1.0.43.12: edit STYLE for stricter patch submission guidelines * "git format-patch -1" is superior to plain diffs, since it includes the commit message as well -- and the patch author is the best person to write it. * Explain when to use Launchpad and when to use sbcl-devel. --- STYLE | 15 +++++++++------ version.lisp-expr | 2 +- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/STYLE b/STYLE index 247c9a6..2c6f6f3 100644 --- a/STYLE +++ b/STYLE @@ -6,10 +6,11 @@ SBCL Style Guide Patch Submissions ================= -Preferred patch format is output from "git format-patch", but unified -diffs and links to public git repos are acceptable as well. +Preferred patch format is output from "git format-patch", including +the commit message. The commit message should explain the why and how +of the change. -Please include test-cases in your patch if possible. +Please include test-cases in your patch if at all possible. Please format your submission for ease of reading: unless the change is whitespace only, avoid re-indenting code you are not touching, etc. @@ -20,9 +21,11 @@ If your patch includes algorithmic changes, explain them. If your patch uses a published algorithm, please include a link to the paper. We aren't always as well-educated as we'd like to... -Patches can be either mailed to sbcl-devel, or submitted via -Launchpad. If you submit a patch on Launchpad, please add the tag -"review" to the associated bug. +Ready-to-apply patches should be submitted via Launchpad: please add +the tag "review" to the associated bug. + +Patches requiring more widespread discussion and feedback should be +sent to the sbcl-devel mailing list. If you have any questions, feel free to ask them on sbcl-devel. diff --git a/version.lisp-expr b/version.lisp-expr index b481407..e5a8f8f 100644 --- a/version.lisp-expr +++ b/version.lisp-expr @@ -17,4 +17,4 @@ ;;; checkins which aren't released. (And occasionally for internal ;;; versions, especially for internal versions off the main CVS ;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".) -"1.0.43.11" +"1.0.43.12" -- 1.7.10.4