(defvar *undefined-warnings*)
(declaim (list *undefined-warnings*))
-;;; Check that NAME is a valid function name, returning the name if
-;;; OK, and doing an error if not. In addition to checking for basic
-;;; well-formedness, we also check that symbol names are not NIL or
-;;; the name of a special form.
-(defun check-function-name (name)
- (typecase name
- (list
- (unless (and (consp name) (consp (cdr name))
- (null (cddr name)) (eq (car name) 'setf)
- (symbolp (cadr name)))
- (compiler-error "illegal function name: ~S" name))
- name)
- (symbol
- (when (eq (info :function :kind name) :special-form)
- (compiler-error "Special form is an illegal function name: ~S" name))
- name)
- (t
- (compiler-error "illegal function name: ~S" name))))
-
-;;; This is called to do something about SETF functions that overlap
-;;; with SETF macros. Perhaps we should interact with the user to see
-;;; whether the macro should be blown away, but for now just give a
-;;; warning. Due to the weak semantics of the (SETF FUNCTION) name, we
-;;; can't assume that they aren't just naming a function (SETF FOO)
-;;; for the heck of it. NAME is already known to be well-formed.
-(defun note-if-setf-function-and-macro (name)
- (when (consp name)
- (when (or (info :setf :inverse name)
- (info :setf :expander name))
- (compiler-style-warning
- "defining as a SETF function a name that already has a SETF macro:~
- ~% ~S"
- name)))
- (values))
-
;;; Look up some symbols in *FREE-VARIABLES*, returning the var
;;; structures for any which exist. If any of the names aren't
;;; symbols, we complain.
(unless (csubtypep type (specifier-type 'function))
(error "not a function type: ~S" (first args)))
(dolist (name (rest args))
- (cond ((info :function :accessor-for name)
- ;; FIXME: This used to be a WARNING, which was
- ;; clearly wrong, since it would cause warnings to
- ;; be issued for conforming code, which is really
- ;; annoying for people who use Lisp code to build
- ;; Lisp systems (and check the return values from
- ;; COMPILE and COMPILE-FILE). Changing it to a
- ;; compiler note is somewhat better, since it's
- ;; after all news about a limitation of the
- ;; compiler, not a problem in the code. But even
- ;; better would be to handle FTYPE proclamations
- ;; for slot accessors, and since in the long run
- ;; slot accessors should become more like other
- ;; functions, this should eventually become
- ;; straightforward.
- (maybe-compiler-note
- "~@<ignoring FTYPE proclamation for ~
- slot accessor (currently unsupported): ~2I~_~S~:>"
- name))
- (t
- ;; KLUDGE: Something like the commented-out TYPE/=
- ;; check here would be nice, but it has been
- ;; commented out because TYPE/= doesn't support
- ;; function types. It could probably be made to do
- ;; so, but it might take some time, since function
- ;; types involve values types, which aren't
- ;; supported, and since the SUBTYPEP operator for
- ;; FUNCTION types is rather broken, e.g.
- ;; (SUBTYPEP '(FUNCTION (T BOOLEAN) NIL)
- ;; '(FUNCTION (FIXNUM FIXNUM) NIL)) => T, T
- ;; -- WHN 20000229
- #+nil
- (when (eq (info :function :where-from name) :declared)
- (let ((old-type (info :function :type name)))
- (when (type/= type old-type)
- (style-warn
- "new FTYPE proclamation~@
- ~S~@
- for ~S does not match old FTYPE proclamation~@
- ~S"
- (list type name old-type)))))
+ ;; KLUDGE: Something like the commented-out TYPE/=
+ ;; check here would be nice, but it has been
+ ;; commented out because TYPE/= doesn't support
+ ;; function types. It could probably be made to do
+ ;; so, but it might take some time, since function
+ ;; types involve values types, which aren't
+ ;; supported, and since the SUBTYPEP operator for
+ ;; FUNCTION types is rather broken, e.g.
+ ;; (SUBTYPEP '(FUNCTION (T BOOLEAN) NIL)
+ ;; '(FUNCTION (FIXNUM FIXNUM) NIL)) => T, T
+ ;; -- WHN 20000229
+ #|
+ (when (eq (info :function :where-from name) :declared)
+ (let ((old-type (info :function :type name)))
+ (when (type/= type old-type)
+ (style-warn
+ "new FTYPE proclamation~@
+ ~S~@
+ for ~S does not match old FTYPE proclamation~@
+ ~S"
+ (list type name old-type)))))
+ |#
+
+ ;; Now references to this function shouldn't be warned
+ ;; about as undefined, since even if we haven't seen a
+ ;; definition yet, we know one is planned. (But if this
+ ;; function name was already declared as a structure
+ ;; accessor, then that was already been taken care of.)
+ (proclaim-as-fun-name name)
+ (note-name-defined name :function)
- (proclaim-as-function-name name)
- (note-name-defined name :function)
- (setf (info :function :type name) type
- (info :function :where-from name) :declared)))))))
+ ;; the actual type declaration
+ (setf (info :function :type name) type
+ (info :function :where-from name) :declared)))))
(freeze-type
(dolist (type args)
(let ((class (specifier-type type)))
(setq *policy* (process-optimize-decl form *policy*)))
((inline notinline maybe-inline)
(dolist (name args)
- ;; (CMU CL did (PROCLAIM-AS-FUNCTION-NAME NAME) here, but that
+ ;; (CMU CL did (PROCLAIM-AS-FUN-NAME NAME) here, but that
;; seems more likely to surprise the user than to help him, so
;; we don't do it.)
(setf (info :function :inlinep name)
projects / sbcl.git / blobdiff