(:generator 1
nil))
+;;; Accessing a slot from an earlier stack frame is definite hackery.
+(define-vop (ancestor-frame-ref)
+ (:args (frame-pointer :scs (descriptor-reg))
+ (variable-home-tn :load-if nil))
+ (:results (value :scs (descriptor-reg any-reg)))
+ (:policy :fast-safe)
+ (:generator 4
+ (aver (sc-is variable-home-tn control-stack))
+ (loadw value frame-pointer
+ (frame-word-offset (tn-offset variable-home-tn)))))
+(define-vop (ancestor-frame-set)
+ (:args (frame-pointer :scs (descriptor-reg))
+ (value :scs (descriptor-reg any-reg)))
+ (:results (variable-home-tn :load-if nil))
+ (:policy :fast-safe)
+ (:generator 4
+ (aver (sc-is variable-home-tn control-stack))
+ (storew value frame-pointer
+ (frame-word-offset (tn-offset variable-home-tn)))))
+
(define-vop (xep-allocate-frame)
(:info start-lab copy-more-arg-follows)
(:vop-var vop)
(:generator 1
- (align n-lowtag-bits)
+ (emit-alignment n-lowtag-bits)
(trace-table-entry trace-table-fun-prologue)
(emit-label start-lab)
;; Skip space for the function header.
;; The start of the actual code.
;; Save the return-pc.
- (popw ebp-tn (- (1+ return-pc-save-offset)))
+ (popw ebp-tn (frame-word-offset return-pc-save-offset))
;; If copy-more-arg follows it will allocate the correct stack
;; size. The stack is not allocated first here as this may expose
(inst lea esp-tn
(make-ea :dword :base ebp-tn
:disp (- (* n-word-bytes
- (max 3 (sb-allocated-size 'stack)))))))
+ (- (max 3 (sb-allocated-size 'stack))
+ sp->fp-offset))))))
(trace-table-entry trace-table-normal)))
;;; or a multiple-call-local. All it does is allocate stack space for the
;;; callee (who has the same size stack as us).
(define-vop (allocate-frame)
- (:results (res :scs (any-reg control-stack))
+ (:results (res :scs (any-reg))
(nfp))
(:info callee)
(:ignore nfp callee)
(:generator 2
- (move res esp-tn)
+ (inst lea res (make-ea :dword :base esp-tn
+ :disp (- (* sp->fp-offset n-word-bytes))))
(inst sub esp-tn (* n-word-bytes (sb-allocated-size 'stack)))))
;;; Allocate a partial frame for passing stack arguments in a full
;;; before it can extend the stack.
(define-vop (allocate-full-call-frame)
(:info nargs)
- (:results (res :scs (any-reg control-stack)))
+ (:results (res :scs (any-reg)))
(:generator 2
- (move res esp-tn)
+ (inst lea res (make-ea :dword :base esp-tn
+ :disp (- (* sp->fp-offset n-word-bytes))))
(inst sub esp-tn (* (max nargs 3) n-word-bytes))))
\f
;;; Emit code needed at the return-point from an unknown-values call
;;; Nvals is the number of values that are to be received (should
;;; equal the length of Values).
;;;
-;;; MOVE-TEMP is a DESCRIPTOR-REG TN used as a temporary.
-;;;
-;;; This code exploits the fact that in the unknown-values convention,
-;;; a single value return returns at the return PC + 2, whereas a
-;;; return of other than one value returns directly at the return PC.
-;;;
;;; If 0 or 1 values are expected, then we just emit an instruction to
;;; reset the SP (which will only be executed when other than 1 value
;;; is returned.)
;;; there are stack values.
;;; -- Reset SP. This must be done whenever other than 1 value is
;;; returned, regardless of the number of values desired.
-(defun default-unknown-values (vop values nvals)
+(defun default-unknown-values (vop values nvals node)
(declare (type (or tn-ref null) values)
(type unsigned-byte nvals))
- (cond
- ((<= nvals 1)
- (note-this-location vop :single-value-return)
- (inst mov esp-tn ebx-tn))
- ((<= nvals register-arg-count)
- (let ((regs-defaulted (gen-label)))
- (note-this-location vop :unknown-return)
- (inst jmp-short regs-defaulted)
- ;; Default the unsuppled registers.
- (let* ((2nd-tn-ref (tn-ref-across values))
- (2nd-tn (tn-ref-tn 2nd-tn-ref)))
- (inst mov 2nd-tn nil-value)
- (when (> nvals 2)
- (loop
- for tn-ref = (tn-ref-across 2nd-tn-ref)
- then (tn-ref-across tn-ref)
- for count from 2 below register-arg-count
- do (inst mov (tn-ref-tn tn-ref) 2nd-tn))))
- (inst mov ebx-tn esp-tn)
- (emit-label regs-defaulted)
- (inst mov esp-tn ebx-tn)))
- ((<= nvals 7)
- ;; The number of bytes depends on the relative jump instructions.
- ;; Best case is 31+(n-3)*14, worst case is 35+(n-3)*18. For
- ;; NVALS=6 that is 73/89 bytes, and for NVALS=7 that is 87/107
- ;; bytes which is likely better than using the blt below.
- (let ((regs-defaulted (gen-label))
- (defaulting-done (gen-label))
- (default-stack-slots (gen-label)))
- (note-this-location vop :unknown-return)
- ;; Branch off to the MV case.
- (inst jmp-short regs-defaulted)
- ;; Do the single value case.
- ;; Default the register args
- (inst mov eax-tn nil-value)
- (do ((i 1 (1+ i))
- (val (tn-ref-across values) (tn-ref-across val)))
- ((= i (min nvals register-arg-count)))
- (inst mov (tn-ref-tn val) eax-tn))
-
- ;; Fake other registers so it looks like we returned with all the
- ;; registers filled in.
- (move ebx-tn esp-tn)
- (inst push edx-tn)
- (inst jmp default-stack-slots)
-
- (emit-label regs-defaulted)
-
- (inst mov eax-tn nil-value)
- (storew edx-tn ebx-tn -1)
- (collect ((defaults))
- (do ((i register-arg-count (1+ i))
- (val (do ((i 0 (1+ i))
- (val values (tn-ref-across val)))
- ((= i register-arg-count) val))
- (tn-ref-across val)))
- ((null val))
- (let ((default-lab (gen-label))
- (tn (tn-ref-tn val)))
- (defaults (cons default-lab tn))
-
- (inst cmp ecx-tn (fixnumize i))
- (inst jmp :be default-lab)
- (loadw edx-tn ebx-tn (- (1+ i)))
- (inst mov tn edx-tn)))
-
- (emit-label defaulting-done)
- (loadw edx-tn ebx-tn -1)
- (move esp-tn ebx-tn)
-
- (let ((defaults (defaults)))
- (when defaults
- (assemble (*elsewhere*)
- (trace-table-entry trace-table-fun-prologue)
- (emit-label default-stack-slots)
- (dolist (default defaults)
- (emit-label (car default))
- (inst mov (cdr default) eax-tn))
- (inst jmp defaulting-done)
- (trace-table-entry trace-table-normal)))))))
- (t
- ;; 91 bytes for this branch.
- (let ((regs-defaulted (gen-label))
- (restore-edi (gen-label))
- (no-stack-args (gen-label))
- (default-stack-vals (gen-label))
- (count-okay (gen-label)))
- (note-this-location vop :unknown-return)
- ;; Branch off to the MV case.
- (inst jmp-short regs-defaulted)
-
- ;; Default the register args, and set up the stack as if we
- ;; entered the MV return point.
- (inst mov ebx-tn esp-tn)
- (inst push edx-tn)
- (inst mov edi-tn nil-value)
- (inst push edi-tn)
- (inst mov esi-tn edi-tn)
- ;; Compute a pointer to where to put the [defaulted] stack values.
- (emit-label no-stack-args)
- (inst lea edi-tn
- (make-ea :dword :base ebp-tn
- :disp (* (- (1+ register-arg-count)) n-word-bytes)))
- ;; Load EAX with NIL so we can quickly store it, and set up
- ;; stuff for the loop.
- (inst mov eax-tn nil-value)
- (inst std)
- (inst mov ecx-tn (- nvals register-arg-count))
- ;; Jump into the default loop.
- (inst jmp default-stack-vals)
-
- ;; The regs are defaulted. We need to copy any stack arguments,
- ;; and then default the remaining stack arguments.
- (emit-label regs-defaulted)
- ;; Save EDI.
- (storew edi-tn ebx-tn (- (1+ 1)))
- ;; Compute the number of stack arguments, and if it's zero or
- ;; less, don't copy any stack arguments.
- (inst sub ecx-tn (fixnumize register-arg-count))
- (inst jmp :le no-stack-args)
-
- ;; Throw away any unwanted args.
- (inst cmp ecx-tn (fixnumize (- nvals register-arg-count)))
- (inst jmp :be count-okay)
- (inst mov ecx-tn (fixnumize (- nvals register-arg-count)))
- (emit-label count-okay)
- ;; Save the number of stack values.
- (inst mov eax-tn ecx-tn)
- ;; Compute a pointer to where the stack args go.
- (inst lea edi-tn
- (make-ea :dword :base ebp-tn
- :disp (* (- (1+ register-arg-count)) n-word-bytes)))
- ;; Save ESI, and compute a pointer to where the args come from.
- (storew esi-tn ebx-tn (- (1+ 2)))
- (inst lea esi-tn
- (make-ea :dword :base ebx-tn
- :disp (* (- (1+ register-arg-count)) n-word-bytes)))
- ;; Do the copy.
- (inst shr ecx-tn word-shift) ; make word count
- (inst std)
- (inst rep)
- (inst movs :dword)
- ;; Restore ESI.
- (loadw esi-tn ebx-tn (- (1+ 2)))
- ;; Now we have to default the remaining args. Find out how many.
- (inst sub eax-tn (fixnumize (- nvals register-arg-count)))
- (inst neg eax-tn)
- ;; If none, then just blow out of here.
- (inst jmp :le restore-edi)
- (inst mov ecx-tn eax-tn)
- (inst shr ecx-tn word-shift) ; word count
- ;; Load EAX with NIL for fast storing.
- (inst mov eax-tn nil-value)
- ;; Do the store.
- (emit-label default-stack-vals)
- (inst rep)
- (inst stos eax-tn)
- ;; Restore EDI, and reset the stack.
- (emit-label restore-edi)
- (loadw edi-tn ebx-tn (- (1+ 1)))
- (inst mov esp-tn ebx-tn))))
+ (let ((type (sb!c::basic-combination-derived-type node)))
+ (cond
+ ((<= nvals 1)
+ (note-this-location vop :single-value-return)
+ (cond
+ ((<= (sb!kernel:values-type-max-value-count type)
+ register-arg-count)
+ (when (and (named-type-p type)
+ (eq nil (named-type-name type)))
+ ;; The function never returns, it may happen that the code
+ ;; ends right here leavig the :SINGLE-VALUE-RETURN note
+ ;; dangling. Let's emit a NOP.
+ (inst nop)))
+ ((not (sb!kernel:values-type-may-be-single-value-p type))
+ (inst mov esp-tn ebx-tn))
+ ((member :cmov *backend-subfeatures*)
+ (inst cmov :c esp-tn ebx-tn))
+ (t
+ (let ((single-value (gen-label)))
+ (inst jmp :nc single-value)
+ (inst mov esp-tn ebx-tn)
+ (emit-label single-value)))))
+ ((<= nvals register-arg-count)
+ (note-this-location vop :unknown-return)
+ (when (sb!kernel:values-type-may-be-single-value-p type)
+ (let ((regs-defaulted (gen-label)))
+ (inst jmp :c regs-defaulted)
+ ;; Default the unsupplied registers.
+ (let* ((2nd-tn-ref (tn-ref-across values))
+ (2nd-tn (tn-ref-tn 2nd-tn-ref)))
+ (inst mov 2nd-tn nil-value)
+ (when (> nvals 2)
+ (loop
+ for tn-ref = (tn-ref-across 2nd-tn-ref)
+ then (tn-ref-across tn-ref)
+ for count from 2 below register-arg-count
+ do (inst mov (tn-ref-tn tn-ref) 2nd-tn))))
+ (inst mov ebx-tn esp-tn)
+ (emit-label regs-defaulted)))
+ (when (< register-arg-count
+ (sb!kernel:values-type-max-value-count type))
+ (inst mov esp-tn ebx-tn)))
+ ((<= nvals 7)
+ ;; The number of bytes depends on the relative jump instructions.
+ ;; Best case is 31+(n-3)*14, worst case is 35+(n-3)*18. For
+ ;; NVALS=6 that is 73/89 bytes, and for NVALS=7 that is 87/107
+ ;; bytes which is likely better than using the blt below.
+ (let ((regs-defaulted (gen-label))
+ (defaulting-done (gen-label))
+ (default-stack-slots (gen-label)))
+ (note-this-location vop :unknown-return)
+ ;; Branch off to the MV case.
+ (inst jmp :c regs-defaulted)
+ ;; Do the single value case.
+ ;; Default the register args
+ (inst mov eax-tn nil-value)
+ (do ((i 1 (1+ i))
+ (val (tn-ref-across values) (tn-ref-across val)))
+ ((= i (min nvals register-arg-count)))
+ (inst mov (tn-ref-tn val) eax-tn))
+ ;; Fake other registers so it looks like we returned with all the
+ ;; registers filled in.
+ (move ebx-tn esp-tn)
+ (inst jmp default-stack-slots)
+ (emit-label regs-defaulted)
+ (inst mov eax-tn nil-value)
+ (collect ((defaults))
+ (do ((i register-arg-count (1+ i))
+ (val (do ((i 0 (1+ i))
+ (val values (tn-ref-across val)))
+ ((= i register-arg-count) val))
+ (tn-ref-across val)))
+ ((null val))
+ (let ((default-lab (gen-label))
+ (tn (tn-ref-tn val))
+ (first-stack-arg-p (= i register-arg-count)))
+ (defaults (cons default-lab
+ (cons tn first-stack-arg-p)))
+ (inst cmp ecx-tn (fixnumize i))
+ (inst jmp :be default-lab)
+ (when first-stack-arg-p
+ ;; There are stack args so the frame of the callee is
+ ;; still there, save EDX in its first slot temporalily.
+ (storew edx-tn ebx-tn (frame-word-offset sp->fp-offset)))
+ (loadw edx-tn ebx-tn (frame-word-offset (+ sp->fp-offset i)))
+ (inst mov tn edx-tn)))
+ (emit-label defaulting-done)
+ (loadw edx-tn ebx-tn (frame-word-offset sp->fp-offset))
+ (move esp-tn ebx-tn)
+ (let ((defaults (defaults)))
+ (when defaults
+ (assemble (*elsewhere*)
+ (trace-table-entry trace-table-fun-prologue)
+ (emit-label default-stack-slots)
+ (dolist (default defaults)
+ (emit-label (car default))
+ (when (cddr default)
+ ;; We are setting the first stack argument to NIL.
+ ;; The callee's stack frame is dead, save EDX by
+ ;; pushing it to the stack, it will end up at same
+ ;; place as in the (STOREW EDX-TN EBX-TN -1) case
+ ;; above.
+ (inst push edx-tn))
+ (inst mov (second default) eax-tn))
+ (inst jmp defaulting-done)
+ (trace-table-entry trace-table-normal)))))))
+ (t
+ ;; 91 bytes for this branch.
+ (let ((regs-defaulted (gen-label))
+ (restore-edi (gen-label))
+ (no-stack-args (gen-label))
+ (default-stack-vals (gen-label))
+ (count-okay (gen-label)))
+ (note-this-location vop :unknown-return)
+ ;; Branch off to the MV case.
+ (inst jmp :c regs-defaulted)
+ ;; Default the register args, and set up the stack as if we
+ ;; entered the MV return point.
+ (inst mov ebx-tn esp-tn)
+ (inst mov edi-tn nil-value)
+ (inst mov esi-tn edi-tn)
+ ;; Compute a pointer to where to put the [defaulted] stack values.
+ (emit-label no-stack-args)
+ (inst push edx-tn)
+ (inst push edi-tn)
+ (inst lea edi-tn
+ (make-ea :dword :base ebp-tn
+ :disp (frame-byte-offset register-arg-count)))
+ ;; Load EAX with NIL so we can quickly store it, and set up
+ ;; stuff for the loop.
+ (inst mov eax-tn nil-value)
+ (inst std)
+ (inst mov ecx-tn (- nvals register-arg-count))
+ ;; Jump into the default loop.
+ (inst jmp default-stack-vals)
+ ;; The regs are defaulted. We need to copy any stack arguments,
+ ;; and then default the remaining stack arguments.
+ (emit-label regs-defaulted)
+ ;; Compute the number of stack arguments, and if it's zero or
+ ;; less, don't copy any stack arguments.
+ (inst sub ecx-tn (fixnumize register-arg-count))
+ (inst jmp :le no-stack-args)
+ ;; Save EDI.
+ (storew edi-tn ebx-tn (frame-word-offset (+ sp->fp-offset 1)))
+ ;; Throw away any unwanted args.
+ (inst cmp ecx-tn (fixnumize (- nvals register-arg-count)))
+ (inst jmp :be count-okay)
+ (inst mov ecx-tn (fixnumize (- nvals register-arg-count)))
+ (emit-label count-okay)
+ ;; Save the number of stack values.
+ (inst mov eax-tn ecx-tn)
+ ;; Compute a pointer to where the stack args go.
+ (inst lea edi-tn
+ (make-ea :dword :base ebp-tn
+ :disp (frame-byte-offset register-arg-count)))
+ ;; Save ESI, and compute a pointer to where the args come from.
+ (storew esi-tn ebx-tn (frame-word-offset (+ sp->fp-offset 2)))
+ (inst lea esi-tn
+ (make-ea :dword :base ebx-tn
+ :disp (frame-byte-offset
+ (+ sp->fp-offset register-arg-count))))
+ ;; Do the copy.
+ (inst shr ecx-tn word-shift) ; make word count
+ (inst std)
+ (inst rep)
+ (inst movs :dword)
+ ;; Restore ESI.
+ (loadw esi-tn ebx-tn (frame-word-offset (+ sp->fp-offset 2)))
+ ;; Now we have to default the remaining args. Find out how many.
+ (inst sub eax-tn (fixnumize (- nvals register-arg-count)))
+ (inst neg eax-tn)
+ ;; If none, then just blow out of here.
+ (inst jmp :le restore-edi)
+ (inst mov ecx-tn eax-tn)
+ (inst shr ecx-tn word-shift) ; word count
+ ;; Load EAX with NIL for fast storing.
+ (inst mov eax-tn nil-value)
+ ;; Do the store.
+ (emit-label default-stack-vals)
+ (inst rep)
+ (inst stos eax-tn)
+ ;; Restore EDI, and reset the stack.
+ (emit-label restore-edi)
+ (loadw edi-tn ebx-tn (frame-word-offset (+ sp->fp-offset 1)))
+ (inst mov esp-tn ebx-tn)
+ (inst cld)))))
(values))
\f
;;;; unknown values receiving
;;; explicitly allocate these TNs, since their lifetimes overlap with
;;; the results start and count. (Also, it's nice to be able to target
;;; them.)
-(defun receive-unknown-values (args nargs start count)
+(defun receive-unknown-values (args nargs start count node)
(declare (type tn args nargs start count))
- (let ((variable-values (gen-label))
+ (let ((type (sb!c::basic-combination-derived-type node))
+ (variable-values (gen-label))
+ (stack-values (gen-label))
(done (gen-label)))
- (inst jmp-short variable-values)
-
- (cond ((location= start (first *register-arg-tns*))
- (inst push (first *register-arg-tns*))
- (inst lea start (make-ea :dword :base esp-tn :disp 4)))
- (t (inst mov start esp-tn)
- (inst push (first *register-arg-tns*))))
- (inst mov count (fixnumize 1))
- (inst jmp done)
-
- (emit-label variable-values)
+ (when (sb!kernel:values-type-may-be-single-value-p type)
+ (inst jmp :c variable-values)
+ (cond ((location= start (first *register-arg-tns*))
+ (inst push (first *register-arg-tns*))
+ (inst lea start (make-ea :dword :base esp-tn :disp n-word-bytes)))
+ (t (inst mov start esp-tn)
+ (inst push (first *register-arg-tns*))))
+ (inst mov count (fixnumize 1))
+ (inst jmp done)
+ (emit-label variable-values))
+ ;; The stack frame is burnt and RETurned from if there are no
+ ;; stack values. In this case quickly reallocate sufficient space.
+ (when (<= (sb!kernel:values-type-min-value-count type)
+ register-arg-count)
+ (inst cmp nargs (fixnumize register-arg-count))
+ (inst jmp :g stack-values)
+ (inst sub esp-tn nargs)
+ (emit-label stack-values))
;; dtc: this writes the registers onto the stack even if they are
;; not needed, only the number specified in ecx are used and have
;; stack allocated to them. No harm is done.
(loop
for arg in *register-arg-tns*
for i downfrom -1
+ for j below (sb!kernel:values-type-max-value-count type)
do (storew arg args i))
(move start args)
(move count nargs)
\f
;;;; local call with unknown values convention return
+(defun check-ocfp-and-return-pc (old-fp return-pc)
+ #+nil
+ (format t "*known-return: old-fp ~S, tn-kind ~S; ~S ~S~%"
+ old-fp (sb!c::tn-kind old-fp) (sb!c::tn-save-tn old-fp)
+ (sb!c::tn-kind (sb!c::tn-save-tn old-fp)))
+ #+nil
+ (format t "*known-return: return-pc ~S, tn-kind ~S; ~S ~S~%"
+ return-pc (sb!c::tn-kind return-pc)
+ (sb!c::tn-save-tn return-pc)
+ (sb!c::tn-kind (sb!c::tn-save-tn return-pc)))
+ (unless (and (sc-is old-fp control-stack)
+ (= (tn-offset old-fp) ocfp-save-offset))
+ (error "ocfp not on stack in standard save location?"))
+ (unless (and (sc-is return-pc sap-stack)
+ (= (tn-offset return-pc) return-pc-save-offset))
+ (error "return-pc not on stack in standard save location?")))
+
+;;; The local call convention doesn't fit that well with x86-style
+;;; calls. Emit a header for local calls to pop the return address
+;;; in the right place.
+(defun emit-block-header (start-label trampoline-label fall-thru-p alignp)
+ (declare (ignore alignp))
+ (when trampoline-label
+ (when fall-thru-p
+ (inst jmp start-label))
+ (emit-label trampoline-label)
+ (popw rbp-tn (frame-word-offset return-pc-save-offset)))
+ (emit-label start-label))
+
;;; Non-TR local call for a fixed number of values passed according to
;;; the unknown values convention.
;;;
(:move-args :local-call)
(:info arg-locs callee target nvals)
(:vop-var vop)
- (:ignore nfp arg-locs args #+nil callee)
+ (:ignore nfp arg-locs args callee)
+ (:node-var node)
(:generator 5
(trace-table-entry trace-table-call-site)
(move ebp-tn fp)
-
- (let ((ret-tn (callee-return-pc-tn callee)))
- #+nil
- (format t "*call-local ~S; tn-kind ~S; tn-save-tn ~S; its tn-kind ~S~%"
- ret-tn (sb!c::tn-kind ret-tn) (sb!c::tn-save-tn ret-tn)
- (sb!c::tn-kind (sb!c::tn-save-tn ret-tn)))
-
- ;; Is the return-pc on the stack or in a register?
- (sc-case ret-tn
- ((sap-stack)
- #+nil (format t "*call-local: ret-tn on stack; offset=~S~%"
- (tn-offset ret-tn))
- (storew (make-fixup nil :code-object return)
- ebp-tn (- (1+ (tn-offset ret-tn)))))
- ((sap-reg)
- (inst lea ret-tn (make-fixup nil :code-object return)))))
-
(note-this-location vop :call-site)
- (inst jmp target)
- RETURN
- (default-unknown-values vop values nvals)
+ (inst call target)
+ (default-unknown-values vop values nvals node)
(trace-table-entry trace-table-normal)))
;;; Non-TR local call for a variable number of return values passed according
(:save-p t)
(:move-args :local-call)
(:info save callee target)
- (:ignore args save nfp #+nil callee)
+ (:ignore args save nfp callee)
(:vop-var vop)
+ (:node-var node)
(:generator 20
(trace-table-entry trace-table-call-site)
(move ebp-tn fp)
-
- (let ((ret-tn (callee-return-pc-tn callee)))
- #+nil
- (format t "*multiple-call-local ~S; tn-kind ~S; tn-save-tn ~S; its tn-kind ~S~%"
- ret-tn (sb!c::tn-kind ret-tn) (sb!c::tn-save-tn ret-tn)
- (sb!c::tn-kind (sb!c::tn-save-tn ret-tn)))
-
- ;; Is the return-pc on the stack or in a register?
- (sc-case ret-tn
- ((sap-stack)
- #+nil (format t "*multiple-call-local: ret-tn on stack; offset=~S~%"
- (tn-offset ret-tn))
- ;; Stack
- (storew (make-fixup nil :code-object return)
- ebp-tn (- (1+ (tn-offset ret-tn)))))
- ((sap-reg)
- ;; Register
- (inst lea ret-tn (make-fixup nil :code-object return)))))
-
(note-this-location vop :call-site)
- (inst jmp target)
- RETURN
+ (inst call target)
(note-this-location vop :unknown-return)
- (receive-unknown-values values-start nvals start count)
+ (receive-unknown-values values-start nvals start count node)
(trace-table-entry trace-table-normal)))
\f
;;;; local call with known values return
(:move-args :local-call)
(:save-p t)
(:info save callee target)
- (:ignore args res save nfp #+nil callee)
+ (:ignore args res save nfp callee)
(:vop-var vop)
(:generator 5
(trace-table-entry trace-table-call-site)
(move ebp-tn fp)
-
- (let ((ret-tn (callee-return-pc-tn callee)))
-
- #+nil
- (format t "*known-call-local ~S; tn-kind ~S; tn-save-tn ~S; its tn-kind ~S~%"
- ret-tn (sb!c::tn-kind ret-tn) (sb!c::tn-save-tn ret-tn)
- (sb!c::tn-kind (sb!c::tn-save-tn ret-tn)))
-
- ;; Is the return-pc on the stack or in a register?
- (sc-case ret-tn
- ((sap-stack)
- #+nil (format t "*known-call-local: ret-tn on stack; offset=~S~%"
- (tn-offset ret-tn))
- ;; Stack
- (storew (make-fixup nil :code-object return)
- ebp-tn (- (1+ (tn-offset ret-tn)))))
- ((sap-reg)
- ;; Register
- (inst lea ret-tn (make-fixup nil :code-object return)))))
-
(note-this-location vop :call-site)
- (inst jmp target)
- RETURN
+ (inst call target)
(note-this-location vop :known-return)
(trace-table-entry trace-table-normal)))
\f
-;;; Return from known values call. We receive the return locations as
-;;; arguments to terminate their lifetimes in the returning function. We
-;;; restore FP and CSP and jump to the Return-PC.
-;;;
-;;; We can assume we know exactly where old-fp and return-pc are because
-;;; make-old-fp-save-location and make-return-pc-save-location always
-;;; return the same place.
-#+nil
-(define-vop (known-return)
- (:args (old-fp)
- (return-pc :scs (any-reg immediate-stack) :target rpc)
- (vals :more t))
- (:move-args :known-return)
- (:info val-locs)
- (:temporary (:sc unsigned-reg :from (:argument 1)) rpc)
- (:ignore val-locs vals)
- (:vop-var vop)
- (:generator 6
- (trace-table-entry trace-table-fun-epilogue)
- ;; Save the return-pc in a register 'cause the frame-pointer is
- ;; going away. Note this not in the usual stack location so we
- ;; can't use RET
- (move rpc return-pc)
- ;; Restore the stack.
- (move esp-tn ebp-tn)
- ;; Restore the old fp. We know OLD-FP is going to be in its stack
- ;; save slot, which is a different frame that than this one,
- ;; so we don't have to worry about having just cleared
- ;; most of the stack.
- (move ebp-tn old-fp)
- (inst jmp rpc)
- (trace-table-entry trace-table-normal)))
-\f
;;; From Douglas Crosher
;;; Return from known values call. We receive the return locations as
;;; arguments to terminate their lifetimes in the returning function. We
;;; restore FP and CSP and jump to the Return-PC.
-;;;
-;;; The old-fp may be either in a register or on the stack in its
-;;; standard save locations - slot 0.
-;;;
-;;; The return-pc may be in a register or on the stack in any slot.
(define-vop (known-return)
(:args (old-fp)
(return-pc)
(:ignore val-locs vals)
(:vop-var vop)
(:generator 6
+ (check-ocfp-and-return-pc old-fp return-pc)
(trace-table-entry trace-table-fun-epilogue)
-
- #+nil (format t "*known-return: old-fp ~S, tn-kind ~S; ~S ~S~%"
- old-fp (sb!c::tn-kind old-fp) (sb!c::tn-save-tn old-fp)
- (sb!c::tn-kind (sb!c::tn-save-tn old-fp)))
-
- #+nil (format t "*known-return: return-pc ~S, tn-kind ~S; ~S ~S~%"
- return-pc (sb!c::tn-kind return-pc)
- (sb!c::tn-save-tn return-pc)
- (sb!c::tn-kind (sb!c::tn-save-tn return-pc)))
-
- ;; return-pc may be either in a register or on the stack.
- (sc-case return-pc
- ((sap-reg)
- (sc-case old-fp
- ((control-stack)
-
- #+nil (format t "*known-return: old-fp ~S on stack; offset=~S~%"
- old-fp (tn-offset old-fp))
-
- (cond ((zerop (tn-offset old-fp))
- ;; Zot all of the stack except for the old-fp.
- (inst lea esp-tn (make-ea :dword :base ebp-tn
- :disp (- (* (1+ ocfp-save-offset)
- n-word-bytes))))
- ;; Restore the old fp from its save location on the stack,
- ;; and zot the stack.
- (inst pop ebp-tn))
-
- (t
- (cerror "Continue anyway"
- "VOP return-local doesn't work if old-fp (in slot ~
- ~S) is not in slot 0"
- (tn-offset old-fp)))))
-
- ((any-reg descriptor-reg)
- ;; Zot all the stack.
- (move esp-tn ebp-tn)
- ;; Restore the old-fp.
- (move ebp-tn old-fp)))
-
- ;; Return; return-pc is in a register.
- (inst jmp return-pc))
-
- ((sap-stack)
-
- #+nil (format t "*known-return: return-pc ~S on stack; offset=~S~%"
- return-pc (tn-offset return-pc))
-
- ;; Zot all of the stack except for the old-fp and return-pc.
- (inst lea esp-tn
- (make-ea :dword :base ebp-tn
- :disp (- (* (1+ (tn-offset return-pc)) n-word-bytes))))
- ;; Restore the old fp. old-fp may be either on the stack in its
- ;; save location or in a register, in either case this restores it.
- (move ebp-tn old-fp)
- ;; The return pops the return address (4 bytes), then we need
- ;; to pop all the slots before the return-pc which includes the
- ;; 4 bytes for the old-fp.
- (inst ret (* (tn-offset return-pc) n-word-bytes))))
-
+ ;; Zot all of the stack except for the old-fp and return-pc.
+ (inst mov esp-tn ebp-tn)
+ (inst pop ebp-tn)
+ (inst ret)
(trace-table-entry trace-table-normal)))
\f
;;;; full call
(:info
,@(unless (or variable (eq return :tail)) '(arg-locs))
,@(unless variable '(nargs))
- ,@(when (eq return :fixed) '(nvals)))
+ ,@(when (eq return :fixed) '(nvals))
+ step-instrumenting)
(:ignore
,@(unless (or variable (eq return :tail)) '(arg-locs))
:from (:argument 1)
:to (:argument 2))
old-fp-tmp)))
+ ,@(unless (eq return :tail)
+ '((:node-var node)))
(:generator ,(+ (if named 5 0)
(if variable 19 1)
;; FIXME: FORMAT T for stale
;; diagnostic output (several of
;; them around here), ick
- (format t "** tail-call old-fp not S0~%")
+ (error "** tail-call old-fp not S0~%")
(move old-fp-tmp old-fp)
(storew old-fp-tmp
ebp-tn
- (- (1+ ocfp-save-offset)))))
+ (frame-word-offset ocfp-save-offset))))
((any-reg descriptor-reg)
- (format t "** tail-call old-fp in reg not S0~%")
+ (error "** tail-call old-fp in reg not S0~%")
(storew old-fp
ebp-tn
- (- (1+ ocfp-save-offset)))))
+ (frame-word-offset ocfp-save-offset))))
;; For tail call, we have to push the
;; return-pc so that it looks like we CALLed
,(if variable
'(inst sub esp-tn (fixnumize 3)))
+ ;; Bias the new-fp for use as an fp
+ ,(if variable
+ '(inst sub new-fp (fixnumize sp->fp-offset)))
+
;; Save the fp
- (storew ebp-tn new-fp (- (1+ ocfp-save-offset)))
+ (storew ebp-tn new-fp
+ (frame-word-offset ocfp-save-offset))
(move ebp-tn new-fp) ; NB - now on new stack frame.
)))
+ (when step-instrumenting
+ (emit-single-step-test)
+ (inst jmp :eq DONE)
+ (inst break single-step-around-trap))
+ DONE
+
(note-this-location vop :call-site)
(inst ,(if (eq return :tail) 'jmp 'call)
- (make-ea :dword :base eax
- :disp ,(if named
- '(- (* fdefn-raw-addr-slot
- n-word-bytes)
- other-pointer-lowtag)
- '(- (* closure-fun-slot n-word-bytes)
- fun-pointer-lowtag))))
+ ,(if named
+ '(make-ea-for-object-slot eax fdefn-raw-addr-slot
+ other-pointer-lowtag)
+ '(make-ea-for-object-slot eax closure-fun-slot
+ fun-pointer-lowtag)))
,@(ecase return
(:fixed
- '((default-unknown-values vop values nvals)))
+ '((default-unknown-values vop values nvals node)))
(:unknown
'((note-this-location vop :unknown-return)
- (receive-unknown-values values-start nvals start count)))
+ (receive-unknown-values values-start nvals start count
+ node)))
(:tail))
(trace-table-entry trace-table-normal)))))
(:args (args :scs (any-reg control-stack) :target esi)
(function :scs (descriptor-reg control-stack) :target eax)
(old-fp)
- (ret-addr))
+ (return-pc))
(:temporary (:sc unsigned-reg :offset esi-offset :from (:argument 0)) esi)
(:temporary (:sc unsigned-reg :offset eax-offset :from (:argument 1)) eax)
-; (:ignore ret-addr old-fp)
(:generator 75
+ (check-ocfp-and-return-pc old-fp return-pc)
;; Move these into the passing locations if they are not already there.
(move esi args)
(move eax function)
-
- ;; The following assumes that the return-pc and old-fp are on the
- ;; stack in their standard save locations - Check this.
- (unless (and (sc-is old-fp control-stack)
- (= (tn-offset old-fp) ocfp-save-offset))
- (error "tail-call-variable: ocfp not on stack in standard save location?"))
- (unless (and (sc-is ret-addr sap-stack)
- (= (tn-offset ret-addr) return-pc-save-offset))
- (error "tail-call-variable: ret-addr not on stack in standard save location?"))
-
-
;; And jump to the assembly routine.
(inst jmp (make-fixup 'tail-call-variable :assembly-routine))))
\f
;;;; unknown values return
-;;; Return a single-value using the Unknown-Values convention. Specifically,
-;;; we jump to clear the stack and jump to return-pc+2.
-;;;
-;;; We require old-fp to be in a register, because we want to reset ESP before
-;;; restoring EBP. If old-fp were still on the stack, it could get clobbered
-;;; by a signal.
+;;; Return a single-value using the Unknown-Values convention.
;;;
;;; pfw--get wired-tn conflicts sometimes if register sc specd for args
;;; having problems targeting args to regs -- using temps instead.
+;;;
+;;; First off, modifying the return-pc defeats the branch-prediction
+;;; optimizations on modern CPUs quite handily. Second, we can do all
+;;; this without needing a temp register. Fixed the latter, at least.
+;;; -- AB 2006/Feb/04
(define-vop (return-single)
(:args (old-fp)
(return-pc)
(value))
- (:temporary (:sc unsigned-reg) ofp)
- (:temporary (:sc unsigned-reg) ret)
(:ignore value)
(:generator 6
+ (check-ocfp-and-return-pc old-fp return-pc)
(trace-table-entry trace-table-fun-epilogue)
- (move ret return-pc)
- ;; Clear the control stack
- (move ofp old-fp)
- ;; Adjust the return address for the single value return.
- (inst add ret 2)
- ;; Restore the frame pointer.
- (move esp-tn ebp-tn)
- (move ebp-tn ofp)
- ;; Out of here.
- (inst jmp ret)))
+ ;; Drop stack above old-fp
+ (inst mov esp-tn ebp-tn)
+ ;; Clear the multiple-value return flag
+ (inst clc)
+ ;; Restore the old frame pointer
+ (inst pop ebp-tn)
+ ;; And return.
+ (inst ret)))
;;; Do unknown-values return of a fixed (other than 1) number of
;;; values. The VALUES are required to be set up in the standard
(values :more t))
(:ignore values)
(:info nvals)
-
;; In the case of other than one value, we need these registers to
;; tell the caller where they are and how many there are.
(:temporary (:sc unsigned-reg :offset ebx-offset) ebx)
(:temporary (:sc unsigned-reg :offset ecx-offset) ecx)
-
;; We need to stretch the lifetime of return-pc past the argument
;; registers so that we can default the argument registers without
;; trashing return-pc.
:from :eval) a2)
(:generator 6
+ (check-ocfp-and-return-pc old-fp return-pc)
+ (when (= nvals 1)
+ ;; This is handled in RETURN-SINGLE.
+ (error "nvalues is 1"))
(trace-table-entry trace-table-fun-epilogue)
;; Establish the values pointer and values count.
- (move ebx ebp-tn)
+ (inst lea ebx (make-ea :dword :base ebp-tn
+ :disp (* sp->fp-offset n-word-bytes)))
(if (zerop nvals)
- (inst xor ecx ecx) ; smaller
- (inst mov ecx (fixnumize nvals)))
- ;; Restore the frame pointer.
- (move ebp-tn old-fp)
- ;; Clear as much of the stack as possible, but not past the return
- ;; address.
- (inst lea esp-tn (make-ea :dword :base ebx
- :disp (- (* (max nvals 2) n-word-bytes))))
+ (inst xor ecx ecx) ; smaller
+ (inst mov ecx (fixnumize nvals)))
;; Pre-default any argument register that need it.
(when (< nvals register-arg-count)
(let* ((arg-tns (nthcdr nvals (list a0 a1 a2)))
(inst mov first nil-value)
(dolist (tn (cdr arg-tns))
(inst mov tn first))))
+ ;; Set the multiple value return flag.
+ (inst stc)
;; And away we go. Except that return-pc is still on the
;; stack and we've changed the stack pointer. So we have to
;; tell it to index off of EBX instead of EBP.
- (cond ((zerop nvals)
- ;; Return popping the return address and the OCFP.
- (inst ret n-word-bytes))
- ((= nvals 1)
- ;; Return popping the return, leaving 1 slot. Can this
- ;; happen, or is a single value return handled elsewhere?
+ (cond ((<= nvals register-arg-count)
+ (inst mov esp-tn ebp-tn)
+ (inst pop ebp-tn)
(inst ret))
(t
- (inst jmp (make-ea :dword :base ebx
- :disp (- (* (1+ (tn-offset return-pc))
- n-word-bytes))))))
+ ;; Some values are on the stack after RETURN-PC and OLD-FP,
+ ;; can't return normally and some slots of the frame will
+ ;; be used as temporaries by the receiver.
+ ;;
+ ;; Clear as much of the stack as possible, but not past the
+ ;; old frame address.
+ (inst lea esp-tn
+ (make-ea :dword :base ebp-tn
+ :disp (frame-byte-offset (1- nvals))))
+ (move ebp-tn old-fp)
+ (inst push (make-ea :dword :base ebx
+ :disp (frame-byte-offset
+ (+ sp->fp-offset
+ (tn-offset return-pc)))))
+ (inst ret)))
(trace-table-entry trace-table-normal)))
;;; assembly-routine.
;;;
;;; The assembly routine takes the following args:
-;;; EAX -- the return-pc to finally jump to.
-;;; EBX -- pointer to where to put the values.
;;; ECX -- number of values to find there.
;;; ESI -- pointer to where to find the values.
(define-vop (return-multiple)
- (:args (old-fp :to (:eval 1) :target old-fp-temp)
- (return-pc :target eax)
+ (:args (old-fp)
+ (return-pc)
(vals :scs (any-reg) :target esi)
(nvals :scs (any-reg) :target ecx))
-
- (:temporary (:sc unsigned-reg :offset eax-offset :from (:argument 1)) eax)
(:temporary (:sc unsigned-reg :offset esi-offset :from (:argument 2)) esi)
(:temporary (:sc unsigned-reg :offset ecx-offset :from (:argument 3)) ecx)
- (:temporary (:sc unsigned-reg :offset ebx-offset :from (:eval 0)) ebx)
(:temporary (:sc descriptor-reg :offset (first *register-arg-offsets*)
:from (:eval 0)) a0)
- (:temporary (:sc unsigned-reg :from (:eval 1)) old-fp-temp)
(:node-var node)
-
(:generator 13
+ (check-ocfp-and-return-pc old-fp return-pc)
(trace-table-entry trace-table-fun-epilogue)
- ;; Load the return-pc.
- (move eax return-pc)
(unless (policy node (> space speed))
;; Check for the single case.
(let ((not-single (gen-label)))
(inst cmp nvals (fixnumize 1))
(inst jmp :ne not-single)
-
;; Return with one value.
(loadw a0 vals -1)
- ;; Clear the stack. We load old-fp into a register before clearing
- ;; the stack.
- (move old-fp-temp old-fp)
- (move esp-tn ebp-tn)
- (move ebp-tn old-fp-temp)
- ;; Fix the return-pc to point at the single-value entry point.
- (inst add eax 2)
+ ;; Clear the stack until ocfp.
+ (inst mov esp-tn ebp-tn)
+ ;; clear the multiple-value return flag
+ (inst clc)
;; Out of here.
- (inst jmp eax)
-
+ (inst pop ebp-tn)
+ (inst ret)
;; Nope, not the single case. Jump to the assembly routine.
(emit-label not-single)))
(move esi vals)
(move ecx nvals)
- (move ebx ebp-tn)
- (move ebp-tn old-fp)
(inst jmp (make-fixup 'return-multiple :assembly-routine))
(trace-table-entry trace-table-normal)))
\f
;;;
;;; EAX -- The lexenv.
;;; EBX -- Available.
-;;; ECX -- The total number of arguments.
+;;; ECX -- The total number of arguments * N-WORD-BYTES.
;;; EDX -- The first arg.
;;; EDI -- The second arg.
;;; ESI -- The third arg.
(:generator 20
;; Avoid the copy if there are no more args.
(cond ((zerop fixed)
- (inst jecxz just-alloc-frame))
+ (inst jecxz JUST-ALLOC-FRAME))
(t
(inst cmp ecx-tn (fixnumize fixed))
- (inst jmp :be just-alloc-frame)))
+ (inst jmp :be JUST-ALLOC-FRAME)))
;; Allocate the space on the stack.
- ;; stack = ebp - (max 3 frame-size) - (nargs - fixed)
+ ;; stack = ebp + sp->fp-offset - (max 3 frame-size) - (nargs - fixed)
(inst lea ebx-tn
(make-ea :dword :base ebp-tn
- :disp (- (fixnumize fixed)
- (* n-word-bytes
+ :disp (* n-word-bytes
+ (- (+ sp->fp-offset fixed)
(max 3 (sb-allocated-size 'stack))))))
(inst sub ebx-tn ecx-tn) ; Got the new stack in ebx
(inst mov esp-tn ebx-tn)
;; Number to copy = nargs-3
(inst sub ecx-tn (fixnumize register-arg-count))
;; Everything of interest in registers.
- (inst jmp :be do-regs))
+ (inst jmp :be DO-REGS))
(t
;; Number to copy = nargs-fixed
(inst sub ecx-tn (fixnumize fixed))))
;; Save edi and esi register args.
(inst push edi-tn)
(inst push esi-tn)
+ (inst push ebx-tn)
;; Okay, we have pushed the register args. We can trash them
;; now.
- ;; Initialize dst to be end of stack; skiping the values pushed
- ;; above.
- (inst lea edi-tn (make-ea :dword :base esp-tn :disp 8))
-
;; Initialize src to be end of args.
- (inst mov esi-tn ebp-tn)
+ (inst lea esi-tn (make-ea :dword :base ebp-tn
+ :disp (* sp->fp-offset n-word-bytes)))
(inst sub esi-tn ebx-tn)
- (inst shr ecx-tn word-shift) ; make word count
- ;; And copy the args.
- (inst cld) ; auto-inc ESI and EDI.
- (inst rep)
- (inst movs :dword)
+ ;; We need to copy from downwards up to avoid overwriting some of
+ ;; the yet uncopied args. So we need to use EBX as the copy index
+ ;; and ECX as the loop counter, rather than using ECX for both.
+ (inst xor ebx-tn ebx-tn)
+
+ ;; We used to use REP MOVS here, but on modern x86 it performs
+ ;; much worse than an explicit loop for small blocks.
+ COPY-LOOP
+ (inst mov edi-tn (make-ea :dword :base esi-tn :index ebx-tn))
+ ;; The :DISP is to account for the registers saved on the stack
+ (inst mov (make-ea :dword :base esp-tn :disp (* 3 n-word-bytes)
+ :index ebx-tn)
+ edi-tn)
+ (inst add ebx-tn n-word-bytes)
+ (inst sub ecx-tn n-word-bytes)
+ (inst jmp :nz COPY-LOOP)
;; So now we need to restore EDI and ESI.
+ (inst pop ebx-tn)
(inst pop esi-tn)
(inst pop edi-tn)
;; Here: nargs>=1 && nargs>fixed
(when (< fixed register-arg-count)
- ;; Now we have to deposit any more args that showed up in
- ;; registers.
- (do ((i fixed))
- ( nil )
- ;; Store it relative to ebp
- (inst mov (make-ea :dword :base ebp-tn
- :disp (- (* 4
- (+ 1 (- i fixed)
- (max 3 (sb-allocated-size 'stack))))))
- (nth i *register-arg-tns*))
-
- (incf i)
- (when (>= i register-arg-count)
- (return))
-
- ;; Don't deposit any more than there are.
- (if (zerop i)
- (inst test ecx-tn ecx-tn)
- (inst cmp ecx-tn (fixnumize i)))
- (inst jmp :eq done)))
-
- (inst jmp done)
+ ;; Now we have to deposit any more args that showed up in
+ ;; registers.
+ (do ((i fixed))
+ ( nil )
+ ;; Store it relative to ebp
+ (inst mov (make-ea :dword :base ebp-tn
+ :disp (* n-word-bytes
+ (- sp->fp-offset
+ (+ 1
+ (- i fixed)
+ (max 3 (sb-allocated-size
+ 'stack))))))
+ (nth i *register-arg-tns*))
+
+ (incf i)
+ (when (>= i register-arg-count)
+ (return))
+
+ ;; Don't deposit any more than there are.
+ (if (zerop i)
+ (inst test ecx-tn ecx-tn)
+ (inst cmp ecx-tn (fixnumize i)))
+ (inst jmp :eq DONE)))
+
+ (inst jmp DONE)
JUST-ALLOC-FRAME
(inst lea esp-tn
(make-ea :dword :base ebp-tn
- :disp (- (* n-word-bytes
+ :disp (* n-word-bytes
+ (- sp->fp-offset
(max 3 (sb-allocated-size 'stack))))))
DONE))
-;;; &MORE args are stored contiguously on the stack, starting
-;;; immediately at the context pointer. The context pointer is not
-;;; typed, so the lowtag is 0.
-(define-vop (more-arg)
- (:translate %more-arg)
+(define-vop (more-kw-arg)
+ (:translate sb!c::%more-kw-arg)
(:policy :fast-safe)
- (:args (object :scs (descriptor-reg) :to :result)
- (index :scs (any-reg) :target temp))
+ (:args (object :scs (descriptor-reg) :to (:result 1))
+ (index :scs (any-reg immediate) :to (:result 1) :target keyword))
(:arg-types * tagged-num)
- (:temporary (:sc unsigned-reg :from (:argument 1) :to :result) temp)
- (:results (value :scs (any-reg descriptor-reg)))
- (:result-types *)
- (:generator 5
- (move temp index)
- (inst neg temp)
- (inst mov value (make-ea :dword :base object :index temp))))
+ (:results (value :scs (descriptor-reg any-reg))
+ (keyword :scs (descriptor-reg any-reg)))
+ (:result-types * *)
+ (:generator 4
+ (sc-case index
+ (immediate
+ (inst mov value (make-ea :dword :base object :disp (tn-value index)))
+ (inst mov keyword (make-ea :dword :base object
+ :disp (+ (tn-value index) n-word-bytes))))
+ (t
+ (inst mov value (make-ea :dword :base object :index index))
+ (inst mov keyword (make-ea :dword :base object :index index
+ :disp n-word-bytes))))))
-(define-vop (more-arg-c)
- (:translate %more-arg)
+(define-vop (more-arg)
+ (:translate sb!c::%more-arg)
(:policy :fast-safe)
- (:args (object :scs (descriptor-reg)))
- (:info index)
- (:arg-types * (:constant (signed-byte 30)))
- (:results (value :scs (any-reg descriptor-reg)))
+ (:args (object :scs (descriptor-reg) :to (:result 1))
+ (index :scs (any-reg) :to (:result 1) :target value))
+ (:arg-types * tagged-num)
+ (:results (value :scs (descriptor-reg any-reg)))
(:result-types *)
(:generator 4
- (inst mov value
- (make-ea :dword :base object :disp (- (* index n-word-bytes))))))
-
+ (move value index)
+ (inst neg value)
+ (inst mov value (make-ea :dword :base object :index value))))
;;; Turn more arg (context, count) into a list.
-(defoptimizer (%listify-rest-args stack-allocate-result) ((&rest args))
- t)
-
(define-vop (listify-rest-args)
(:translate %listify-rest-args)
(:policy :safe)
;; Check to see whether there are no args, and just return NIL if so.
(inst mov result nil-value)
(inst jecxz done)
- (inst lea dst (make-ea :dword :index ecx :scale 2))
+ (inst lea dst (make-ea :dword :base ecx :index ecx))
(maybe-pseudo-atomic stack-allocate-p
- (allocation dst dst node stack-allocate-p)
- (inst lea dst (make-ea :byte :base dst :disp list-pointer-lowtag))
- ;; Convert the count into a raw value, so that we can use the
- ;; LOOP instruction.
- (inst shr ecx 2)
+ (allocation dst dst node stack-allocate-p list-pointer-lowtag)
;; Set decrement mode (successive args at lower addresses)
(inst std)
;; Set up the result.
(move result dst)
- ;; Jump into the middle of the loop, 'cause that's were we want
+ ;; Jump into the middle of the loop, 'cause that's where we want
;; to start.
(inst jmp enter)
(emit-label loop)
(inst lods eax)
(storew eax dst 0 list-pointer-lowtag)
;; Go back for more.
- (inst loop loop)
+ (inst sub ecx n-word-bytes)
+ (inst jmp :nz loop)
;; NIL out the last cons.
- (storew nil-value dst 1 list-pointer-lowtag))
+ (storew nil-value dst 1 list-pointer-lowtag)
+ (inst cld))
(emit-label done))))
;;; Return the location and size of the &MORE arg glob created by
;; Point to the first more-arg, not above it.
(inst lea context (make-ea :dword :base esp-tn
:index count :scale 1
- :disp (- (+ (fixnumize fixed) 4))))
+ :disp (- (+ (fixnumize fixed) n-word-bytes))))
(unless (zerop fixed)
(inst sub count (fixnumize fixed)))))
(:save-p :compute-only)
(:generator 3
(let ((err-lab
- (generate-error-code vop invalid-arg-count-error nargs)))
+ (generate-error-code vop 'invalid-arg-count-error nargs)))
(if (zerop count)
(inst test nargs nargs) ; smaller instruction
(inst cmp nargs (fixnumize count)))
(:vop-var vop)
(:save-p :compute-only)
(:generator 1000
- (error-call vop ,error ,@args)))))
+ (error-call vop ',error ,@args)))))
(def arg-count-error invalid-arg-count-error
sb!c::%arg-count-error nargs)
(def type-check-error object-not-type-error sb!c::%type-check-error
(def unknown-key-arg-error unknown-key-arg-error
sb!c::%unknown-key-arg-error key)
(def nil-fun-returned-error nil-fun-returned-error nil fun))
+
+;;; Single-stepping
+
+(defun emit-single-step-test ()
+ ;; We use different ways of representing whether stepping is on on
+ ;; +SB-THREAD / -SB-THREAD: on +SB-THREAD, we use a slot in the
+ ;; thread structure. On -SB-THREAD we use the value of a static
+ ;; symbol. Things are done this way, since reading a thread-local
+ ;; slot from a symbol would require an extra register on +SB-THREAD,
+ ;; and reading a slot from a thread structure would require an extra
+ ;; register on -SB-THREAD.
+ #!+sb-thread
+ (progn
+ (inst cmp (make-ea :dword
+ :disp (* thread-stepping-slot n-word-bytes))
+ nil-value :fs))
+ #!-sb-thread
+ (inst cmp (make-ea-for-symbol-value sb!impl::*stepping*)
+ nil-value))
+
+(define-vop (step-instrument-before-vop)
+ (:policy :fast-safe)
+ (:vop-var vop)
+ (:generator 3
+ (emit-single-step-test)
+ (inst jmp :eq DONE)
+ (inst break single-step-before-trap)
+ DONE
+ (note-this-location vop :step-before-vop)))
projects / sbcl.git / blobdiff