;;; Move an untagged char to a tagged representation.
#!+sb-unicode
(define-vop (move-from-character)
- (:args (x :scs (character-reg)))
+ (:args (x :scs (character-reg) :target y))
(:results (y :scs (any-reg descriptor-reg)))
(:note "character tagging")
(:generator 1
- ;; FIXME: is this inefficient? Is there a better way of writing
- ;; it? (fixnum tagging is done with LEA). We can't use SHL
- ;; because we either scribble over the source register or briefly
- ;; have a non-descriptor in a descriptor register, unless we
- ;; introduce a temporary.
- (inst imul y x (ash 1 n-widetag-bits))
+ (move y x)
+ (inst shl y n-widetag-bits)
(inst or y character-widetag)))
#!-sb-unicode
(define-vop (move-from-character)
(character-stack
#!-sb-unicode
(inst mov
- (make-ea :byte :base fp :disp (- (* (1+ (tn-offset y)) 4)))
+ ;; XXX: If the sb-unicode case needs to handle c-call,
+ ;; why does the non-unicode case not need to?
+ (make-ea :byte :base fp :disp (frame-byte-offset (tn-offset y)))
x)
#!+sb-unicode
(if (= (tn-offset fp) esp-offset)
(storew x fp (tn-offset y)) ; c-call
- (storew x fp (- (1+ (tn-offset y)))))))))
+ (storew x fp (frame-word-offset (tn-offset y))))))))
(define-move-vop move-character-arg :move-arg
(any-reg character-reg) (character-reg))
(define-vop (char-code)
(:translate char-code)
(:policy :fast-safe)
- (:args (ch :scs (character-reg character-stack)))
+ (:args #!-sb-unicode (ch :scs (character-reg character-stack))
+ #!+sb-unicode (ch :scs (character-reg character-stack) :target res))
(:arg-types character)
(:results (res :scs (unsigned-reg)))
(:result-types positive-fixnum)
#!-sb-unicode
(inst movzx res ch)
#!+sb-unicode
- (inst mov res ch)))
+ (move res ch)))
#!+sb-unicode
(define-vop (code-char)
(:translate code-char)
(:policy :fast-safe)
- (:args (code :scs (unsigned-reg unsigned-stack)))
+ (:args (code :scs (unsigned-reg unsigned-stack) :target res))
(:arg-types positive-fixnum)
(:results (res :scs (character-reg)))
(:result-types character)
(:generator 1
- (inst mov res code)))
+ (move res code)))
#!-sb-unicode
(define-vop (code-char)
(:translate code-char)