\f
;;;; test generation utilities
+;;; Optimize the case of moving a 64-bit value into RAX when not caring
+;;; about the upper 32 bits: often the REX prefix can be spared.
+(defun move-qword-to-eax (value)
+ (if (and (sc-is value any-reg descriptor-reg)
+ (< (tn-offset value) r8-offset))
+ (move eax-tn (make-dword-tn value))
+ (move rax-tn value)))
+
(defun generate-fixnum-test (value)
"zero flag set if VALUE is fixnum"
(inst test
(make-byte-tn value))
((sc-is value control-stack)
(make-ea :byte :base rbp-tn
- :disp (- (* (1+ (tn-offset value)) n-word-bytes))))
+ :disp (frame-byte-offset (tn-offset value))))
(t
value))
sb!vm::fixnum-tag-mask))
(%test-headers value target not-p nil headers drop-through))
(defun %test-lowtag (value target not-p lowtag)
- (if (and (sc-is value any-reg descriptor-reg)
- (< (tn-offset value) r8-offset))
- (move eax-tn (make-dword-tn value)) ; shorter encoding (no REX prefix)
- (move rax-tn value))
+ (move-qword-to-eax value)
(inst and al-tn lowtag-mask)
(inst cmp al-tn lowtag)
(inst jmp (if not-p :ne :e) target))
(defun %test-headers (value target not-p function-p headers
&optional (drop-through (gen-label)))
(let ((lowtag (if function-p fun-pointer-lowtag other-pointer-lowtag)))
- (multiple-value-bind (equal less-or-equal when-true when-false)
- ;; EQUAL and LESS-OR-EQUAL are the conditions for branching to TARGET.
- ;; WHEN-TRUE and WHEN-FALSE are the labels to branch to when we know
- ;; it's true and when we know it's false respectively.
+ (multiple-value-bind (equal less-or-equal greater-or-equal when-true
+ when-false)
+ ;; EQUAL, LESS-OR-EQUAL, and GREATER-OR-EQUAL are the conditions
+ ;; for branching to TARGET. WHEN-TRUE and WHEN-FALSE are the
+ ;; labels to branch to when we know it's true and when we know
+ ;; it's false respectively.
(if not-p
- (values :ne :a drop-through target)
- (values :e :na target drop-through))
+ (values :ne :a :b drop-through target)
+ (values :e :na :nb target drop-through))
(%test-lowtag value when-false t lowtag)
- (inst mov al-tn (make-ea :byte :base value :disp (- lowtag)))
- (do ((remaining headers (cdr remaining)))
+ (do ((remaining headers (cdr remaining))
+ ;; It is preferable (smaller and faster code) to directly
+ ;; compare the value in memory instead of loading it into
+ ;; a register first. Find out if this is possible and set
+ ;; WIDETAG-TN accordingly. If impossible, generate the
+ ;; register load.
+ ;; Compared to x86 we additionally optimize the cases of a
+ ;; range starting with BIGNUM-WIDETAG or ending with
+ ;; COMPLEX-ARRAY-WIDETAG.
+ (widetag-tn (if (and (null (cdr headers))
+ (or (atom (car headers))
+ (= (caar headers) bignum-widetag)
+ (= (cdar headers) complex-array-widetag)))
+ (make-ea :byte :base value :disp (- lowtag))
+ (progn
+ (inst mov eax-tn (make-ea :dword :base value
+ :disp (- lowtag)))
+ al-tn))))
((null remaining))
(let ((header (car remaining))
(last (null (cdr remaining))))
(cond
((atom header)
- (inst cmp al-tn header)
+ (inst cmp widetag-tn header)
(if last
(inst jmp equal target)
(inst jmp :e when-true)))
(t
(let ((start (car header))
(end (cdr header)))
- (unless (= start bignum-widetag)
- (inst cmp al-tn start)
- (inst jmp :b when-false)) ; was :l
- (inst cmp al-tn end)
- (if last
- (inst jmp less-or-equal target)
- (inst jmp :be when-true))))))) ; was :le
+ (cond
+ ((= start bignum-widetag)
+ (inst cmp widetag-tn end)
+ (if last
+ (inst jmp less-or-equal target)
+ (inst jmp :be when-true)))
+ ((= end complex-array-widetag)
+ (inst cmp widetag-tn start)
+ (if last
+ (inst jmp greater-or-equal target)
+ (inst jmp :b when-false)))
+ ((not last)
+ (inst cmp al-tn start)
+ (inst jmp :b when-false)
+ (inst cmp al-tn end)
+ (inst jmp :be when-true))
+ (t
+ (inst sub al-tn start)
+ (inst cmp al-tn (- end start))
+ (inst jmp less-or-equal target))))))))
(emit-label drop-through))))
\f
(inst mov tmp value)
(inst shr tmp n-positive-fixnum-bits)))
+(define-vop (fixnump/signed-byte-64 type-predicate)
+ (:args (value :scs (signed-reg)))
+ (:info)
+ (:conditional #.(if (= sb!vm:n-fixnum-tag-bits 1) :ns :z))
+ (:arg-types signed-num)
+ (:translate fixnump)
+ (:generator 5
+ ;; Hackers Delight, p. 53: signed
+ ;; a <= x <= a + 2^n - 1
+ ;; is equivalent to unsigned
+ ;; ((x-a) >> n) = 0
+ (inst mov rax-tn #.(- sb!xc:most-negative-fixnum))
+ (inst add rax-tn value)
+ (unless (= n-fixnum-tag-bits 1)
+ (inst shr rax-tn n-fixnum-bits))))
+
;;; A (SIGNED-BYTE 64) can be represented with either fixnum or a bignum with
;;; exactly one digit.
(values target not-target))
(generate-fixnum-test value)
(inst jmp :e yep)
- (move rax-tn value)
+ (move-qword-to-eax value)
(inst and al-tn lowtag-mask)
(inst cmp al-tn other-pointer-lowtag)
(inst jmp :ne nope)
- (loadw rax-tn value 0 other-pointer-lowtag)
- (inst cmp rax-tn (+ (ash 1 n-widetag-bits) bignum-widetag))
+ (inst cmp (make-ea-for-object-slot value 0 other-pointer-lowtag)
+ (+ (ash 1 n-widetag-bits) bignum-widetag))
(inst jmp (if not-p :ne :e) target))
NOT-TARGET))
value)))
(generate-fixnum-test value)
(inst jmp :e yep)
- (move rax-tn value)
+ (move-qword-to-eax value)
(inst and al-tn lowtag-mask)
(inst cmp al-tn other-pointer-lowtag)
(inst jmp :ne nope)
- (loadw rax-tn value 0 other-pointer-lowtag)
- (inst cmp rax-tn (+ (ash 1 n-widetag-bits) bignum-widetag))
+ (inst cmp (make-ea-for-object-slot value 0 other-pointer-lowtag)
+ (+ (ash 1 n-widetag-bits) bignum-widetag))
(inst jmp :ne nope))
YEP
(move result value)))
(inst jmp :e fixnum)
;; If not, is it an other pointer?
- (inst and rax-tn lowtag-mask)
- (inst cmp rax-tn other-pointer-lowtag)
+ (inst and al-tn lowtag-mask)
+ (inst cmp al-tn other-pointer-lowtag)
(inst jmp :ne nope)
;; Get the header.
(loadw rax-tn value 0 other-pointer-lowtag)
;; Get the second digit.
(loadw rax-tn value (1+ bignum-digits-offset) other-pointer-lowtag)
;; All zeros, its an (unsigned-byte 64).
- (inst or rax-tn rax-tn)
+ (inst test rax-tn rax-tn)
(inst jmp :z yep)
(inst jmp nope)
;; positive implies (unsigned-byte 64).
(emit-label fixnum)
- (inst or rax-tn rax-tn)
+ (inst test rax-tn rax-tn)
(inst jmp (if not-p :s :ns) target)
(emit-label not-target)))))
(inst jmp :e fixnum)
;; If not, is it an other pointer?
- (inst and rax-tn lowtag-mask)
- (inst cmp rax-tn other-pointer-lowtag)
+ (inst and al-tn lowtag-mask)
+ (inst cmp al-tn other-pointer-lowtag)
(inst jmp :ne nope)
;; Get the header.
(loadw rax-tn value 0 other-pointer-lowtag)
;; Get the second digit.
(loadw rax-tn value (1+ bignum-digits-offset) other-pointer-lowtag)
;; All zeros, its an (unsigned-byte 64).
- (inst or rax-tn rax-tn)
+ (inst test rax-tn rax-tn)
(inst jmp :z yep)
(inst jmp nope)
;; positive implies (unsigned-byte 64).
(emit-label fixnum)
- (inst or rax-tn rax-tn)
+ (inst test rax-tn rax-tn)
(inst jmp :s nope)
(emit-label yep)
projects / sbcl.git / blobdiff