;;;; warranty about the software, its performance or its conformity to any
;;;; specification.
-(in-package "SB-PCL")
-\f
-;;; Ye olde CMUCL comment follows, but it seems likely that the paper
-;;; that would be inserted would resemble Kiczales and Rodruigez,
-;;; Efficient Method Dispatch in PCL, ACM 1990. Some of the details
-;;; changed between that paper and "May Day PCL" of 1992; some other
-;;; details have changed since, but reading that paper gives the broad
-;;; idea.
-;;;
-;;; The caching algorithm implemented:
-;;;
-;;; << put a paper here >>
-;;;
-;;; For now, understand that as far as most of this code goes, a cache
-;;; has two important properties. The first is the number of wrappers
-;;; used as keys in each cache line. Throughout this code, this value
-;;; is always called NKEYS. The second is whether or not the cache
-;;; lines of a cache store a value. Throughout this code, this always
-;;; called VALUEP.
-;;;
-;;; Depending on these values, there are three kinds of caches.
-;;;
-;;; NKEYS = 1, VALUEP = NIL
-;;;
-;;; In this kind of cache, each line is 1 word long. No cache locking
-;;; is needed since all read's in the cache are a single value.
-;;; Nevertheless line 0 (location 0) is reserved, to ensure that
-;;; invalid wrappers will not get a first probe hit.
-;;;
-;;; To keep the code simpler, a cache lock count does appear in
-;;; location 0 of these caches, that count is incremented whenever
-;;; data is written to the cache. But, the actual lookup code (see
-;;; make-dlap) doesn't need to do locking when reading the cache.
-;;;
-;;; NKEYS = 1, VALUEP = T
-;;;
-;;; In this kind of cache, each line is 2 words long. Cache locking
-;;; must be done to ensure the synchronization of cache reads. Line 0
-;;; of the cache (location 0) is reserved for the cache lock count.
-;;; Location 1 of the cache is unused (in effect wasted).
-;;;
-;;; NKEYS > 1
-;;;
-;;; In this kind of cache, the 0 word of the cache holds the lock
-;;; count. The 1 word of the cache is line 0. Line 0 of these caches
-;;; is not reserved.
-;;;
-;;; This is done because in this sort of cache, the overhead of doing
-;;; the cache probe is high enough that the 1+ required to offset the
-;;; location is not a significant cost. In addition, because of the
-;;; larger line sizes, the space that would be wasted by reserving
-;;; line 0 to hold the lock count is more significant.
-\f
-;;; caches
-;;;
-;;; A cache is essentially just a vector. The use of the individual
-;;; `words' in the vector depends on particular properties of the
-;;; cache as described above.
-;;;
-;;; This defines an abstraction for caches in terms of their most
-;;; obvious implementation as simple vectors. But, please notice that
-;;; part of the implementation of this abstraction, is the function
-;;; lap-out-cache-ref. This means that most port-specific
-;;; modifications to the implementation of caches will require
-;;; corresponding port-specific modifications to the lap code
-;;; assembler.
-(defmacro cache-vector-ref (cache-vector location)
- `(svref (the simple-vector ,cache-vector)
- (sb-ext:truly-the fixnum ,location)))
-
-(defmacro cache-vector-size (cache-vector)
- `(array-dimension (the simple-vector ,cache-vector) 0))
-
-(defmacro cache-vector-lock-count (cache-vector)
- `(cache-vector-ref ,cache-vector 0))
+;;;; Note: as of SBCL 1.0.6.3 it is questionable if cache.lisp can
+;;;; anymore be considered to be "derived from software originally
+;;;; released by Xerox Corporation", as at that time the whole cache
+;;;; implementation was essentially redone from scratch.
-(defun flush-cache-vector-internal (cache-vector)
- ;; FIXME: To my eye this PCL-LOCK implies we should be holding the
- ;; lock whenever we play with any cache vector, which doesn't seem
- ;; to be true. On the other hand that would be too expensive as
- ;; well, since it would mean serialization across all GFs.
- (with-pcl-lock
- (fill (the simple-vector cache-vector) nil)
- (setf (cache-vector-lock-count cache-vector) 0))
- cache-vector)
-
-;;; Return an empty cache vector
-(defun get-cache-vector (size)
- (declare (type (and unsigned-byte fixnum) size))
- (let ((cv (make-array size :initial-element nil)))
- (setf (cache-vector-lock-count cv) 0)
- cv))
-
-(defmacro modify-cache (cache-vector &body body)
- `(with-pcl-lock
- ;; This locking scheme is less the sufficient, and not what the
- ;; PCL implementors had planned: apparently we should increment
- ;; the lock count atomically, and all cache users should check
- ;; the count before and after they touch cache: if the counts
- ;; match the cache was not altered, if they don't match the
- ;; work needs to be redone.
- ;;
- ;; We probably want to re-engineer things so that the whole
- ;; cache vector gets replaced atomically when we do things
- ;; to it that could affect others.
- (multiple-value-prog1
- (progn ,@body)
- (let ((old-count (cache-vector-lock-count ,cache-vector)))
- (declare (fixnum old-count))
- (setf (cache-vector-lock-count ,cache-vector)
- (if (= old-count most-positive-fixnum)
- 1
- (1+ old-count)))))))
-
-(eval-when (:compile-toplevel :load-toplevel :execute)
- (declaim (ftype (function (fixnum) (values (and unsigned-byte fixnum) &optional))
- power-of-two-ceiling))
- (defun power-of-two-ceiling (x)
- ;; (expt 2 (ceiling (log x 2)))
- (ash 1 (integer-length (1- x)))))
-
-;;; FIXME: We should probably keep just one of these -- or at least use just
-;;; one.
-(declaim (inline compute-line-size))
-(defun compute-line-size (x)
- (power-of-two-ceiling x))
-
-(defconstant +nkeys-limit+ 256)
+(in-package "SB-PCL")
-(defstruct (cache (:constructor make-cache ())
- (:copier copy-cache-internal))
- (owner nil)
- (nkeys 1 :type (integer 1 #.+nkeys-limit+))
- (valuep nil :type (member nil t))
- (nlines 0 :type fixnum)
- (limit-fn #'default-limit-fn :type function)
- (mask 0 :type fixnum)
- (size 0 :type fixnum)
- (line-size 1 :type (integer 1 #.(power-of-two-ceiling (1+ +nkeys-limit+))))
- (max-location 0 :type fixnum)
+;;;; Public API:
+;;;;
+;;;; fill-cache
+;;;; probe-cache
+;;;; make-cache
+;;;; map-cache
+;;;; emit-cache-lookup
+;;;; copy-cache
+;;;; hash-table-to-cache
+;;;;
+;;;; This is a thread and interrupt safe reimplementation loosely
+;;;; based on the original PCL cache by Kickzales and Rodrigues,
+;;;; as described in "Efficient Method Dispatch in PCL".
+;;;;
+;;;; * Writes to cache are made atomic using compare-and-swap on
+;;;; wrappers. Wrappers are never moved or deleted after they have
+;;;; been written: to clean them out the cache need to be copied.
+;;;;
+;;;; * Copying or expanding the cache drops out incomplete and invalid
+;;;; lines.
+;;;;
+;;;; * Since the cache is used for memoization only we don't need to
+;;;; worry about which of simultaneous replacements (when expanding
+;;;; the cache) takes place: the loosing one will have its work
+;;;; redone later. This also allows us to drop entries when the
+;;;; cache is about to grow insanely huge.
+;;;;
+;;;; The cache is essentially a specialized hash-table for layouts, used
+;;;; for memoization of effective methods, slot locations, and constant
+;;;; return values.
+;;;;
+;;;; Subsequences of the cache vector are called cache lines.
+;;;;
+;;;; The cache vector uses the symbol SB-PCL::..EMPTY.. as a sentinel
+;;;; value, to allow storing NILs in the vector as well.
+
+(defstruct (cache (:constructor %make-cache)
+ (:copier %copy-cache))
+ ;; Number of keys the cache uses.
+ (key-count 1 :type (integer 1 (#.call-arguments-limit)))
+ ;; True if we store values in the cache.
+ (value)
+ ;; Number of vector elements a single cache line uses in the vector.
+ ;; This is always a power of two, so that the vector length can be both
+ ;; an exact multiple of this and a power of two.
+ (line-size 1 :type (integer 1 #.most-positive-fixnum))
+ ;; Cache vector, its length is always both a multiple of line-size
+ ;; and a power of two. This is so that we can calculate
+ ;; (mod index (length vector))
+ ;; using a bitmask.
(vector #() :type simple-vector)
- (overflow nil :type list))
-
-#-sb-fluid (declaim (sb-ext:freeze-type cache))
-\f
-;;;; wrapper cache numbers
-
-;;; The constant WRAPPER-CACHE-NUMBER-ADDS-OK controls the number of
-;;; non-zero bits wrapper cache numbers will have.
-;;;
-;;; The value of this constant is the number of wrapper cache numbers
-;;; which can be added and still be certain the result will be a
-;;; fixnum. This is used by all the code that computes primary cache
-;;; locations from multiple wrappers.
-;;;
-;;; The value of this constant is used to derive the next two which
-;;; are the forms of this constant which it is more convenient for the
-;;; runtime code to use.
-(defconstant wrapper-cache-number-length
- (integer-length (1- layout-clos-hash-limit)))
-(defconstant wrapper-cache-number-mask (1- layout-clos-hash-limit))
-(defconstant wrapper-cache-number-adds-ok
- (truncate most-positive-fixnum (1- layout-clos-hash-limit)))
-\f
-;;;; wrappers themselves
-
-;;; FIXME: delete this comment, possibly replacing it with a reference
-;;; to Kiczales and Rodruigez
-;;;
-;;; This caching algorithm requires that wrappers have more than one
-;;; wrapper cache number. You should think of these multiple numbers
-;;; as being in columns. That is, for a given cache, the same column
-;;; of wrapper cache numbers will be used.
-;;;
-;;; If at some point the cache distribution of a cache gets bad, the
-;;; cache can be rehashed by switching to a different column.
-;;;
-;;; The columns are referred to by field number which is that number
-;;; which, when used as a second argument to wrapper-ref, will return
-;;; that column of wrapper cache number.
-;;;
-;;; This code is written to allow flexibility as to how many wrapper
-;;; cache numbers will be in each wrapper, and where they will be
-;;; located. It is also set up to allow port specific modifications to
-;;; `pack' the wrapper cache numbers on machines where the addressing
-;;; modes make that a good idea.
-
-(unless (boundp '*the-class-t*)
- (setq *the-class-t* nil))
-
-(defun get-cache (nkeys valuep limit-fn nlines)
- (let ((cache (make-cache)))
- (declare (type cache cache))
- (multiple-value-bind (cache-mask actual-size line-size nlines)
- (compute-cache-parameters nkeys valuep nlines)
- (setf (cache-nkeys cache) nkeys
- (cache-valuep cache) valuep
- (cache-nlines cache) nlines
- (cache-limit-fn cache) limit-fn
- (cache-mask cache) cache-mask
- (cache-size cache) actual-size
- (cache-line-size cache) line-size
- (cache-max-location cache) (let ((line (1- nlines)))
- (if (= nkeys 1)
- (* line line-size)
- (1+ (* line line-size))))
- (cache-vector cache) (get-cache-vector actual-size)
- (cache-overflow cache) nil)
- cache)))
-
-(defun get-cache-from-cache (old-cache new-nlines)
- (let ((nkeys (cache-nkeys old-cache))
- (valuep (cache-valuep old-cache))
- (cache (make-cache)))
- (declare (type cache cache))
- (multiple-value-bind (cache-mask actual-size line-size nlines)
- (if (= new-nlines (cache-nlines old-cache))
- (values (cache-mask old-cache) (cache-size old-cache)
- (cache-line-size old-cache) (cache-nlines old-cache))
- (compute-cache-parameters nkeys valuep new-nlines))
- (setf (cache-owner cache) (cache-owner old-cache)
- (cache-nkeys cache) nkeys
- (cache-valuep cache) valuep
- (cache-nlines cache) nlines
- (cache-limit-fn cache) (cache-limit-fn old-cache)
- (cache-mask cache) cache-mask
- (cache-size cache) actual-size
- (cache-line-size cache) line-size
- (cache-max-location cache) (let ((line (1- nlines)))
- (if (= nkeys 1)
- (* line line-size)
- (1+ (* line line-size))))
- (cache-vector cache) (get-cache-vector actual-size)
- (cache-overflow cache) nil)
- cache)))
-
-(defun copy-cache (old-cache)
- (let* ((new-cache (copy-cache-internal old-cache))
- (size (cache-size old-cache))
- (old-vector (cache-vector old-cache))
- (new-vector (get-cache-vector size)))
- (declare (simple-vector old-vector new-vector))
- (dotimes-fixnum (i size)
- (setf (svref new-vector i) (svref old-vector i)))
- (setf (cache-vector new-cache) new-vector)
- new-cache))
-
-(defun compute-cache-parameters (nkeys valuep nlines-or-cache-vector)
- ;;(declare (values cache-mask actual-size line-size nlines))
- (declare (fixnum nkeys))
- (if (= nkeys 1)
- (let* ((line-size (if valuep 2 1))
- (cache-size (etypecase nlines-or-cache-vector
- (fixnum
- (* line-size
- (power-of-two-ceiling nlines-or-cache-vector)))
- (vector
- (cache-vector-size nlines-or-cache-vector)))))
- (declare (type (and unsigned-byte fixnum) line-size cache-size))
- (values (logxor (1- cache-size) (1- line-size))
- cache-size
- line-size
- (floor cache-size line-size)))
- (let* ((line-size (power-of-two-ceiling (if valuep (1+ nkeys) nkeys)))
- (cache-size (etypecase nlines-or-cache-vector
- (fixnum
- (* line-size
- (power-of-two-ceiling nlines-or-cache-vector)))
- (vector
- (1- (cache-vector-size nlines-or-cache-vector))))))
- (declare (fixnum line-size cache-size))
- (values (logxor (1- cache-size) (1- line-size))
- (1+ cache-size)
- line-size
- (floor cache-size line-size)))))
-\f
-;;; the various implementations of computing a primary cache location from
-;;; wrappers. Because some implementations of this must run fast there are
-;;; several implementations of the same algorithm.
-;;;
-;;; The algorithm is:
+ ;; The bitmask used to calculate (mod index (length vector))l
+ (mask 0 :type fixnum)
+ ;; Current probe-depth needed in the cache.
+ (depth 0 :type index)
+ ;; Maximum allowed probe-depth before the cache needs to expand.
+ (limit 0 :type index))
+
+;;; The smallest power of two that is equal to or greater then X.
+(declaim (inline power-of-two-ceiling))
+(defun power-of-two-ceiling (x)
+ (ash 1 (integer-length (1- x))))
+
+;;; Don't allocate insanely huge caches.
+(defconstant +cache-vector-max-length+ (expt 2 14))
+
+;;; Compute the maximum allowed probe depth as a function of cache size.
+;;; Cache size refers to number of cache lines, not the length of the
+;;; cache vector.
;;;
-;;; SUM over the wrapper cache numbers,
-;;; ENSURING that the result is a fixnum
-;;; MASK the result against the mask argument.
+;;; FIXME: It would be nice to take the generic function optimization
+;;; policy into account here (speed vs. space.)
+(declaim (inline compute-limit))
+(defun compute-limit (size)
+ (ceiling (sqrt size) 2))
+
+;;; Returns VALUE if it is not ..EMPTY.., otherwise executes ELSE:
+(defmacro non-empty-or (value else)
+ (with-unique-names (n-value)
+ `(let ((,n-value ,value))
+ (if (eq ,n-value '..empty..)
+ ,else
+ ,n-value))))
+
+;;; Fast way to check if a thing found at the position of a cache key is one:
+;;; it is always either a wrapper, or the ..EMPTY.. symbol.
+(declaim (inline cache-key-p))
+(defun cache-key-p (thing)
+ (not (symbolp thing)))
-;;; The basic functional version. This is used by the cache miss code to
-;;; compute the primary location of an entry.
-(defun compute-primary-cache-location (mask wrappers)
- (declare (fixnum mask))
- (if (not (listp wrappers))
- (logand mask (layout-clos-hash wrappers))
- (let ((location 0)
- (i 0))
- (declare (fixnum location i))
- (dolist (wrapper wrappers)
- ;; First add the cache number of this wrapper to location.
- (let ((wrapper-cache-number (layout-clos-hash wrapper)))
- (if (zerop wrapper-cache-number)
- (return-from compute-primary-cache-location 0)
- (incf location wrapper-cache-number)))
- ;; Then, if we are working with lots of wrappers, deal with
- ;; the wrapper-cache-number-mask stuff.
- (when (and (not (zerop i))
- (zerop (mod i wrapper-cache-number-adds-ok)))
- (setq location
- (logand location wrapper-cache-number-mask)))
- (incf i))
- (1+ (logand mask location)))))
-
-;;; This version is called on a cache line. It fetches the wrappers
-;;; from the cache line and determines the primary location. Various
-;;; parts of the cache filling code call this to determine whether it
-;;; is appropriate to displace a given cache entry.
-;;;
-;;; If this comes across a wrapper whose CACHE-NO is 0, it returns the
-;;; symbol invalid to suggest to its caller that it would be provident
-;;; to blow away the cache line in question.
-(defun compute-primary-cache-location-from-location (to-cache
- from-location
- &optional
- (from-cache to-cache))
- (declare (type cache to-cache from-cache) (fixnum from-location))
- (let ((result 0)
- (cache-vector (cache-vector from-cache))
- (mask (cache-mask to-cache))
- (nkeys (cache-nkeys to-cache)))
- (declare (fixnum result mask nkeys)
- (simple-vector cache-vector))
- (dotimes-fixnum (i nkeys)
- ;; FIXME: Sometimes we get NIL here as wrapper, apparently because
- ;; another thread has stomped on the cache-vector.
- (let* ((wrapper (cache-vector-ref cache-vector (+ i from-location)))
- (wcn (layout-clos-hash wrapper)))
- (incf result wcn))
- (when (and (not (zerop i))
- (zerop (mod i wrapper-cache-number-adds-ok)))
- (setq result (logand result wrapper-cache-number-mask))))
- (if (= nkeys 1)
- (logand mask result)
- (1+ (logand mask result)))))
-\f
-(defmacro with-local-cache-functions ((cache) &body body)
- `(let ((.cache. ,cache))
- (declare (type cache .cache.))
- (labels ((cache () .cache.)
- (nkeys () (cache-nkeys .cache.))
- (line-size () (cache-line-size .cache.))
- (c-vector () (cache-vector .cache.))
- (valuep () (cache-valuep .cache.))
- (nlines () (cache-nlines .cache.))
- (max-location () (cache-max-location .cache.))
- (limit-fn () (cache-limit-fn .cache.))
- (size () (cache-size .cache.))
- (mask () (cache-mask .cache.))
- (overflow () (cache-overflow .cache.))
- ;;
- ;; Return T IFF this cache location is reserved. The
- ;; only time this is true is for line number 0 of an
- ;; nkeys=1 cache.
- ;;
- (line-reserved-p (line)
- (declare (fixnum line))
- (and (= (nkeys) 1)
- (= line 0)))
- ;;
- (location-reserved-p (location)
- (declare (fixnum location))
- (and (= (nkeys) 1)
- (= location 0)))
- ;;
- ;; Given a line number, return the cache location.
- ;; This is the value that is the second argument to
- ;; cache-vector-ref. Basically, this deals with the
- ;; offset of nkeys>1 caches and multiplies by line
- ;; size.
- ;;
- (line-location (line)
- (declare (fixnum line))
- (when (line-reserved-p line)
- (error "line is reserved"))
- (if (= (nkeys) 1)
- (the fixnum (* line (line-size)))
- (the fixnum (1+ (the fixnum (* line (line-size)))))))
- ;;
- ;; Given a cache location, return the line. This is
- ;; the inverse of LINE-LOCATION.
- ;;
- (location-line (location)
- (declare (fixnum location))
- (if (= (nkeys) 1)
- (floor location (line-size))
- (floor (the fixnum (1- location)) (line-size))))
- ;;
- ;; Given a line number, return the wrappers stored at
- ;; that line. As usual, if nkeys=1, this returns a
- ;; single value. Only when nkeys>1 does it return a
- ;; list. An error is signalled if the line is
- ;; reserved.
- ;;
- (line-wrappers (line)
- (declare (fixnum line))
- (when (line-reserved-p line) (error "Line is reserved."))
- (location-wrappers (line-location line)))
- ;;
- (location-wrappers (location) ; avoid multiplies caused by line-location
- (declare (fixnum location))
- (if (= (nkeys) 1)
- (cache-vector-ref (c-vector) location)
- (let ((list (make-list (nkeys)))
- (vector (c-vector)))
- (declare (simple-vector vector))
- (dotimes (i (nkeys) list)
- (declare (fixnum i))
- (setf (nth i list)
- (cache-vector-ref vector (+ location i)))))))
- ;;
- ;; Given a line number, return true IFF the line's
- ;; wrappers are the same as wrappers.
- ;;
- (line-matches-wrappers-p (line wrappers)
- (declare (fixnum line))
- (and (not (line-reserved-p line))
- (location-matches-wrappers-p (line-location line)
- wrappers)))
- ;;
- (location-matches-wrappers-p (loc wrappers) ; must not be reserved
- (declare (fixnum loc))
- (let ((cache-vector (c-vector)))
- (declare (simple-vector cache-vector))
- (if (= (nkeys) 1)
- (eq wrappers (cache-vector-ref cache-vector loc))
- (dotimes (i (nkeys) t)
- (declare (fixnum i))
- (unless (eq (pop wrappers)
- (cache-vector-ref cache-vector (+ loc i)))
- (return nil))))))
- ;;
- ;; Given a line number, return the value stored at that line.
- ;; If valuep is NIL, this returns NIL. As with line-wrappers,
- ;; an error is signalled if the line is reserved.
- ;;
- (line-value (line)
- (declare (fixnum line))
- (when (line-reserved-p line) (error "Line is reserved."))
- (location-value (line-location line)))
- ;;
- (location-value (loc)
- (declare (fixnum loc))
- (and (valuep)
- (cache-vector-ref (c-vector) (+ loc (nkeys)))))
- ;;
- ;; Given a line number, return true IFF that line has data in
- ;; it. The state of the wrappers stored in the line is not
- ;; checked. An error is signalled if line is reserved.
- (line-full-p (line)
- (when (line-reserved-p line) (error "Line is reserved."))
- (not (null (cache-vector-ref (c-vector) (line-location line)))))
- ;;
- ;; Given a line number, return true IFF the line is full and
- ;; there are no invalid wrappers in the line, and the line's
- ;; wrappers are different from wrappers.
- ;; An error is signalled if the line is reserved.
- ;;
- (line-valid-p (line wrappers)
- (declare (fixnum line))
- (when (line-reserved-p line) (error "Line is reserved."))
- (location-valid-p (line-location line) wrappers))
- ;;
- (location-valid-p (loc wrappers)
- (declare (fixnum loc))
- (let ((cache-vector (c-vector))
- (wrappers-mismatch-p (null wrappers)))
- (declare (simple-vector cache-vector))
- (dotimes (i (nkeys) wrappers-mismatch-p)
- (declare (fixnum i))
- (let ((wrapper (cache-vector-ref cache-vector (+ loc i))))
- (when (or (null wrapper)
- (invalid-wrapper-p wrapper))
- (return nil))
- (unless (and wrappers
- (eq wrapper
- (if (consp wrappers)
- (pop wrappers)
- wrappers)))
- (setq wrappers-mismatch-p t))))))
- ;;
- ;; How many unreserved lines separate line-1 and line-2.
- ;;
- (line-separation (line-1 line-2)
- (declare (fixnum line-1 line-2))
- (let ((diff (the fixnum (- line-2 line-1))))
- (declare (fixnum diff))
- (when (minusp diff)
- (setq diff (+ diff (nlines)))
- (when (line-reserved-p 0)
- (setq diff (1- diff))))
- diff))
- ;;
- ;; Given a cache line, get the next cache line. This will not
- ;; return a reserved line.
- ;;
- (next-line (line)
- (declare (fixnum line))
- (if (= line (the fixnum (1- (nlines))))
- (if (line-reserved-p 0) 1 0)
- (the fixnum (1+ line))))
- ;;
- (next-location (loc)
- (declare (fixnum loc))
- (if (= loc (max-location))
- (if (= (nkeys) 1)
- (line-size)
- 1)
- (the fixnum (+ loc (line-size)))))
- ;;
- ;; Given a line which has a valid entry in it, this
- ;; will return the primary cache line of the wrappers
- ;; in that line. We just call
- ;; COMPUTE-PRIMARY-CACHE-LOCATION-FROM-LOCATION, this
- ;; is an easier packaging up of the call to it.
- ;;
- (line-primary (line)
- (declare (fixnum line))
- (location-line (line-primary-location line)))
- ;;
- (line-primary-location (line)
- (declare (fixnum line))
- (compute-primary-cache-location-from-location
- (cache) (line-location line))))
- (declare (ignorable #'cache #'nkeys #'line-size #'c-vector #'valuep
- #'nlines #'max-location #'limit-fn #'size
- #'mask #'overflow #'line-reserved-p
- #'location-reserved-p #'line-location
- #'location-line #'line-wrappers #'location-wrappers
- #'line-matches-wrappers-p
- #'location-matches-wrappers-p
- #'line-value #'location-value #'line-full-p
- #'line-valid-p #'location-valid-p
- #'line-separation #'next-line #'next-location
- #'line-primary #'line-primary-location))
- ,@body)))
-\f
-;;; Here is where we actually fill, recache and expand caches.
-;;;
-;;; The functions FILL-CACHE and PROBE-CACHE are the ONLY external
-;;; entrypoints into this code.
+(eval-when (:compile-toplevel :load-toplevel :execute)
+ (sb-kernel:define-structure-slot-compare-and-swap compare-and-swap-cache-depth
+ :structure cache
+ :slot depth))
+
+;;; Utility macro for atomic updates without locking... doesn't
+;;; do much right now, and it would be nice to make this more magical.
+(defmacro compare-and-swap (place old new)
+ (unless (consp place)
+ (error "Don't know how to compare and swap ~S." place))
+ (ecase (car place)
+ (svref
+ `(simple-vector-compare-and-swap ,@(cdr place) ,old ,new))
+ (cache-depth
+ `(compare-and-swap-cache-depth ,@(cdr place) ,old ,new))))
+
+;;; Atomically update the current probe depth of a cache.
+(defun note-cache-depth (cache depth)
+ (loop for old = (cache-depth cache)
+ while (and (< old depth)
+ (not (eq old (compare-and-swap (cache-depth cache)
+ old depth))))))
+
+;;; Compute the starting index of the next cache line in the cache vector.
+(declaim (inline next-cache-index))
+(defun next-cache-index (mask index line-size)
+ (logand mask (+ index line-size)))
+
+;;; Returns the hash-value for layout, or executes ELSE if the layout
+;;; is invalid.
+(defmacro hash-layout-or (layout else)
+ (with-unique-names (n-hash)
+ `(let ((,n-hash (layout-clos-hash ,layout)))
+ (if (zerop ,n-hash)
+ ,else
+ ,n-hash))))
+
+;;; Compute cache index for the cache and a list of layouts.
+(declaim (inline compute-cache-index))
+(defun compute-cache-index (cache layouts)
+ (let ((index (hash-layout-or (car layouts)
+ (return-from compute-cache-index nil))))
+ (dolist (layout (cdr layouts))
+ (mixf index (hash-layout-or layout (return-from compute-cache-index nil))))
+ ;; align with cache lines
+ (logand (* (cache-line-size cache) index) (cache-mask cache))))
+
+;;; Emit code that does lookup in cache bound to CACHE-VAR using
+;;; layouts bound to LAYOUT-VARS. Go to MISS-TAG on event of a miss or
+;;; invalid layout. Otherwise, if VALUE-VAR is non-nil, set it to the
+;;; value found. (VALUE-VAR is non-nil only when CACHE-VALUE is true.)
;;;
-;;; FILL-CACHE returns 1 value: a new cache
+;;; In other words, produces inlined code for COMPUTE-CACHE-INDEX when
+;;; number of keys and presence of values in the cache is known
+;;; beforehand.
+(defun emit-cache-lookup (cache-var layout-vars miss-tag value-var)
+ (let ((line-size (power-of-two-ceiling (+ (length layout-vars)
+ (if value-var 1 0)))))
+ (with-unique-names (n-index n-vector n-depth n-pointer n-mask
+ MATCH-WRAPPERS EXIT-WITH-HIT)
+ `(let* ((,n-index (hash-layout-or ,(car layout-vars) (go ,miss-tag)))
+ (,n-vector (cache-vector ,cache-var)))
+ (declare (index ,n-index))
+ ,@(mapcar (lambda (layout-var)
+ `(mixf ,n-index (hash-layout-or ,layout-var (go ,miss-tag))))
+ (cdr layout-vars))
+ ;; align with cache lines
+ (setf ,n-index (logand (* ,line-size ,n-index) (cache-mask ,cache-var)))
+ (let ((,n-depth (cache-depth ,cache-var))
+ (,n-pointer ,n-index)
+ (,n-mask (cache-mask ,cache-var)))
+ (declare (index ,n-depth ,n-pointer))
+ (tagbody
+ ,MATCH-WRAPPERS
+ (when (and ,@(mapcar
+ (lambda (layout-var)
+ `(prog1
+ (eq ,layout-var (svref ,n-vector ,n-pointer))
+ (incf ,n-pointer)))
+ layout-vars))
+ ,@(when value-var
+ `((setf ,value-var (non-empty-or (svref ,n-vector ,n-pointer)
+ (go ,miss-tag)))))
+ (go ,EXIT-WITH-HIT))
+ (if (zerop ,n-depth)
+ (go ,miss-tag)
+ (decf ,n-depth))
+ (setf ,n-index (next-cache-index ,n-mask ,n-index ,line-size)
+ ,n-pointer ,n-index)
+ (go ,MATCH-WRAPPERS)
+ ,EXIT-WITH-HIT))))))
+
+;;; Probes CACHE for LAYOUTS.
;;;
-;;; a wrapper field number
-;;; a cache
-;;; a mask
-;;; an absolute cache size (the size of the actual vector)
-;;; It tries to re-adjust the cache every time it makes a new fill.
-;;; The intuition here is that we want uniformity in the number of
-;;; probes needed to find an entry. Furthermore, adjusting has the
-;;; nice property of throwing out any entries that are invalid.
-(defvar *cache-expand-threshold* 1.25)
-
-(defun fill-cache (cache wrappers value)
- ;; FILL-CACHE won't return if WRAPPERS is nil, might as well check..
- (aver wrappers)
- (or (fill-cache-p nil cache wrappers value)
- (expand-cache cache wrappers value)))
-
-(defvar *check-cache-p* nil)
-
-(defmacro maybe-check-cache (cache)
- `(progn
- (when *check-cache-p*
- (check-cache ,cache))
- ,cache))
-
-(defun check-cache (cache)
- (with-local-cache-functions (cache)
- (let ((location (if (= (nkeys) 1) 0 1))
- (limit (funcall (limit-fn) (nlines))))
- (dotimes-fixnum (i (nlines) cache)
- (when (and (not (location-reserved-p location))
- (line-full-p i))
- (let* ((home-loc (compute-primary-cache-location-from-location
- cache location))
- (home (location-line (if (location-reserved-p home-loc)
- (next-location home-loc)
- home-loc)))
- (sep (when home (line-separation home i))))
- (when (and sep (> sep limit))
- (error "bad cache ~S ~@
- value at location ~W: ~W lines from its home. The limit is ~W."
- cache location sep limit))))
- (setq location (next-location location))))))
-
-(defun probe-cache (cache wrappers &optional default limit-fn)
- (aver wrappers)
- (with-local-cache-functions (cache)
- (let* ((location (compute-primary-cache-location (mask) wrappers))
- (limit (funcall (or limit-fn (limit-fn)) (nlines))))
- (declare (fixnum location limit))
- (when (location-reserved-p location)
- (setq location (next-location location)))
- (dotimes-fixnum (i (1+ limit))
- (when (location-matches-wrappers-p location wrappers)
- (return-from probe-cache (or (not (valuep))
- (location-value location))))
- (setq location (next-location location)))
- (dolist (entry (overflow))
- (when (equal (car entry) wrappers)
- (return-from probe-cache (or (not (valuep))
- (cdr entry)))))
- default)))
-
-(defun map-cache (function cache &optional set-p)
- (with-local-cache-functions (cache)
- (let ((set-p (and set-p (valuep))))
- (dotimes-fixnum (i (nlines) cache)
- (unless (or (line-reserved-p i) (not (line-valid-p i nil)))
- (let ((value (funcall function (line-wrappers i) (line-value i))))
- (when set-p
- ;; FIXME: Cache modification: should we not be holding a lock?
- (setf (cache-vector-ref (c-vector) (+ (line-location i) (nkeys)))
- value)))))
- (dolist (entry (overflow))
- (let ((value (funcall function (car entry) (cdr entry))))
- (when set-p
- (setf (cdr entry) value))))))
+;;; Returns two values: a boolean indicating a hit or a miss, and a secondary
+;;; value that is the value that was stored in the cache if any.
+(defun probe-cache (cache layouts)
+ (unless (consp layouts)
+ (setf layouts (list layouts)))
+ (let ((vector (cache-vector cache))
+ (key-count (cache-key-count cache))
+ (line-size (cache-line-size cache))
+ (mask (cache-mask cache)))
+ (flet ((probe-line (base)
+ (tagbody
+ (loop for offset from 0 below key-count
+ for layout in layouts do
+ (unless (eq layout (svref vector (+ base offset)))
+ ;; missed
+ (go :miss)))
+ ;; all layouts match!
+ (let ((value (when (cache-value cache)
+ (non-empty-or (svref vector (+ base key-count))
+ (go :miss)))))
+ (return-from probe-cache (values t value)))
+ :miss
+ (return-from probe-line (next-cache-index mask base line-size)))))
+ (let ((index (compute-cache-index cache layouts)))
+ (when index
+ (loop repeat (1+ (cache-depth cache)) do
+ (setf index (probe-line index)))))))
+ (values nil nil))
+
+;;; Tries to write LAYOUTS and VALUE at the cache line starting at
+;;; the index BASE. Returns true on success, and false on failure.
+(defun try-update-cache-line (cache base layouts value)
+ (declare (index base))
+ (let ((vector (cache-vector cache))
+ (new (pop layouts)))
+ ;; If we unwind from here, we will be left with an incomplete
+ ;; cache line, but that is OK: next write using the same layouts
+ ;; will fill it, and reads will treat an incomplete line as a
+ ;; miss -- causing it to be filled.
+ (loop for old = (compare-and-swap (svref vector base) '..empty.. new) do
+ (when (and (cache-key-p old) (not (eq old new)))
+ ;; The place was already taken, and doesn't match our key.
+ (return-from try-update-cache-line nil))
+ (unless layouts
+ ;; All keys match or succesfully saved, save our value --
+ ;; just smash it in. Until the first time it is written
+ ;; there is ..EMPTY.. here, which probes look for, so we
+ ;; don't get bogus hits. This is necessary because we want
+ ;; to be able store arbitrary values here for use with
+ ;; constant-value dispatch functions.
+ (when (cache-value cache)
+ (setf (svref vector (1+ base)) value))
+ (return-from try-update-cache-line t))
+ (setf new (pop layouts))
+ (incf base))))
+
+;;; Tries to write LAYOUTS and VALUE somewhere in the cache. Returns
+;;; true on success and false on failure, meaning the cache is too
+;;; full.
+(defun try-update-cache (cache layouts value)
+ (let ((vector (cache-vector cache))
+ (index (or (compute-cache-index cache layouts)
+ ;; At least one of the layouts was invalid: just
+ ;; pretend we updated the cache, and let the next
+ ;; read pick up the mess.
+ (return-from try-update-cache t)))
+ (line-size (cache-line-size cache))
+ (mask (cache-mask cache)))
+ (declare (index index))
+ (loop for depth from 0 upto (cache-limit cache) do
+ (when (try-update-cache-line cache index layouts value)
+ (note-cache-depth cache depth)
+ (return-from try-update-cache t))
+ (setf index (next-cache-index mask index line-size)))))
+
+;;; Constructs a new cache.
+(defun make-cache (&key (key-count (missing-arg)) (value (missing-arg))
+ (size 1))
+ (let* ((line-size (power-of-two-ceiling (+ key-count (if value 1 0))))
+ (adjusted-size (power-of-two-ceiling size))
+ (length (* adjusted-size line-size)))
+ (if (<= length +cache-vector-max-length+)
+ (%make-cache :key-count key-count
+ :line-size line-size
+ :vector (make-array length :initial-element '..empty..)
+ :value value
+ :mask (1- length)
+ :limit (compute-limit adjusted-size))
+ ;; Make a smaller one, then
+ (make-cache :key-count key-count :value value :size (ceiling size 2)))))
+
+;;;; Copies and expands the cache, dropping any invalidated or
+;;;; incomplete lines.
+(defun copy-and-expand-cache (cache)
+ (let ((copy (%copy-cache cache))
+ (length (length (cache-vector cache))))
+ (when (< length +cache-vector-max-length+)
+ (setf length (* 2 length)))
+ (tagbody
+ :again
+ (setf (cache-vector copy) (make-array length :initial-element '..empty..)
+ (cache-depth copy) 0
+ (cache-mask copy) (1- length)
+ (cache-limit copy) (compute-limit (/ length (cache-line-size cache))))
+ (map-cache (lambda (layouts value)
+ (unless (try-update-cache copy layouts value)
+ ;; If the cache would grow too much we drop the
+ ;; remaining the entries that don't fit. FIXME:
+ ;; It would be better to drop random entries to
+ ;; avoid getting into a rut here (best done by
+ ;; making MAP-CACHE map in a random order?), and
+ ;; possibly to downsize the cache more
+ ;; aggressively (on the assumption that most
+ ;; entries aren't getting used at the moment.)
+ (when (< length +cache-vector-max-length+)
+ (setf length (* 2 length))
+ (go :again))))
+ cache))
+ copy))
+
+(defun cache-has-invalid-entries-p (cache)
+ (and (find-if (lambda (elt)
+ (and (typep elt 'layout)
+ (zerop (layout-clos-hash elt))))
+ (cache-vector cache))
+ t))
+
+(defun hash-table-to-cache (table &key value key-count)
+ (let ((cache (make-cache :key-count key-count :value value
+ :size (hash-table-count table))))
+ (maphash (lambda (class value)
+ (setq cache (fill-cache cache (class-wrapper class) value)))
+ table)
+ cache))
+
+;;; Inserts VALUE to CACHE keyd by LAYOUTS. Expands the cache if
+;;; necessary, and returns the new cache.
+(defun fill-cache (cache layouts value)
+ (labels
+ ((%fill-cache (cache layouts value)
+ (cond ((try-update-cache cache layouts value)
+ cache)
+ ((cache-has-invalid-entries-p cache)
+ ;; Don't expand yet: maybe there will be enough space if
+ ;; we just drop the invalid entries.
+ (%fill-cache (copy-cache cache) layouts value))
+ (t
+ (%fill-cache (copy-and-expand-cache cache) layouts value)))))
+ (if (listp layouts)
+ (%fill-cache cache layouts value)
+ (%fill-cache cache (list layouts) value))))
+
+;;; Calls FUNCTION with all layouts and values in cache.
+(defun map-cache (function cache)
+ (let* ((vector (cache-vector cache))
+ (key-count (cache-key-count cache))
+ (valuep (cache-value cache))
+ (line-size (cache-line-size cache))
+ (mask (cache-mask cache))
+ (fun (if (functionp function)
+ function
+ (fdefinition function)))
+ (index 0)
+ (key nil))
+ (tagbody
+ :map
+ (let ((layouts
+ (loop for offset from 0 below key-count
+ collect (non-empty-or (svref vector (+ offset index))
+ (go :next)))))
+ (let ((value (when valuep
+ (non-empty-or (svref vector (+ index key-count))
+ (go :next)))))
+ ;; Let the callee worry about invalid layouts
+ (funcall fun layouts value)))
+ :next
+ (setf index (next-cache-index mask index line-size))
+ (unless (zerop index)
+ (go :map))))
cache)
-(defun cache-count (cache)
- (with-local-cache-functions (cache)
- (let ((count 0))
- (declare (fixnum count))
- (dotimes-fixnum (i (nlines) count)
- (unless (line-reserved-p i)
- (when (line-full-p i)
- (incf count)))))))
-
-(defun entry-in-cache-p (cache wrappers value)
- (declare (ignore value))
- (with-local-cache-functions (cache)
- (dotimes-fixnum (i (nlines))
- (unless (line-reserved-p i)
- (when (equal (line-wrappers i) wrappers)
- (return t))))))
-
-;;; returns T or NIL
-;;;
-;;; FIXME: Deceptive name as this has side-effects.
-(defun fill-cache-p (forcep cache wrappers value)
- (with-local-cache-functions (cache)
- (let* ((location (compute-primary-cache-location (mask) wrappers))
- (primary (location-line location)))
- (declare (fixnum location primary))
- ;; FIXME: I tried (aver (> location 0)) and (aver (not
- ;; (location-reserved-p location))) here, on the basis that
- ;; particularly passing a LOCATION of 0 for a cache with more
- ;; than one key would cause PRIMARY to be -1. However, the
- ;; AVERs triggered during the bootstrap, and removing them
- ;; didn't cause anything to break, so I've left them removed.
- ;; I'm still confused as to what is right. -- CSR, 2006-04-20
- (multiple-value-bind (free emptyp)
- (find-free-cache-line primary cache wrappers)
- (when (or forcep emptyp)
- (when (not emptyp)
- (push (cons (line-wrappers free) (line-value free))
- (cache-overflow cache)))
- ;; (fill-line free wrappers value)
- (let ((line free))
- (declare (fixnum line))
- (when (line-reserved-p line)
- (error "attempt to fill a reserved line"))
- (let ((loc (line-location line))
- (cache-vector (c-vector)))
- (declare (fixnum loc) (simple-vector cache-vector))
- ;; FIXME: Cache modifications: should we not be holding
- ;; a lock?
- (cond ((= (nkeys) 1)
- (setf (cache-vector-ref cache-vector loc) wrappers)
- (when (valuep)
- (setf (cache-vector-ref cache-vector (1+ loc)) value)))
- (t
- (let ((i 0))
- (declare (fixnum i))
- (dolist (w wrappers)
- (setf (cache-vector-ref cache-vector (+ loc i)) w)
- (setq i (the fixnum (1+ i)))))
- (when (valuep)
- (setf (cache-vector-ref cache-vector (+ loc (nkeys)))
- value))))
- (maybe-check-cache cache))))))))
-
-;;; FIXME: Deceptive name as this has side-effects
-(defun fill-cache-from-cache-p (forcep cache from-cache from-line)
- (declare (fixnum from-line))
- (with-local-cache-functions (cache)
- (let ((primary (location-line
- (compute-primary-cache-location-from-location
- cache (line-location from-line) from-cache))))
- (declare (fixnum primary))
- (multiple-value-bind (free emptyp)
- (find-free-cache-line primary cache)
- (when (or forcep emptyp)
- (when (not emptyp)
- (push (cons (line-wrappers free) (line-value free))
- (cache-overflow cache)))
- ;;(transfer-line from-cache-vector from-line cache-vector free)
- (let ((from-cache-vector (cache-vector from-cache))
- (to-cache-vector (c-vector))
- (to-line free))
- (declare (fixnum to-line))
- (if (line-reserved-p to-line)
- (error "transferring something into a reserved cache line")
- (let ((from-loc (line-location from-line))
- (to-loc (line-location to-line)))
- (declare (fixnum from-loc to-loc))
- (modify-cache to-cache-vector
- (dotimes-fixnum (i (line-size))
- (setf (cache-vector-ref to-cache-vector
- (+ to-loc i))
- (cache-vector-ref from-cache-vector
- (+ from-loc i)))))))
- (maybe-check-cache cache)))))))
-
-;;; returns: (values <cache>)
-(defun expand-cache (cache wrappers value)
- ;;(declare (values cache))
- (with-local-cache-functions (cache)
- (let ((ncache (get-cache-from-cache cache (* (nlines) 2))))
- (labels ((do-one-fill-from-line (line)
- (unless (fill-cache-from-cache-p nil ncache cache line)
- (do-one-fill (line-wrappers line) (line-value line))))
- (do-one-fill (wrappers value)
- (setq ncache (fill-cache-p t ncache wrappers value)))
- (try-one-fill (wrappers value)
- (fill-cache-p nil ncache wrappers value)))
- (dotimes-fixnum (i (nlines))
- (when (and (null (line-reserved-p i))
- (line-valid-p i wrappers))
- (do-one-fill-from-line i)))
- (dolist (wrappers+value (cache-overflow cache))
- (unless (try-one-fill (car wrappers+value) (cdr wrappers+value))
- (do-one-fill (car wrappers+value) (cdr wrappers+value))))
- (unless (try-one-fill wrappers value)
- (do-one-fill wrappers value))
- (maybe-check-cache ncache)))))
-\f
-(defvar *pcl-misc-random-state* (make-random-state))
-
-;;; This is the heart of the cache filling mechanism. It implements
-;;; the decisions about where entries are placed.
-;;;
-;;; Find a line in the cache at which a new entry can be inserted.
-;;;
-;;; <line>
-;;; <empty?> is <line> in fact empty?
-(defun find-free-cache-line (primary cache &optional wrappers)
- ;;(declare (values line empty?))
- (declare (fixnum primary))
- (with-local-cache-functions (cache)
- (when (line-reserved-p primary) (setq primary (next-line primary)))
- (let ((limit (funcall (limit-fn) (nlines)))
- (wrappedp nil)
- (lines nil)
- (p primary) (s primary))
- (declare (fixnum p s limit))
- (block find-free
- (loop
- ;; Try to find a free line starting at <s>. <p> is the
- ;; primary line of the entry we are finding a free
- ;; line for, it is used to compute the separations.
- (do* ((line s (next-line line))
- (nsep (line-separation p s) (1+ nsep)))
- (())
- (declare (fixnum line nsep))
- (when (null (line-valid-p line wrappers)) ;If this line is empty or
- (push line lines) ;invalid, just use it.
- (return-from find-free))
- (when (and wrappedp (>= line primary))
- ;; have gone all the way around the cache, time to quit
- (return-from find-free-cache-line (values primary nil)))
- (let ((osep (line-separation (line-primary line) line)))
- (when (>= osep limit)
- (return-from find-free-cache-line (values primary nil)))
- (when (cond ((= nsep limit) t)
- ((= nsep osep)
- (zerop (random 2 *pcl-misc-random-state*)))
- ((> nsep osep) t)
- (t nil))
- ;; See whether we can displace what is in this line so that we
- ;; can use the line.
- (when (= line (the fixnum (1- (nlines)))) (setq wrappedp t))
- (setq p (line-primary line))
- (setq s (next-line line))
- (push line lines)
- (return nil)))
- (when (= line (the fixnum (1- (nlines)))) (setq wrappedp t)))))
- ;; Do all the displacing.
- (loop
- (when (null (cdr lines)) (return nil))
- (let ((dline (pop lines))
- (line (car lines)))
- (declare (fixnum dline line))
- ;;Copy from line to dline (dline is known to be free).
- (let ((from-loc (line-location line))
- (to-loc (line-location dline))
- (cache-vector (c-vector)))
- (declare (fixnum from-loc to-loc) (simple-vector cache-vector))
- (modify-cache cache-vector
- (dotimes-fixnum (i (line-size))
- (setf (cache-vector-ref cache-vector
- (+ to-loc i))
- (cache-vector-ref cache-vector
- (+ from-loc i)))
- (setf (cache-vector-ref cache-vector
- (+ from-loc i))
- nil))))))
- (values (car lines) t))))
-
-(defun default-limit-fn (nlines)
- (case nlines
- ((1 2 4) 1)
- ((8 16) 4)
- (otherwise 6)))
+;;; Copying a cache without expanding it is very much like mapping it:
+;;; we need to be carefull because there may be updates while we are
+;;; copying it, and we don't want to copy incomplete entries or invalid
+;;; ones.
+(defun copy-cache (cache)
+ (let* ((vector (cache-vector cache))
+ (copy (make-array (length vector) :initial-element '..empty..))
+ (line-size (cache-line-size cache))
+ (key-count (cache-key-count cache))
+ (valuep (cache-value cache))
+ (size (/ (length vector) line-size))
+ (mask (cache-mask cache))
+ (index 0)
+ (elt nil)
+ (depth 0))
+ (tagbody
+ :copy
+ (let ((layouts (loop for offset from 0 below key-count
+ collect (non-empty-or (svref vector (+ index offset))
+ (go :next)))))
+ ;; Check validity & compute primary index.
+ (let ((primary (or (compute-cache-index cache layouts)
+ (go :next))))
+ ;; Check & copy value.
+ (when valuep
+ (setf (svref copy (+ index key-count))
+ (non-empty-or (svref vector (+ index key-count))
+ (go :next))))
+ ;; Copy layouts.
+ (loop for offset from 0 below key-count do
+ (setf (svref copy (+ index offset)) (pop layouts)))
+ ;; Update probe depth.
+ (let ((distance (/ (- index primary) line-size)))
+ (setf depth (max depth (if (minusp distance)
+ ;; account for wrap-around
+ (+ distance size)
+ distance))))))
+ :next
+ (setf index (next-cache-index mask index line-size))
+ (unless (zerop index)
+ (go :copy)))
+ (%make-cache :vector copy
+ :depth depth
+ :key-count (cache-key-count cache)
+ :line-size line-size
+ :value valuep
+ :mask (cache-mask cache)
+ :limit (cache-limit cache))))