1.0.16.34: Remove global STACK-ALLOCATE-VALUE-CELLS proclamation in make-host-2.lisp

* 1.0.16.29 introduced a new optimization quality to control the stack-allocation
  of value cells. All the places in the code base where it was needed now declare
  it explicitly.

diff --git a/make-host-2.lisp b/make-host-2.lisp
index 7e66112..8bc96bf 100644 (file)
--- a/make-host-2.lisp
+++ b/make-host-2.lisp
@@ -29,9 +29,7 @@
        ;; never insert stepper conditions
        (sb!c:insert-step-conditions 0)
        ;; always stack-allocate if requested
-       (sb!c::stack-allocate-dynamic-extent 3)
-       ;; ...even value cells!
-       (sb!c::stack-allocate-value-cells 3)))))
+       (sb!c::stack-allocate-dynamic-extent 3)))))
 (compile 'proclaim-target-optimization)
 
 (defun in-target-cross-compilation-mode (fun)

diff --git a/src/code/fd-stream.lisp b/src/code/fd-stream.lisp
index 853c3cd..1428363 100644 (file)
--- a/src/code/fd-stream.lisp
+++ b/src/code/fd-stream.lisp
@@ -847,7 +847,8 @@
   (let ((fd (fd-stream-fd stream))
         (errno 0)
         (count 0))
-    (declare (dynamic-extent fd errno count))
+    (declare (optimize sb!c::stack-allocate-value-cells)
+             (dynamic-extent fd errno count))
     (tagbody
        ;; Check for blocking input before touching the stream, as if
        ;; we happen to wait we are liable to be interrupted, and the

diff --git a/src/code/thread.lisp b/src/code/thread.lisp
index 6e6ebec..54092de 100644 (file)
--- a/src/code/thread.lisp
+++ b/src/code/thread.lisp
@@ -159,6 +159,7 @@ provided the default value is used for the mutex."
                   (declare (function function))
                   (flet ((%call-with-system-mutex ()
                            (dx-let (got-it)
+                             #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
                              (unwind-protect
                                   (when (setf got-it (get-mutex mutex))
                                     (funcall function))
@@ -180,6 +181,7 @@ provided the default value is used for the mutex."
     (declare (function function))
     (without-interrupts
       (dx-let (got-it)
+        #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
         (unwind-protect
              (when (setf got-it (get-spinlock spinlock))
                (funcall function))
@@ -192,6 +194,7 @@ provided the default value is used for the mutex."
                   (flet ((%call-with-system-spinlock ()
                            (dx-let ((inner-lock-p (eq *current-thread* (spinlock-value spinlock)))
                                     (got-it nil))
+                             #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
                              (unwind-protect
                                   (when (or inner-lock-p (setf got-it (get-spinlock spinlock)))
                                     (funcall function))
@@ -209,6 +212,7 @@ provided the default value is used for the mutex."
   (defun call-with-spinlock (function spinlock)
     (declare (function function))
     (dx-let ((got-it nil))
+      #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
       (without-interrupts
         (unwind-protect
              (when (setf got-it (allow-with-interrupts
@@ -220,6 +224,7 @@ provided the default value is used for the mutex."
   (defun call-with-mutex (function mutex value waitp)
     (declare (function function))
     (dx-let ((got-it nil))
+      #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
       (without-interrupts
         (unwind-protect
              (when (setq got-it (allow-with-interrupts
@@ -232,6 +237,7 @@ provided the default value is used for the mutex."
     (declare (function function))
     (dx-let ((inner-lock-p (eq (mutex-%owner mutex) *current-thread*))
              (got-it nil))
+      #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
       (without-interrupts
         (unwind-protect
              (when (or inner-lock-p (setf got-it (allow-with-interrupts
@@ -246,6 +252,7 @@ provided the default value is used for the mutex."
     (declare (function function))
     (dx-let ((inner-lock-p (eq (spinlock-value spinlock) *current-thread*))
           (got-it nil))
+      #-sb-xc-host (declare (optimize sb!c::stack-allocate-value-cells))
       (without-interrupts
         (unwind-protect
              (when (or inner-lock-p (setf got-it (allow-with-interrupts

diff --git a/version.lisp-expr b/version.lisp-expr
index 096d1e7..a4bb747 100644 (file)
--- a/version.lisp-expr
+++ b/version.lisp-expr
@@ -17,4 +17,4 @@
 ;;; checkins which aren't released. (And occasionally for internal
 ;;; versions, especially for internal versions off the main CVS
 ;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".)
-"1.0.16.33"
+"1.0.16.34"